From nobody Wed Jan 18 16:46:13 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nxs8l6kN6z2yMHM; Wed, 18 Jan 2023 16:46:15 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nxs8l5QPwz3PyW; Wed, 18 Jan 2023 16:46:15 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id I7eKpAyUBc9C4IBZnpS8Hr; Wed, 18 Jan 2023 16:46:15 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id IBZlphjR2yAOeIBZmpWU9W; Wed, 18 Jan 2023 16:46:15 +0000 X-Authority-Analysis: v=2.4 cv=e5oV9Il/ c=1 sm=1 tr=0 ts=63c82257 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=RvmDmJFTN0MA:10 a=iKhvJSA4AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=C4B0vsJxOSi1_OTPh5EA:9 a=CjuIK1q_8ugA:10 a=PaZFhfb9_QoA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A0F4B12F4; Wed, 18 Jan 2023 08:46:13 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 82F2B23D; Wed, 18 Jan 2023 08:46:13 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: rgrimes@freebsd.org cc: Cy Schubert , Juraj Lutter , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1d577bedbae8 - main - unbound: Fix config file path In-reply-to: <202301181640.30IGeTbo010751@gndrsh.dnsmgr.net> References: <202301181640.30IGeTbo010751@gndrsh.dnsmgr.net> Comments: In-reply-to "Rodney W. Grimes" message dated "Wed, 18 Jan 2023 08:40:29 -0800." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 18 Jan 2023 08:46:13 -0800 Message-Id: <20230118164613.82F2B23D@slippy.cwsent.com> X-CMAE-Envelope: MS4xfLP7Owybg8kfDnLvGbXkUAAy0OqKAfuXORRM0ZyiLybm0cgFdkIxl3YD5w18q3gKo5SNTa/3vX1C5KfZbLA+eF9luhwDsU11befxbgxQL7I9bg35IUOF rfOAhMePHBGgSVp8lbXBM08GeeWE5oQHT6fUJt6FSv48F9bQA8DSVJZhWnruEVy9yrhE0Xa3vjynRaqCl5c/8obA97bVAuM1CvmJRBXyAEToyoyAiTwZPYJg 356KWeiC0bOj9HJrUnODR8JNH/86FF4MzNhTmHR4N8UAIw25hqTdPegDHiTvn5Yz9Zws3T6CFrQYAnXHiNTGAsa+ojtpbMWgp0BNBmaTryIuUwY6k+QdSkiK 9oVfQblP X-Rspamd-Queue-Id: 4Nxs8l5QPwz3PyW X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N In message <202301181640.30IGeTbo010751@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > > In message <202301181551.30IFpbRu010474@gndrsh.dnsmgr.net>, "Rodney W. > > Grimes" > > writes: > > > [ Charset UTF-8 unsupported, converting... ] > > > > > > > > > > > > > On 18 Jan 2023, at 16:34, Rodney W. Grimes > wr > > > ote: > > > > > > > > > > No, otis fixed it thus: > > > > > -#define CONFIGFILE "/usr/local/etc/unbound/unbound.conf" > > > > > +#define CONFIGFILE "/var/unbound/unbound.conf" > > > > > > > > > > > > > > > > > > I am suggesting that it should be > > > > > #define CONFIGFILE "/etc/unbound/unbound.conf" > > > > > > > > > > ALL base system configuration files *should* be relative to /etc, not > /va > > > r. > > > > > > > > > > > > > Would this need any mtree changes or similar? > > > > > > No, /etc/unbound is a symbolic link already installed by the build system > , > > > and /var/unbound is already a directory, again, installed by the build sy > stem > > > . > > > > > > This is a one line change that actually makes the /etc/unbound link work > > > correctly, without this change the binary has a hard coded path that igno > res > > > the > > > /etc/unbound symbolic link and requires a recompile if I want to move > > > things around, or maintanance of 2 symbolic links. > > > > > > Personally I dont see *why* unbound has a /var/unbound directory, can > > > someone tell me why that was done? Is this some attempt and maintaining > > > read only root? Does unbound scribble in the config directory, or > > > is this simply mirroring some of the stuff that bind did? > > > > I see why it does this. Looking at usr.sbin/unbound/setup/local-unbound-set > u > > p.sh, it installs its config files in $workdir. Looking at git log > > 49cede74eecf4 (SVN r255809), the last paragraph in the commit log entry > > says: > > > > Note that these scripts place the unbound configuration files in > > /var/unbound rather than /etc/unbound. This is necessary so that > > unbound can reload its configuration while chrooted. We should > > probably provide symlinks in /etc. > > > > Providing symlinks in /etc/unbound appears to be the correct solution. > > For the forth or fith time, there already IS a symbolic link > etc/unbound -> ../var/unbound. Hmm. slippy$ lh /etc/unbound ls: /etc/unbound: No such file or directory slippy$ cwsys# lh /etc/unbound ls: /etc/unbound: No such file or directory cwsys# Seems it got deleted on two of my systems and never recreated. > > Just make the change I suggested and all is fine... On second thought, if the comment in the commit log is correct, the change you suggested would break running unbound chroot. Or do I misunderstand? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0