From nobody Mon Jan 16 04:45:15 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NwKFw2BTJz2sf4L; Mon, 16 Jan 2023 04:45:24 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NwKFw1hJpz3HS3; Mon, 16 Jan 2023 04:45:24 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673844324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=krDhNhK29BXoLWQ5RN2WSMDmmV/SE+RCHP+156DLAb0=; b=mO0AxPJdTd7tAUUHl4tk8wTBYiVkjWv/VMhAFxBl1L4W8uc3ETWDf7Nnc7v74KlNWz2xuI 8GoApsL0OJAgr6S6NUu/2yTgTtmH1bble7zc94Qh+dE5ynACL7MHwhHxjf0AJcPMS63Ion WHE+O3TUYBxZHjI/VsRy88aYe92IKuhuSkZ5eCK6Y8oNlY0rF6MrjXjOObFVJhMsehkxDt rlkXwGQNBUaFDES01iKxxgUQE1IyGbeEyEGs0Tyru3jHnfQRkNtx4Y2HysyKR1lq4XYD56 ooBHKD1Zx27wWiflNMGaW4RbPTYDEqMNKDNUh788KEkz//ms1xrzg581WUn2RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673844324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=krDhNhK29BXoLWQ5RN2WSMDmmV/SE+RCHP+156DLAb0=; b=Lfq858pkZ2iEn08DtOYC/SaBEqwgc4ZcrsLtpCuF6pbIBjuyz7k3RfUr8i2ozvMKz+GDp/ jpc0M5t7rcBmcBGZQDhngASvPeJd9v6/rMD7tx8mCgxFY2sXf23ysR8gvY5DtcgmfuJgw/ W370I33prDkYnj1o7Xxq4lWtDGkPAOLLuQQI61o2+b2tx7jCXFgkbJLyzCtyMS4sPlXH7G 62c06PSfLagUXqHGR915KrA+QUMP4coE3DYGNZbBhySBxWY4Eo0p0nQkKba5GsmkGsmPmB qn2dWkm2CimMVVdMt7RA2My8DX/y7bxBzcauypOKiudIiPQ9E/Au7o514oNGjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673844324; a=rsa-sha256; cv=none; b=WbfXdMVCmcIFakTNxTgiZqtkhDHO5XS8cQYI8qlVIBwnP0f8fqsbNqTU0ZUjibpVVD8kRL J9X53Yb0ExbfW82dZBB1tYdAgg2T/wUIJcU9jTJ+H8YJo4xdmjPqc6GErFLtUiT2qqypJ5 eIsF+UdIRdnxgHByDA6R5BJbem0SRnKo2ymBiAnpTEHnMKAvTk2RlQQ2yM7h3P8NpKGj2x mAXlpYZugdwctmzxmogzndUpQknIpwh6lZsADKhBUESpLmMFI1X3lRZn3k9h6IT7J19+16 1bfM4rIJJUgES1uun+jU7wndblc6wavzzZcWqrYZDmnDYPeLBogoGBOdLCg/Hg== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NwKFt63zlzFMK; Mon, 16 Jan 2023 04:45:22 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 8bce8d28abe6 - main - jail: Avoid multipurpose return value of function prison_ip_restrict() From: Zhenlei Huang In-Reply-To: Date: Mon, 16 Jan 2023 12:45:15 +0800 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <58ED512C-BE38-4EB6-A902-2AF3E25D5615@FreeBSD.org> References: <202301131046.30DAkA0F024400@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3696.120.41.1.1) X-ThisMailContainsUnwantedMimeParts: N Hi Gleb, Sorry for delayed response, I'll check that within days. Best regards, Zhenlei > On Jan 14, 2023, at 3:39 AM, Gleb Smirnoff = wrote: >=20 > Zhenlei, >=20 > a couple concise assignments missed: >=20 > Z> @@ -1876,15 +1871,15 @@ kern_jail_set(struct thread *td, struct uio = *optuio, int flags) > Z> continue; > Z> } > Z> #endif > Z> - if (prison_ip_restrict(tpr, PR_INET, NULL)) { > Z> - redo_ip4 =3D 1; > Z> + if (!prison_ip_restrict(tpr, PR_INET, NULL)) { > Z> + redo_ip4 =3D true; > Z> descend =3D 0; > Z> } > Z> } > Z> } >=20 > redo_ip4 =3D !prison_ip_restrict(tpr, PR_INET, NULL); >=20 > Z> @@ -1896,8 +1891,8 @@ kern_jail_set(struct thread *td, struct uio = *optuio, int flags) > Z> continue; > Z> } > Z> #endif > Z> - if (prison_ip_restrict(tpr, PR_INET6, NULL)) { > Z> - redo_ip6 =3D 1; > Z> + if (!prison_ip_restrict(tpr, PR_INET6, NULL)) { > Z> + redo_ip6 =3D true; > Z> descend =3D 0; > Z> } > Z> } >=20 > redo_ip6 =3D !prison_ip_restrict(tpr, PR_INET6, NULL); >=20 > --=20 > Gleb Smirnoff