Re: git: 5723e5ac6d76 - main - Add Naneng combo PHY support for RK3568 SoC.

On Fri, Jan 06, 2023 at 03:06:43AM +0000, Ganbold Tsagaankhuu wrote:
> The branch main has been updated by ganbold:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=5723e5ac6d7618ebec7e10185312e803898faffc
> 
> commit 5723e5ac6d7618ebec7e10185312e803898faffc
> Author:     Søren Schmidt <sos@FreeBSD.org>
> AuthorDate: 2023-01-06 03:00:18 +0000
> Commit:     Ganbold Tsagaankhuu <ganbold@FreeBSD.org>
> CommitDate: 2023-01-06 03:04:53 +0000
> 
>     Add Naneng combo PHY support for RK3568 SoC.
>     
>     It can be used as pcie-phy, usb3-phy, sata-phy or sgmii-phy.
> ---
>  sys/arm64/rockchip/rk3568_combphy.c | 469 ++++++++++++++++++++++++++++++++++++
>  sys/conf/files.arm64                |   1 +
>  2 files changed, 470 insertions(+)
> 
> diff --git a/sys/arm64/rockchip/rk3568_combphy.c b/sys/arm64/rockchip/rk3568_combphy.c
> new file mode 100644
> index 000000000000..e0374c844627
> --- /dev/null
> +++ b/sys/arm64/rockchip/rk3568_combphy.c
> @@ -0,0 +1,469 @@
> +/*-
> + * Copyright (c) 2021, 2022 Soren Schmidt <sos@deepcore.dk>
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> + * SUCH DAMAGE.
> + *
> + * $Id: rk3568_combphy.c 893 2022-07-26 09:47:22Z sos $
> + */
> +
> +#include <sys/cdefs.h>
These sys/cdefs.h includes are pointless and should not be done.

> +#include <sys/param.h>
> +#include <sys/bus.h>
> +#include <sys/kernel.h>
> +#include <sys/module.h>
> +#include <sys/mutex.h>
> +#include <sys/rman.h>
> +#include <machine/bus.h>