From nobody Thu Jan 05 03:59:44 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NnXmN32pWz2p8S2 for ; Thu, 5 Jan 2023 03:59:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NnXmN0TVHz4CMg for ; Thu, 5 Jan 2023 03:59:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f44.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so422736wmb.2 for ; Wed, 04 Jan 2023 19:59:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uP3/aXCkl9hZDrER4kdfn95/3jZTP0lqtD7SvZix5qs=; b=jwUiu94IFl8TMn86bPqyqGCqBcM7rcktSM/Aw1l3/PgEWHBgAJvcDJGsSiQkMl/i4Z wuTR/XomEcFeubC8ITpRN2TlzA5TVIQSR/4wiblUqX5lYMU/VPoBqn5lcbguoXOfiW3T A7fkaN15jnM8z+vDgrr6e45K2YdpYjjG7TmFd6PPj6bb6OozHdLCoHzvp3SJwIjvhG+z +UfGpqWNwjSiefzoNUmoLQRtiv+ii70UfUmrxr45GN3n6QNajFqSvC9DStneKsc4ZYTL eoQVqcg/MH3Dl0W6Zn8+vkNt4KkWGpm0JD6MLGS0dWA4Yx48nN9SzFD2LPumSD4YCZju 8xKQ== X-Gm-Message-State: AFqh2koNpjngzpXNlSaKsa3Gx0D5r4fc6xAhSVL4LvxQ/ejBj5j8BCfW zf7LCdx7uEa5oVrCShJQUzaPRg== X-Google-Smtp-Source: AMrXdXvePI1ACnzE17SDnockBSd5yj5z6Hbcsrrmf23W10itpqfP53VDgZGpzsl8YUw6xOmvDRCsDQ== X-Received: by 2002:a05:600c:3b8f:b0:3d0:480b:ac53 with SMTP id n15-20020a05600c3b8f00b003d0480bac53mr37946800wms.12.1672891186039; Wed, 04 Jan 2023 19:59:46 -0800 (PST) Received: from smtpclient.apple (global-5-143.n-2.net.cam.ac.uk. [131.111.5.143]) by smtp.gmail.com with ESMTPSA id z6-20020a05600c0a0600b003d96efd09b7sm924806wmp.19.2023.01.04.19.59.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2023 19:59:45 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: b069d3e01931 - main - rtld: Revert "When loading dso without PT_GNU_STACK phdr, only call" From: Jessica Clarke In-Reply-To: <20230105035046.A01DE62E@slippy.cwsent.com> Date: Thu, 5 Jan 2023 03:59:44 +0000 Cc: John Baldwin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202301042255.304MtY3G002415@gitrepo.freebsd.org> <20230105035046.A01DE62E@slippy.cwsent.com> To: Cy Schubert X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4NnXmN0TVHz4CMg X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 5 Jan 2023, at 03:50, Cy Schubert wrote: >=20 > In message <202301042255.304MtY3G002415@gitrepo.freebsd.org>, John = Baldwin=20 > writ > es: >> The branch main has been updated by jhb: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Db069d3e0193121ff6de348f68c7ce93e= >> e61e5e2f >>=20 >> commit b069d3e0193121ff6de348f68c7ce93ee61e5e2f >> Author: John Baldwin >> AuthorDate: 2023-01-04 22:55:00 +0000 >> Commit: John Baldwin >> CommitDate: 2023-01-04 22:55:00 +0000 >>=20 >> rtld: Revert "When loading dso without PT_GNU_STACK phdr, only = call" >>=20 >> After the removal of ia64 and sparc64, all current architectures >> support executable stacks at an architectural level. >>=20 >> This reverts commit 1290d38ac50b3afa7e5781d9d97346a1042c736c. >=20 > I tried git log as follows in two independent repos, my "prod" repo = and the=20 > working repo I commit from: >=20 > slippy$ git log 1290d38ac50b3afa7e5781d9d97346a1042c736c > fatal: bad object 1290d38ac50b3afa7e5781d9d97346a1042c736c > slippy$=20 >=20 > Could there be some corruption somewhere? Do other people have the = same=20 > result as I do when they run git log against that hash? Or are my = repos=20 > corrupted? >=20 > When I run git log and search for the string "When loading dso without=20= > PT_GNU_STACK phdr, only call", I find the following, suggesting that = the=20 > svn2git process may have resulted in different hashes in different = repos=20 > used by different people. >=20 > commit cb38d4941c45e3c72c4b5b3fad87d297d950cf53 > Author: Konstantin Belousov > AuthorDate: Tue Jan 25 21:12:31 2011 +0000 > Commit: Konstantin Belousov > CommitDate: Tue Jan 25 21:12:31 2011 +0000 >=20 > When loading dso without PT_GNU_STACK phdr, only call > __pthread_map_stacks_exec() on architectures that allow executable > stacks. >=20 > Reported and tested by: marcel (ia64) >=20 > Notes: > svn path=3D/head/; revision=3D217851 >=20 > BTW, our GH read-only mirror has the same hash as above suggesting = that=20 > jhb's repo may not be in sync with others with regard to svn2git = generated=20 > commits? >=20 > Or, does this point to a deeper problem with inconsistent repos or = some=20 > other svn2git inconsistency somewhere? It=E2=80=99s the hash from the old GitHub mirror that's now = freebsd/freebsd-legacy. Jess