From nobody Mon Feb 27 23:51:24 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQchr6pFZz3tb3T for ; Mon, 27 Feb 2023 23:51:24 +0000 (UTC) (envelope-from pstef@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQchr5gdZz42k1; Mon, 27 Feb 2023 23:51:24 +0000 (UTC) (envelope-from pstef@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677541884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EVN9BzaP5i2WtaBUTq/J3HNO9hq4xG4M9Jw+yOHKIDA=; b=FL6PeObwhaTQUX3dL058ESXFuUkzhWgZ5Cwq3Kze5YwGI1Z9DUZ2r3b8eIo3tuRuvTd/6K Vgnnbq1Xn1OcHjilCUlRIXyWoSS4bNjykoSZeisl+Vm3oRyR6Pra/BIaMHF9qCynfEWaln Nsr6QUz+1BcoywaVGOCH1N+gUhoDOtdJpdcMYKFug2pybIgkyqtcBRssvO+cVFiMpcVbCw d+xJ6rnPl4ZkuRUXocLrHOKuiIwalP5t6Xo4vvTRLG91r51iEkSy8MahFKnawBO43mpWpF r5j+zMxYnZ0rNeYKizf+P+9SH9fzwgnNskfB8seGv8A94NCWJR/f/2HWVMiKdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677541884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EVN9BzaP5i2WtaBUTq/J3HNO9hq4xG4M9Jw+yOHKIDA=; b=p16yaxr6RttC7jco4Er/RgMf4OUNGCOZ2rZg/IV57xnSfiL75LtI3B5LDbUm4BrSe6qjHG +mxFjiFiBJMR7zJqdm7egwKEGW7YHubb6JLABurs22jWslk7GieL7iyuyGBQmRU00NPbwy eOsY8MJA9q/gx0ykp0vQhj0YA6rQ/62ZEAdhUgYM7H7/H11YmDRbHKbN8kZhGoUN8wzN7A gtRRZRLEJSbGFmC9k+TzZad0JRLbwZm6awWTtuZwz5a+7Sww0AqxGCzA9Wq56j4dbbm05q OxPzdUDFpfCnB5h/UZ+WGoZY3nASM4YaKQF3TDcv1FBosyFVDbJ1dDACpLAf2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677541884; a=rsa-sha256; cv=none; b=PKTPkssF1uE35hDgt23ZKDHw6LoNAOYZ4RPvpvZPTlpgNhKFInByyVd9V6ZxQw4xcpxcxp Vp2Bcm7z8IKYhwnriyfWkYSlRylExLLqL5vJqseRyKKSOqRMt3NmWnSPVafX6taU2qEDH1 h5dlmAkONg4YNC561MANKMimmWY0B9jEQRttXmES37Nq97vuz/kDv1Cdj6OEZ8uICRRAUO TnaZgIGe4ut8hu7p2/ZWcPxfnfXCTzsWEX3rIHmfAUKJuWFLoJyiovdNebLRMLSXZh3cL2 fmpniS23ep9DW2wXKc7D+tQQOzXpLtztffEmNzzzB4p1Z1T3ogOueQaN3eZdPQ== Received: by freefall.freebsd.org (Postfix, from userid 1403) id A9A8C57CC; Mon, 27 Feb 2023 23:51:24 +0000 (UTC) Date: Mon, 27 Feb 2023 23:51:24 +0000 From: "Piotr P. Stefaniak" To: Xin LI Cc: dev-commits-src-main@freebsd.org Subject: Re: git: 39e8c2a29a86 - main - cleanvar: Be more careful when cleaning up /var. Message-ID: References: <202302130457.31D4v8Hh067792@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <202302130457.31D4v8Hh067792@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On 2023-02-13 04:57:08, Xin LI wrote: > cleanvar: Be more careful when cleaning up /var. > > The cleanvar script uses find -delete to remove stale files under /var, > which could lead to unwanted removal of files in some unusual scenarios. > For example, when a mounted fdescfs(5) is present under /var/run/samba/fd, > find(1) could descend into a directory that is out of /var/run and remove > files that should not be removed. > > To mitigate this, modify the script to use find -x, which restricts the > find scope to one file system only instead of descending into mounted > file systems. >@@ -31,15 +31,15 @@ cleanvar_start() > { > if [ -d /var/run -a ! -f /var/run/clean_var ]; then > # Skip over logging sockets >- find /var/run \( -type f -or -type s ! -name log -and ! -name logpriv \) -delete >+ find -x /var/run \( -type f -or -type s ! -name log -and ! -name logpriv \) -delete > >/var/run/clean_var > fi Do we want to assume that /var/run is never a symlink? If not, we probably want to use find -xH here. Piotr