git: 942815c54820 - main - libefivar: Add note about extra compiler flags
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 15 Feb 2023 23:04:30 UTC
The branch main has been updated by imp:
URL: https://cgit.FreeBSD.org/src/commit/?id=942815c54820783d3d4f7f6faa71ab7919b5f0e5
commit 942815c54820783d3d4f7f6faa71ab7919b5f0e5
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2023-02-15 23:02:56 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-02-15 23:03:54 +0000
libefivar: Add note about extra compiler flags
Add a note about why we need these extra compiler flags to suppress
warnings. EDK2 upstream code is being used verbatim and as of the last
update these issuse persist, but are benign.
Sponsored by: Netflix
Reviewed by: asomers
Differential Revision: https://reviews.freebsd.org/D38613
---
lib/libefivar/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/libefivar/Makefile b/lib/libefivar/Makefile
index 5a6077d4b8f8..d38d7906af20 100644
--- a/lib/libefivar/Makefile
+++ b/lib/libefivar/Makefile
@@ -64,9 +64,10 @@ WARNS?= 9
.include <bsd.lib.mk>
+# We use UEFI parsing and formatting code from upstream EDK2 project.
+# They still have issues that require us to susppress some warnings.
CWARNFLAGS+= -Wno-cast-align
CWARNFLAGS+= -Wno-unused-parameter
-
.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 130000
CWARNFLAGS+= -Wno-unused-but-set-variable
.endif