From nobody Fri Feb 03 16:30:25 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7h3D6Vn5z3kVGh; Fri, 3 Feb 2023 16:30:32 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7h3D64ybz3rqP; Fri, 3 Feb 2023 16:30:32 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675441832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FzeKKow/KEa2nBfgmN1ijejISVgbri/ykMYDXMpfja0=; b=dLYxPcTVBTJg8kFzTeeCOltJp27fGmES+ednbPeVmbhtzb7AX1H2D/ph8rM1Q7+WOdqbm6 wNRCef+NIcj+dFWnnTHkYMn8gYU5MDwqMjprWxhvsgNST+gdE0zUmKqPj2EkfGpF6sULlU qimdGF2Fk/1CZGKLy77rqNEtLxPNsxiBBWkAOmBaAl+Y4iiNcc0sYBoNjL5g36IK6gR51I zVj7TuJpCkwPYyGUZfVmVAFWpTiiJrdEb7InHKsUgqNBZIcBr71ES8u68PTcT5G3tyTqIf jra4v6ltMK0/ylB7OsZH4ntYp3aMoiZsRPOCMrdsXHtN+aowVyXLV75iF6y86g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675441832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FzeKKow/KEa2nBfgmN1ijejISVgbri/ykMYDXMpfja0=; b=xOkluD7EiJmLlzWFKHO++MlT6EZJC7v0ly7SQecBoyqI40HISfp4AYeyJhtr2q6UB7JBy/ aHkC8jYfb/EY/N1o9bnjik16SLuAgjZxlBURcuuVE/dwHES+xszI7zXjbUAwKBURKBocIQ PxHtQyVAWJCDKKYxA1pEM3geTggcrylOcKFZexxBwhSjwRO2PnaA2ujiP8ii0MdTxelaCa Zy2YNdjUfmns0jFF4DGWkhZR+zcPBpgI+6dacmxYDoOA8pK2f5iiEK78aTQbEKFmWnozJN eeGoxSt9ijGqD3cNOge9eywMO1zdGL80zykxcCqtmqcd6emAwmkJdhbGa7SO2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675441832; a=rsa-sha256; cv=none; b=BT1Vj8vqrBjWIuoJNdHFjOVhNkAEp6hz/Wfi+y7Ul7eDunDY5ZDhLOks/D+JbritoouPpr J5PfGolu0Gq1NyowKcDqfOO8HOavRLO57AzXQ/anVyFG7XhVreo/Ud54OSgqlWWuQkNIFi 81Of2p1sT5twjTrkM6r2cs9qVmWDH2Yn3QRADeBsOUY9zTpS3IirtPsO+Eo4sag+VK9F2i UkYEAX3b24yLqgD7xmflDnLlcQtqL62pYBFwSDvM859wj/yHXXHPlxXTco5nf+BZHhb4k2 grqU9ddd+XU9OqKyDwP4n98iRJVzo2YD1lj1RZGAeJTSy4DP9pWMFu+gYZRLAQ== Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P7h3D4y7Bz11HB; Fri, 3 Feb 2023 16:30:32 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f177.google.com with SMTP id j22so2677137qka.0; Fri, 03 Feb 2023 08:30:32 -0800 (PST) X-Gm-Message-State: AO0yUKX93ds+NVMkSPHRYgg+QH021D3+8xoh3htT35QmYQ8W6Q3nRKf2 wSSFq7FRkMgAYxXCN4YDxvO7i+6SfOQeS22hEwY= X-Google-Smtp-Source: AK7set8ao31XvgWqyXJJ1s4FhzpUH4ico/6rpNSKrcWcYXG8Hprq/4Gb/kDDUWay81WFVpESTH7yRWfuYpDok+IKZug= X-Received: by 2002:a05:620a:530b:b0:702:2d7d:99c8 with SMTP id oo11-20020a05620a530b00b007022d7d99c8mr857725qkn.53.1675441832095; Fri, 03 Feb 2023 08:30:32 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202302031558.313Fw2sJ051540@gndrsh.dnsmgr.net> <86lele3f6c.fsf@ltc.des.no> <86edr63ert.fsf@ltc.des.no> In-Reply-To: <86edr63ert.fsf@ltc.des.no> From: Kyle Evans Date: Fri, 3 Feb 2023 10:30:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cb96a0ef0040 - main - cp: Minor code cleanup. To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: "Rodney W. Grimes" , rgrimes@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On Fri, Feb 3, 2023 at 10:16 AM Dag-Erling Sm=C3=B8rgrav = wrote: > > Kyle Evans writes: > > fts_read() doesn't always set errno to 0; notably, there's a number of > > FCHDIR() paths that don't set errno (and the change that added it > > mentions that scenario exactly) and will return NULL because of an > > error. > > The man page says it does, and as far as I can tell from the code it > does. Can you please provide a test case? > Ahh, I missed that FTS_NOCHDIR is set here.