From nobody Thu Feb 02 23:08:50 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7DxK4rq2z3kh7J for ; Thu, 2 Feb 2023 23:08:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7DxK2hVtz3Pxm for ; Thu, 2 Feb 2023 23:08:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f41.google.com with SMTP id n13so2633006wmr.4 for ; Thu, 02 Feb 2023 15:08:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SwQdUWzEkr4oDxna+vTNVuvrvr7tFfWbILzHzj6oFN4=; b=6HNpjJscYa7ve9YeQfWi7X9clu17/hcPyCQGoijLO3uLiPNGNGscFuCLK7wvUOmcHr EnGrYpcN5iiR4sIPVupTM52NO9HLSEKT1YzeerGxPbqdp0stES+r60bLc87oDy9R4dPa pMndcTtweVeGYdqY0KyDhK9XABCTNgV5PTEe9UCHLWXOOIrrl3rmdwmTd3ZN/F8Bn6y0 0Qxq/bB1cAP6yWwVSYb9plgmzLZkhnSyHZfEhFoxkiXd2Cl3ofTpzh/W30+A2IqGuMeY fL3P1Ucqi5LwSZrFaaNGnCgeLHkinCpGrH2bvrgmwjZMp1ccChr//2zZoAdCnlxrowo2 ZC7Q== X-Gm-Message-State: AO0yUKVALwZ2Zk2R686vM9HIZE4j4XSsDvUaC6OYJhIBeEkxfqKaQWC4 KRSay/oZZi38tvhbYfygltZh4Q== X-Google-Smtp-Source: AK7set8xqXX5SeOALRxpJx+CqNMjWz7Y4Tg4pVJNn3dOENLXeu/GXWGtpQMAuywsL9Wpw/ZEmsWjKg== X-Received: by 2002:a05:600c:5006:b0:3dd:caa8:3ae2 with SMTP id n6-20020a05600c500600b003ddcaa83ae2mr7932908wmr.6.1675379331479; Thu, 02 Feb 2023 15:08:51 -0800 (PST) Received: from smtpclient.apple (global-5-143.n-2.net.cam.ac.uk. [131.111.5.143]) by smtp.gmail.com with ESMTPSA id x33-20020a05600c18a100b003dd7edcc960sm869193wmp.45.2023.02.02.15.08.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Feb 2023 15:08:51 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: fb53e7adaf5b - main - tarfs: Fix 32-bit build. From: Jessica Clarke In-Reply-To: <7AB1A313-19CD-4A37-BB7D-22BD384BE327@FreeBSD.org> Date: Thu, 2 Feb 2023 23:08:50 +0000 Cc: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202302022039.312KdedK078659@gitrepo.freebsd.org> <7AB1A313-19CD-4A37-BB7D-22BD384BE327@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4P7DxK2hVtz3Pxm X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 2 Feb 2023, at 23:04, Dimitry Andric wrote: >=20 > On 2 Feb 2023, at 21:39, Dag-Erling Sm=C3=B8rgrav = wrote: >>=20 >> The branch main has been updated by des: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfb53e7adaf5b45ca08f650babc40077d= eff5e9af >>=20 >> commit fb53e7adaf5b45ca08f650babc40077deff5e9af >> Author: Dag-Erling Sm=C3=B8rgrav >> AuthorDate: 2023-02-02 20:36:01 +0000 >> Commit: Dag-Erling Sm=C3=B8rgrav >> CommitDate: 2023-02-02 20:39:10 +0000 >>=20 >> tarfs: Fix 32-bit build. >>=20 >> Sponsored by: Juniper Networks, Inc. >> Sponsored by: Klara, Inc. > ... >> --- a/sys/fs/tarfs/tarfs_subr.c >> +++ b/sys/fs/tarfs/tarfs_subr.c >> @@ -137,7 +137,7 @@ tarfs_print_node(struct tarfs_node *tnp) >> printf("\tvnode %p\n", tnp->vnode); >> printf("\ttmp %p\n", tnp->tmp); >> printf("\ttype %d\n", tnp->type); >> - printf("\tino %lu\n", tnp->ino); >> + printf("\tino %lu\n", (unsigned long)tnp->ino); >> printf("\tsize %zu\n", tnp->size); >> printf("\tname %s\n", >> (tnp->name =3D=3D NULL) ? "<>" : tnp->name); >> @@ -146,7 +146,7 @@ tarfs_print_node(struct tarfs_node *tnp) >> printf("\tgid %d\n", tnp->gid); >> printf("\tmode o%o\n", tnp->mode); >> printf("\tflags %u\n", tnp->flags); >> - printf("\tnlink %lu\n", tnp->nlink); >> + printf("\tnlink %lu\n", (unsigned long)tnp->nlink); >> printf("\tatime %d\n", (int)tnp->atime.tv_sec); >> printf("\tmtime %d\n", (int)tnp->mtime.tv_sec); >> printf("\tctime %d\n", (int)tnp->ctime.tv_sec); >=20 > This be just nitpicking, but the ino and nlink fields are typically > defined as int64_t and uint64_t, so these should be printed as such. >=20 > Since PRId64 and PRIu64 are apparently frowned upon, the usual = solution > is to cast everything to intmax_t or uintmax_t, and use %j for the > modifier. The casts of what I assume are time_t to int are also concerning. Jess