Re: git: 1e0853ee8403 - main - sys/kbio.h: support Unicode key codes in vt keymap files

On 1 Feb 2023, at 16:30, Stefan Eßer <se@FreeBSD.org> wrote:
> 
> The branch main has been updated by se:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=1e0853ee84031e4131a0b8cc8737696f199d3d4c
> 
> commit 1e0853ee84031e4131a0b8cc8737696f199d3d4c
> Author:     Stefan Eßer <se@FreeBSD.org>
> AuthorDate: 2023-02-01 16:24:18 +0000
> Commit:     Stefan Eßer <se@FreeBSD.org>
> CommitDate: 2023-02-01 16:24:18 +0000
> 
>    sys/kbio.h: support Unicode key codes in vt keymap files
> 
>    Some keyboard definitions return Unicode characters that cannot be
>    represented in the 8 bits provided by an u_char.
> 
>    Extend then width of the keycode entries to 16 bits to allow for all
>    keycodes currently defined in share/vt/keymaps/*,kbd.
> 
>    Reported by:       yuri@aetern.org
>    MFC after:         3 days
> ---
> sys/sys/kbio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/sys/kbio.h b/sys/sys/kbio.h
> index 7f17bda76c51..b0779f5ed114 100644
> --- a/sys/sys/kbio.h
> +++ b/sys/sys/kbio.h
> @@ -200,7 +200,7 @@ typedef struct okeymap okeymap_t;
> 
> struct acc_t {
> 	u_char		accchar;
> -	u_char		map[NUM_ACCENTCHARS][2];
> +	u_short		map[NUM_ACCENTCHARS][2];

This breaks ABI for [GP]IO_DEADKEYMAP.

Jess

> };
> 
> struct accentmap {