Re: git: b6b75424c57d - main - vmxnet3: Don't restart on VLAN changes

On Wed, Aug 30, 2023 at 12:53 PM Kristof Provost <kp@freebsd.org> wrote:
>
> On 24 Aug 2023, at 22:51, Kevin Bowling wrote:
>
> The branch main has been updated by kbowling:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=b6b75424c57d6da49967fef39f69080ce6939207
>
> commit b6b75424c57d6da49967fef39f69080ce6939207
> Author: Kevin Bowling <kbowling@FreeBSD.org>
> AuthorDate: 2023-08-24 20:25:21 +0000
> Commit: Kevin Bowling <kbowling@FreeBSD.org>
> CommitDate: 2023-08-24 20:46:56 +0000
>
> vmxnet3: Don't restart on VLAN changes
>
> In rS360398, a new iflib device method was added with default of opt out
> for VLAN events needing an interface reset.
>
> This re-init is unintentional for vmxnet3(4).
>
>
> It looks like we do need to re-init vmx interfaces when vlans are set. Marcos has an ESXi 7.0.3 setup that breaks with this patch series.
> This fixes it:

Ok, feel free to push.

>
> diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_vmx.c
> index 2c3530a217f..fdcad0dd4bb 100644
> --- a/sys/dev/vmware/vmxnet3/if_vmx.c
> +++ b/sys/dev/vmware/vmxnet3/if_vmx.c
> @@ -2513,6 +2513,7 @@ vmxnet3_if_needs_restart(if_ctx_t ctx __unused, enum iflib_restart_event event)
>  {
>         switch (event) {
>         case IFLIB_RESTART_VLAN_CONFIG:
> +               return (true);
>         default:
>                 return (false);
>         }
>
> Best regards,
> Kristof