git: 106c9ff5aca4 - main - stand: Export _start on arm like other architectures
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 05 Aug 2023 00:22:20 UTC
The branch main has been updated by jrtc27:
URL: https://cgit.FreeBSD.org/src/commit/?id=106c9ff5aca46b3bf9c82c1a56b432134a7cf36b
commit 106c9ff5aca46b3bf9c82c1a56b432134a7cf36b
Author: Jessica Clarke <jrtc27@FreeBSD.org>
AuthorDate: 2023-08-05 00:14:16 +0000
Commit: Jessica Clarke <jrtc27@FreeBSD.org>
CommitDate: 2023-08-05 00:14:16 +0000
stand: Export _start on arm like other architectures
By not exporting _start, we get various warnings of the form:
ld: warning: cannot find entry symbol _start
Note that in practice these don't matter because we manually construct
our PE header and use objcopy -O binary, so the entry point is set to
whatever we put explicitly in the PE header, but we should still do the
right thing and silence these warnings.
This was found in CheriBSD, where bsd.prog.mk has similar logic to
bsd.lib.mk and sets -Wl,--(no-)fatal-warnings based on LD_FATAL_WARNINGS
(unlike FreeBSD which only does so in the latter).
---
stand/efi/loader/arch/arm/start.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/stand/efi/loader/arch/arm/start.S b/stand/efi/loader/arch/arm/start.S
index 5b6182d67d0a..bd8f425ca9e0 100644
--- a/stand/efi/loader/arch/arm/start.S
+++ b/stand/efi/loader/arch/arm/start.S
@@ -140,6 +140,7 @@ section_table:
_end_header:
.text
+ .globl _start
_start:
/* Save the boot params to the stack */
push {r0, r1}