git: eee6537665ae - main - x86: remove intr_bind
- Reply: Ed Maste : "Re: git: eee6537665ae - main - x86: remove intr_bind"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 03 Aug 2023 21:02:43 UTC
The branch main has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=eee6537665ae9830e831d7473dedd6b2cc81c2ea
commit eee6537665ae9830e831d7473dedd6b2cc81c2ea
Author: Elliott Mitchell <ehem+freebsd@m5p.com>
AuthorDate: 2022-10-07 03:23:34 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-08-03 21:01:56 +0000
x86: remove intr_bind
`intr_bind(u_int vector, u_char cpu);` looked suspicious since
everywhere else "cpu" is a u_int and >256 processors isn't unreasonable
now. `intr_bind()` is not used anywhere in FreeBSD (now, after commit
bf42f3738087). Time to remove.
Relnotes: Yes
Reviewed by: mjg
Differential Revision: https://reviews.freebsd.org/D36901
---
sys/x86/include/intr_machdep.h | 3 ---
sys/x86/x86/intr_machdep.c | 12 ------------
2 files changed, 15 deletions(-)
diff --git a/sys/x86/include/intr_machdep.h b/sys/x86/include/intr_machdep.h
index 933552c7dd7e..69d626d9874b 100644
--- a/sys/x86/include/intr_machdep.h
+++ b/sys/x86/include/intr_machdep.h
@@ -143,9 +143,6 @@ void intr_add_cpu(u_int cpu);
int intr_add_handler(const char *name, int vector, driver_filter_t filter,
driver_intr_t handler, void *arg, enum intr_type flags, void **cookiep,
int domain);
-#ifdef SMP
-int intr_bind(u_int vector, u_char cpu);
-#endif
int intr_config_intr(int vector, enum intr_trigger trig,
enum intr_polarity pol);
int intr_describe(u_int vector, void *ih, const char *descr);
diff --git a/sys/x86/x86/intr_machdep.c b/sys/x86/x86/intr_machdep.c
index 6413d8aadd73..524258ef7dc8 100644
--- a/sys/x86/x86/intr_machdep.c
+++ b/sys/x86/x86/intr_machdep.c
@@ -630,18 +630,6 @@ intr_next_cpu(int domain)
return (apic_id);
}
-/* Attempt to bind the specified IRQ to the specified CPU. */
-int
-intr_bind(u_int vector, u_char cpu)
-{
- struct intsrc *isrc;
-
- isrc = intr_lookup_source(vector);
- if (isrc == NULL)
- return (EINVAL);
- return (intr_event_bind(isrc->is_event, cpu));
-}
-
/*
* Add a CPU to our mask of valid CPUs that can be destinations of
* interrupts.