From nobody Fri Sep 23 16:34:52 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MYyRf4jnGz4dMLt; Fri, 23 Sep 2022 16:34:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MYyRf4FWqz4QLS; Fri, 23 Sep 2022 16:34:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663950894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zxC+F7AuzM1TnaD2/qoN01l4OJk9YF2IyikUvM54hHc=; b=vSMFBFAffLRrSZmqyMBYTl9ft1gvzYCAnsztz8GO6c7exIzzMBqXlVwjIdZzP9ZnsLHIXT 2LuFEfXiXsIPYPqN4VGimippV62W8Z55D+t8ssOo3SuIpAz+ZUYNrIioOWhTkYdlMbctzN WFTyQ174zTN6IYUKgz9zovrWDBhmDoq7OdwFyWybkbWUwEIWYLjJ9Lhfee7frvwi3NbJKp D4xNwjqu79LzIhKn4j/v0+1Q8OwcV1SmP4BUto87waLt56PoR35VcdV/HazecOLHG/dOdI 9q/f5W1Imud4/z4PlDixHIeDLDYMkh0jczsIq8qKLW06x9xtvPepl43jqDCKqg== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MYyRd5P2Dz1RVb; Fri, 23 Sep 2022 16:34:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <94a64bcb-daad-200d-3379-dbc8569ed736@FreeBSD.org> Date: Fri, 23 Sep 2022 09:34:52 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: git: 7ae99f80b666 - main - pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t. Content-Language: en-US To: FreeBSD User Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202209222210.28MMAn61093861@gitrepo.freebsd.org> <20220923084042.788238ec@thor.intern.walstatt.dynvpn.de> From: John Baldwin In-Reply-To: <20220923084042.788238ec@thor.intern.walstatt.dynvpn.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663950894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zxC+F7AuzM1TnaD2/qoN01l4OJk9YF2IyikUvM54hHc=; b=beLX2oQKwvHAs0lxC0U3yuoRR9BqjifTa6AKCdIXye7RsLJ+OsWK1xFrqk6PW15URBA8zw FmEpbGe3ZeSVMpjcjUHxT7FyxAQVtOcS2RoTSDjk3d7+yjf4vYmXRngSlEFEjmBfBGhHJV yGJS0dVDXiP5m2Hkkcrb314toysQJz/td7TXIAhrw8ZYFhrRBYJ9w1Zqj4AimJaqhnxsL9 FyDNvOvT9ND6FOsQVcssyKUu4R4SU6AXQ6DWP9C8toRcFpUW+t7nkFkKbwYH9NwbLza178 hOj0l8Vmo3sSrVCfo9xGnyyPadiK54seIHVCK06wfDjtUYw1SFYH/3WFZWiWqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663950894; a=rsa-sha256; cv=none; b=tCt4rMfapg4fXyFPqmV5fS6pt4lpzgrgRcvk+n/FDySm+Rt8yrti/iM3tU39JCi2C9krvU SSOESxL60SHaO5iNa2UsROKHjiNW6CScH0VZzRh/huyLADboaSurnVTfwIwEB2Lz1HvVGq V3/uLrYM+hHmVE+V0IYPsVEph2S2ItPTaxwRXErgDiDx5eplnoDe+yja02R51jtWgclDvh 3XZIEbN2C71kx9v6CKgaA6ozoaOvF6YDg8s/SBfJj8HHcujiWKZmtpB7grgRNcdIULUHeX jF2cp1JRUystt+60utTlQY0rNpGXSFV22K2IA1yp4O2ugzJGUkKL2RJBHdYn9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 9/22/22 11:40 PM, FreeBSD User wrote: > Am Thu, 22 Sep 2022 22:10:49 GMT > John Baldwin schrieb: > >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=7ae99f80b6661760c5de3edd330b279f04b092a2 >> >> commit 7ae99f80b6661760c5de3edd330b279f04b092a2 >> Author: John Baldwin >> AuthorDate: 2022-09-22 22:08:52 +0000 >> Commit: John Baldwin >> CommitDate: 2022-09-22 22:08:52 +0000 >> >> pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t. >> >> This matches the return type of pmap_mapdev/bios. >> >> Reviewed by: kib, markj >> Sponsored by: DARPA >> Differential Revision: https://reviews.freebsd.org/D36548 >> --- >> [ Quote trimmed, please trim quotes in the future ] > This commit breaks compiling x11/nvidia-driver on CURRENT: > > [...] > --- nvidia_os.o --- > nvidia_os.c:283:19: error: incompatible integer to pointer conversion passing 'vm_offset_t' > (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion] > pmap_unmapdev((vm_offset_t)address, size); ^~~~~~~~~~~~~~~~~~~~ > ./machine/pmap.h:511:26: note: passing argument to parameter here > void pmap_unmapdev(void *, vm_size_t); > [...] > > I took the liberty to file a bug for the port x11/nvidia-driver here: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266561 I uploaded reviews for both nvidia-driver and isboot-kmod yesterday immediately after the commit. I couldn't do them beforehand as they needed the new __FreeBSD_version value. https://reviews.freebsd.org/D36670 https://reviews.freebsd.org/D36671 -- John Baldwin