From nobody Fri Sep 16 21:00:36 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MTmgf6CdTz4c1Ky for ; Fri, 16 Sep 2022 21:00:46 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic308-55.consmr.mail.gq1.yahoo.com (sonic308-55.consmr.mail.gq1.yahoo.com [98.137.68.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4MTmgd4W3Wz3Zn1 for ; Fri, 16 Sep 2022 21:00:45 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663362043; bh=htKj2XiZh0L1j/o1BkZujIlca98nSmulJMrE13hftWQ=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=FjKmJkysmcHk/IYSOa3OYGtbpjIlnmqhzAsgEbKfmYuHNW1fh9bc1NXHx2Qo7+FkTPEonpgbC9uTtZ7B1+xer9PolwrVB68FZzEgRAE5tqoIF0RxmOqttd6SmQnlRNkrnS6PVXRH/rgpQC0fehnEB3Dc7b4Lt1b9KwgqbCJEeRZHHuHjgzq9Y4+YqyDe9xP80zupSb2cg42x4yEQY7wRAe10qftF4r+2/nBYJqc7Q0CTwNCDUyoPm8KVpVoSV/wHYGwxkK09R2GCRvSWJu2H12NFWnkp806RyA+4MmSseDxZdgFlwkFTUwL8RvXNYzv1xyIbuB2qBsmkmcuicbgj5w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663362043; bh=yGKYmJS51qJ8BqiqIECvoJzXOyoV7UhpQdshC0kUoIC=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=JlSEFlxoTQGJ7LF5ec47mYs8dQgT4BvvG/CaOdjiOJBMtowsZP99U/QPLjZD0xqLfM86VW6vot/1ajyu318l/LqZ1ApWh1A0KA5V8m+hrHAs+bAmS9UiF4Uar6ykF6YozdFVprGvm+jd7R/NJr4z5rJdkg/wmc9IVjry9qQhKuzieviDd03Jwh3HJjRYCE664MeVUY2wOH73nxFV8uBP75TKfPflsJoJBGTPDk5/WFC+rEgjdPWq74pU377jDOSYnHp2cwfwBfWH95ekq3HGJ/HyYkEb6BhjNJAonHDYmuXETLQspGebjqy8SC+aWpTBKPUmbngBTBkQLvfk8B8uMw== X-YMail-OSG: wbxwtZMVM1leG0u99BDa49L9y9R2ylNtTw4mB1ua2SjCjxdXr27y8qXQKfINpgR PKSBZ0lOSyr.TjL.Fww.3pdK9w7zGiGEdj6OKk7NYHcMtRcFuiAZIqftJMaQen5bUk4dMmh5Jx6A yaJ7BL6pOhjRT5AQL1MyfZzqLCzfz9Ucsv3vB_nifx6dHpDuDc7lUHdtM3pOwa_VUamT87de_kce X55H.qM9_yZgPfz_id6PN85flIBykDzN4Cs4r.z1lGFGIs.w.EKRW4VxYV_e8BBqsJGSr1Vrm1F9 2FMjhMPOk0kwtFYBapQ3lprl92advGbCW3Ma0c7fSR2SeMpvWQRsHU0G9JmInNl7kCyqr7vqc8.c RPO0hpxqMyjEKs4FkZ16H3EeVjb1sJXSDcOPclBWWXnXZ.HGSokb.Dllfl7Jz3jL47l8OPN3oqdw oYe9uSanjUFKvRjalPGJzMgnb3ExfC5w1GHw4LhsfGytr0IIMMOliow41YISpa9AEQ.MF5WlC7p8 RouLw2K6zVCzhBjo2T4Hy_jjcWm598Vw.o5insE.8W0SQLaeLCxm2.JwD21b9f5LqTyh7pqVN0v_ a4lDA9oPxPj4YKNEWYGCQvwCJd8EDoO8Qe7RGDK0ojmvZc7bECU0C7x.eEcA28AP2GBBSNaxOKQX QQYGIXVp91w6MNbs.lx72JIniR5b8v69LIYFAwGcQVhFuizVCabSilWccXZgLHF5POBVqgIj4ioZ hNdhBolz5PKoqXn26XG1xYc.NDZb_pyWIqsoBSlp6pdsyij7Z1ThFhMkTVrmUEWDxqx90OGQ_6nY ot2FsaFU0duLkw0WnD6BuoPn.RZgonuyeLUnrQXm9ArVwuDWDUmWj6dIVwMFhCD_Ngd0KqU0CGjO 7zfqoqdo82ZZT1piwxQ12AXuCkROkQxm0MAVpp9XoR8NMf75ikaDyiZ9fcKHQsWsYgGtbyANuFPG qTn4fyW_d.pchhqGCzlMayFguSOAMOSuUoPufLiImcTdWG1iPLEfu0F0.qldr3nYID7Tog9mU.CP AOldkBxs8yATLEQDGD7rH5ZAkloSywbpisSs0sgDP40IU8sXv9e6VO4c6_tv3GZP51e2QdgCOutX IBiq7ylJkjY5gEBJ_dr37tV31YKoBhOmfv1zE4yX.I3nW7DXR7ZSD656hCFN7aZCzSUQCiFc_sIK i5hp0Jov2NIuQkNnBlxKMgVuvAhQkK8kQ1lQBtzXZviyT6ekQO2eXOV3TIWxb4PuBAfzvQe5lv4n vKurovB7.sMmritaKwsQ3926WVs5HF3Ov0K4mQUGGrIRShchUi5o1a3rLE9wotHj3W6WiPOGu30m QFTFAb4o7bZ9imFpjiRtTACXCZpAU6GKOEg56NaIW5glpVgHYZKVjmq_WGmIwib4PlS.3nmiiD_1 u6dGhnHDi2i9fEFzg4vZN_mE08aUAcJuPOc4HkJRD_BwgvqCxnksvmfv4ax_DIl1TNau2Mk_6ykm Y1HnZilBKva2Znsu1R4urcVpYKT4JURFe82iwIX4Xs9WvRdQezPKwKMEL.nNyUgZF3ipbx3amyXY WiGAN365B3JrGjbvhisYwku..uhgAy_tApOlqZV6W4oIF3_t3TsbbkfeTogvaQvteF5.5AlzITdf pcaDEuXHLrg.p_BlehyLB7ylSs2gGn0eiBxBaOWxkChJ78LhQ2dYsOfw7siXe5qVY2nRuM1dTsFW PJIu7ZW51LJEVvB_ofY3BaIrqhFiD1ru8hUllz0otreKdftbMuhAqDOgWAixegWrrr91hMetRTwY izJWqgQGF4SrsvzEsdtHrFiXRDWK2c_02S4hnaDJ_Ko53cY5rQvkl7RZ4hSLVZG4nj8o3jYIBXmB LgqvILiXl0C4dgi4Z.lNeAi6VDYHHaiPgitYmxZyU_L5Qm8xCTlsLqbdcYRkG21uMwExXn7bozZc 7UTGt5wMKe3vTuCi7OuspR4udnsZvj_j_xYwMGGNuq.H92KSB0j8H97HCafm1hcVoFTLMi74YmQO yuc.66THO9Dv3XQwWnARVpmTeOIdMxv7IV2hs61gQNbC4jJ_6NQymzE916z0zQbWF6NdJclGwrt2 Mx3_h0eYtxy0GoAijWukaRoxZTij0XK1DPagu51n_9ba8jY87qeVeqrG8X4Y95MvFER5mrG8Waqv 2tCr5PkpypEvi7c58oVg9qzUOSbP3BAVqJyS_.ARrVLbUt2umfrU3t4EAGztDuVaEY6hLcKiNmEY SgRQQ.RstoI1yNrRW13_6D_KCki6pPzGh0u6.9lYqeHGNwXCK6Qom7OHX4nxgJ6ujPDF0Y5JhM2r xCgGFy2aQqaLAVH_U9Hs692vV1phgX5AHaosM.OM.heb.ruUlBXVJtpsSW02aFu7ciDBp_vhEiso mcyxXmIYc X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Fri, 16 Sep 2022 21:00:43 +0000 Received: by hermes--production-ne1-544744cc75-sp4gl (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c3eec6c2102cf13359aec51d0d36612c; Fri, 16 Sep 2022 21:00:38 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: git: 87384c51e047 - main - jemalloc: use symbolic definitions for bits in vm_overcommit when !defined(SWAP_RESERVE_FORCE_ON): lacks a return statement Message-Id: Date: Fri, 16 Sep 2022 14:00:36 -0700 To: Konstantin Belousov , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3654.120.0.1.13) References: X-Rspamd-Queue-Id: 4MTmgd4W3Wz3Zn1 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=FjKmJkys; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.68.31 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-3.33 / 15.00]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.84)[-0.836]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RCVD_IN_DNSWL_NONE(0.00)[98.137.68.31:from]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; SUBJECT_HAS_EXCLAIM(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org] X-ThisMailContainsUnwantedMimeParts: N Konstantin Belousov wrote on Date: Fri, 16 Sep 2022 20:25:35 UTC : > The branch main has been updated by kib: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D87384c51e047349fdbcf4f07fe52d900= ce108040 >=20 > commit 87384c51e047349fdbcf4f07fe52d900ce108040 > Author: Konstantin Belousov > AuthorDate: 2022-09-15 09:59:42 +0000 > Commit: Konstantin Belousov > CommitDate: 2022-09-16 20:23:19 +0000 >=20 > jemalloc: use symbolic definitions for bits in vm_overcommit > =20 > Reviewed by: brooks, imp (previous version) > Discussed with: markj > Sponsored by: The FreeBSD Foundation > MFC after: 2 weeks > Differential revision: https://reviews.freebsd.org/D36540 > --- > contrib/jemalloc/src/pages.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/contrib/jemalloc/src/pages.c = b/contrib/jemalloc/src/pages.c > index 13de27a0087d..3600443e2cb5 100644 > --- a/contrib/jemalloc/src/pages.c > +++ b/contrib/jemalloc/src/pages.c > @@ -12,6 +12,7 @@ > #include > #ifdef __FreeBSD__ > #include > +#include > #endif > #endif > =20 > @@ -455,7 +456,10 @@ os_overcommits_sysctl(void) { > } > #endif > =20 > - return ((vm_overcommit & 0x3) =3D=3D 0); > +#ifdef SWAP_RESERVE_FORCE_ON > + return ((vm_overcommit & (SWAP_RESERVE_FORCE_ON | > + SWAP_RESERVE_RLIMIT_ON)) =3D=3D 0); > +#endif > } > #endif > =20 It looks like the above: +#ifdef SWAP_RESERVE_FORCE_ON + return ((vm_overcommit & (SWAP_RESERVE_FORCE_ON | + SWAP_RESERVE_RLIMIT_ON)) =3D=3D 0); +#endif means that there is a path through the routine that does not execute a return . . . ; statment when !defined(SWAP_RESERVE_FORCE_ON) . (Otherwise the #ifdef and #endif would not be necessary.) =3D=3D=3D Mark Millard marklmi at yahoo.com