From nobody Wed Sep 14 13:24:04 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MSLdg5GWcz4c6ln; Wed, 14 Sep 2022 13:24:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MSLdg4hFrz3smB; Wed, 14 Sep 2022 13:24:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663161847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xbn2+CsHMXtLevAZ5ntnjPzFZek9qMKD9f5qz4p/R90=; b=JJP1AXZE796dNQKjEbfF+2BYR/vpg7+LelFp2xfcy5JNF3bqHFW7x3KE+I559idr5aKvFf DG8aa7+xfhNqfTBQ59T02SejtD7fKtL0Or4KiK/H736LlCmrIRFEwjRRhN0fn4D3t3tpEG sNJ1V/mmvMy5Sbrtc9ENRh2FhsTufIeMwqwueWGzeSCGKiQdORDxOxfOFYxOaXb/GhRg6w 6YpTw3wkEuwqpzG00Fxx+0LeGwLjFsVWxxWSpQSHuLXKERLRas6q0/YlthHKMejCqty2jv RO27DOuHRiGtClPLXvt9aG86l/ib6Z6/r03jMqJNAWypfEqWXxYZ458hxqxBgA== Received: from [172.29.24.17] (unknown [213.164.1.106]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MSLdf4mPMzfg5; Wed, 14 Sep 2022 13:24:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <5906bef9-1afb-d1af-6002-6c1ed632582c@FreeBSD.org> Date: Wed, 14 Sep 2022 15:24:04 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: git: 10c6af344108 - main - bhyve: Fix build when BHYVE_SNAPSHOT is set Content-Language: en-US To: Ed Maste , Jessica Clarke Cc: Emmanuel Vadot , Mitchell Horne , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202209130632.28D6WdW9021176@gitrepo.freebsd.org> <9903ef54-80a9-67e6-f9ab-1371c42916ff@freebsd.org> <20220913163250.199f7ae9cf021249846a9133@bidouilliste.com> <526E3D8E-895C-476E-BB7C-F2EE61DA456E@freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663161847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xbn2+CsHMXtLevAZ5ntnjPzFZek9qMKD9f5qz4p/R90=; b=rGimYyB9md0cyLEISZslWeoetRLZtQznr4OXoV4RT9mIlxw08LcHOp5g1X3Sy36OZaGVyz K+nTX3FYaKGqJ3IGilPZYQMjtesovoYpFNTC+KiBM1OtIDklNq5C5PVnuX4TEU7cjQpUW8 PViEJm3AQkEWaqRW+XGyW8AN1xBlPZHIYXPgIqd0TgDWtaW623d2ZkLznpjX2u3o7TShee MKVHvBUsc1gunFg0XNLVY0Wynz7YiLnjWLKkg8sK+9cOUT5ORZaUwGSy104wlKrP7su/Nu 8/xZkXpTUKyghCbm8TkoipYjrdQcujMZCWaJjGKAb6B0W99flqVZmT+e6x2N9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663161847; a=rsa-sha256; cv=none; b=lA3NoC2Jodq8HEt4rvo1FrFho93LQdNFZLp7tYUTGc3VbbBgNZQbEreoN+/qln28lUU5pT foSuu3BQ/tvUdknAtF7N4un+w2ZOTUs+G9BgDELRDagT2koIBC9a8TjrzJthy1VIZtTl34 0sgYT1ylqB0XE7XLAikhsATW1HpZn+TjtgvO2Pi35fbv0XGyet+h4DKdNh6pEtEY6NJ22L dyuAy11zQx4QSrOwP1obhoUTHZeiLsfxzjCW7d+xJj8Y+wbvdpszTtnwdab6h7yWRG+xS1 MnOaaZN0xKJVxfBAddQSfje2fpp62xmMLHpHSyXb3Sl9IT90oIcwS4TAWdCQDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 9/13/22 4:21 PM, Ed Maste wrote: >>> Probably should as it would have prevent this, but I'm not sure of why >>> this is an option currently, John ? >> >> It disables capsicum support as the two aren’t currently compatible. > > There is a review open to add Capsicum support: > https://reviews.freebsd.org/D35454 > Once this is resolved we should indeed make it non-optional It's also optional because the format of the saved state isn't stable and is going to change in the future. I wanted to have a format that supported versioning (and of individual device blobs) before enabling it by default. However, it's also true that UPB has done some work towards that that has not yet been reviewed and merged. -- John Baldwin