From nobody Wed Sep 07 03:11:57 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MMnNY3LqRz4cKhW; Wed, 7 Sep 2022 03:11:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MMnNY2l2Cz3QHH; Wed, 7 Sep 2022 03:11:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662520317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KE5FbSQlQO4LCAAn1kJBMxZSp/w7zA/ubgomuTsjqhg=; b=bT2bouUiT7cf7/6ysCRnkvzAX2x0ONgK5ZBA/Bcrid56R49g6lGIpx+MI1vEWpxkMjlSGO iRksimx/XpGuUCbIhlB97yXvm+YKT6vHZetS8mWK2WYN7YNGZUDK8VcvIOCHWCoNluCJzu YfeR4/ZYqMbyDJGzNkssJAiXtFPzfTXagzn2ekIhqvYM4mx0dWpsLh/T1Ypga5BjP1H13a lNbbcEVDMlW4sogVpDRCxXvAVW/YXFM/NXYJELJOuwZLJAvk1sr7hw3etfk79aPVHacjgp FIj3tUUyg1GOZUrzrNlItMKmaUlVpLMlCsase1fShDdLwloR02by+M73EZSWWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MMnNY1X05zNkY; Wed, 7 Sep 2022 03:11:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2873BvCV017265; Wed, 7 Sep 2022 03:11:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2873BvmD017264; Wed, 7 Sep 2022 03:11:57 GMT (envelope-from git) Date: Wed, 7 Sep 2022 03:11:57 GMT Message-Id: <202209070311.2873BvmD017264@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: 1f7a710ab358 - main - ipfilter: Remove unused ioctl List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1f7a710ab35845049f17958c3783041c214d8a3c Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662520317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KE5FbSQlQO4LCAAn1kJBMxZSp/w7zA/ubgomuTsjqhg=; b=CR90QCOxDmjqhEyfSr6Q8/R2kq87g/tD8bjyL9unNaooAflsbCCKf5pau2iPg0wLvFDVJx NMVOcqB7T3Y2LCLr+I8+8ECcviAfuUHJ6SZBNOt1yGZtea8F28kbXnLB5FMrKor3qVmFwc /ohbDIYKlNPXscpVBYGmCc/IkhUEayXleGd0G3+uN7CNtAFRLu9MjUaOeZ6F0eS9JXMNeI /OVXi3Vcz1KJeeW9ZEN8Ds+wdBYRLJNaOqOAvemQSTtShPL10TfLzBvX6BwLSDK6466gVk JEegZAzRjSRFWHq1+DZvQsibdOUQNk4p06rAvvIIHoGTNkWp0fifXnB3VpNiTg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662520317; a=rsa-sha256; cv=none; b=OOYfmz4i3ehKw8hjLHrdEbMh22WpjaQ9AukEaWjjLzl0YsrqWLREgAhzx5hB6WEeXHfbYq RqaKlA/0G6KSXS8dumIlQZQo9sPBDL3r6zHMMgNx/6CmQ258EZGVWwQCTfsdVu2N0/fhZ2 Msv3H3+zyzdiYJsJ6yAa74mmIGc3RGF4pwiLsiV33OIFPq5S8Im48Kc3lvRtFzE+HjybyL w0AU+CRL0fR5TF2At/onAOT4+NBwmxLOkfK4k94/VIriQ7pnLHMPbK/JyOE1cyb94uSlUf r/44oQTPxq1XZmrz8jfKexok3NsdjmVD7BOI5vk9b8ofWx0JJWxIc6bEaTDdKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=1f7a710ab35845049f17958c3783041c214d8a3c commit 1f7a710ab35845049f17958c3783041c214d8a3c Author: Cy Schubert AuthorDate: 2022-09-06 20:58:35 +0000 Commit: Cy Schubert CommitDate: 2022-09-07 02:57:05 +0000 ipfilter: Remove unused ioctl The SIOCSTAT1 ioctl is only used in ip_auth and is unused in ip_state. The ip_state version was likely added to support a new statistic yet to be developed in ipfstat(8) or for some sample userspace application (similar in fashion to the sample provided for authentication rules). There is no need to report individual state hash table bucket lengths to any future userspace application. If needed for any future debugging purposes a DTrace probe would be a better vehicle. This unused ioctl in ip_stat results in a panic. PR: 266124 Reported by: Robert Morris MFC after: 3 days --- sys/netpfil/ipfilter/netinet/ip_state.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sys/netpfil/ipfilter/netinet/ip_state.c b/sys/netpfil/ipfilter/netinet/ip_state.c index cc0e8559fb16..463416f454a9 100644 --- a/sys/netpfil/ipfilter/netinet/ip_state.c +++ b/sys/netpfil/ipfilter/netinet/ip_state.c @@ -751,18 +751,6 @@ ipf_state_ioctl(ipf_main_softc_t *softc, caddr_t data, ioctlcmd_t cmd, error = ipf_state_getent(softc, softs, data); break; - /* - * Return a copy of the hash table bucket lengths - */ - case SIOCSTAT1 : - error = BCOPYOUT(softs->ipf_state_stats.iss_bucketlen, data, - softs->ipf_state_size * sizeof(u_int)); - if (error != 0) { - IPFERROR(100017); - error = EFAULT; - } - break; - case SIOCGENITER : { ipftoken_t *token;