From nobody Thu Oct 27 18:10:09 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mytxz2jh8z4ggSY; Thu, 27 Oct 2022 18:10:15 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mytxz2CP8z44Pt; Thu, 27 Oct 2022 18:10:15 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666894215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQFMPyX0kOtJjmRi0RnsOBteYJHZJ253Hj21kjSJPr4=; b=W1Cf2wgzdN3oRqk7tzd8YXLapY5jcWp4xZszwhZm5MQ5AuYtQBGMVBeh9MXqdP5TUS7Qp7 vi2flnmSpYj5NP5RKcU0dvHHgcT7Nw5whqH6AAFtGL4a4uYBprCLZYREpe2GMB2q6TWkeF ntWN03kt0xzLH01DnwaEHRrVQBq9zkPUiKEFw83/uTAbpnndnKdPb+WEkzbd/o7rYfeOys SR/Xcl6jNommoV1eM66H5n4FLvpCJ91+Ia57ZIqSaYeA0lXxwYZGtvdUhDQcmtR4m2wEs4 ZzyQPj/OLxiw1Vmivous+swlUBl9c+x1ixZsmKrMGDyz7xtEjI9UfuBjmnAwbg== Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Mytxy4fnhzvZB; Thu, 27 Oct 2022 18:10:14 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.66.22101101 Date: Thu, 27 Oct 2022 11:10:09 -0700 Subject: Re: 64c3edc237a5 - main - Allow the extres regulator code to build without FDT From: Ravi Pokala To: Andrew Turner , , , Message-ID: <91C0DBC3-BB23-41DD-AB8B-0E5FE1155FC8@panasas.com> Thread-Topic: 64c3edc237a5 - main - Allow the extres regulator code to build without FDT References: <202210271631.29RGVlLK002103@gitrepo.freebsd.org> In-Reply-To: <202210271631.29RGVlLK002103@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666894215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQFMPyX0kOtJjmRi0RnsOBteYJHZJ253Hj21kjSJPr4=; b=L60JQL/tpruSpu+HpoQql6jSTS8G9eQ2f044c2fz43cswGF7uiqRY6mJv8+gBzlWojD6lS cgEdPkUNdIsuAxomZABJS6plF0BpA5WdscxTJzM9Cb7zd2DWVGcxU5y2dmaUamYh9oE6B2 6w/WRVvedtEnSLyuesVRN3waH3/tOCgjsfdPB4aw9owaog28KK3kYRUOI8ym86P3wBSmj8 20a5IPC3tc9QD2QsKgaYQPqeu9JhhPt2gDjdPK2CFQS3WLwqKPxCq1pzSBR8/Ap/ENL6Cq EQsk8fv/WOQGODUksE+K65quTmLlK1YRU2GpyiVS7cNwwCfudC+EZziQI7+hYg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666894215; a=rsa-sha256; cv=none; b=sRZbKgRoQnKKZUSzwIWx5EScggUjDOkhfMfnxPt8O0RY/Np/Vl3nD1x5N12C1pA5+iRvXa oanuX65vO0iSdlDGG2TaO9ZvgQC07DR6NkrodCtOqHh92jB1vvb+KS4SrSImAcqqvRwh+R MhL9IWOpCWZonZKCu5kQTf6e+wDLxY6d96cAhC/JHu1INutLV+sag1HT6OSuWsnm0WQwP2 hcXLm/hntCFpWckCsDKIXFho+ipA5rGskhZSzT7a/Hdep09yAqygJ/FMEKOII/6MUjx0x6 e2VNZiujBHPqlvfTbqS3CmhHtN0dy3SA29dKO19pwmjlw49ro4uEd7nsw1tAMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N =EF=BB=BF-----Original Message----- From: on behalf of Andrew Turner Date: 2022-10-27, Thursday at 09:31 To: , , Subject: git: 64c3edc237a5 - main - Allow the extres regulator code to buil= d without FDT The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=3D64c3edc237a5281e2210b3dd27= 868175f87b3973 commit 64c3edc237a5281e2210b3dd27868175f87b3973 Author: Andrew Turner AuthorDate: 2022-10-27 16:28:56 +0000 Commit: Andrew Turner CommitDate: 2022-10-27 16:28:56 +0000 Allow the extres regulator code to build without FDT This allows drivers that use this to build in an ACPI only kernel. Might want to add a comment that these two specific files are built w/o FDT= because they're needed by ACPI. Otherwise, the lack of "fdt" seems like a m= istake in long list of "fdt" files, and someone might "fix" them by adding "= fdt" back. -Ravi (rpokala@) Sponsored by: The FreeBSD Foundation --- sys/conf/files | 4 ++-- sys/dev/extres/regulator/regulator.c | 2 ++ sys/dev/extres/regulator/regulator.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sys/conf/files b/sys/conf/files index 5a74f1b1f1bb..b77fd3139544 100644 --- a/sys/conf/files +++ b/sys/conf/files @@ -1741,8 +1741,8 @@ dev/extres/hwreset/hwreset_if.m optional hwreset = fdt dev/extres/nvmem/nvmem.c optional nvmem fdt dev/extres/nvmem/nvmem_if.m optional nvmem fdt dev/extres/regulator/regdev_if.m optional regulator fdt -dev/extres/regulator/regnode_if.m optional regulator fdt -dev/extres/regulator/regulator.c optional regulator fdt +dev/extres/regulator/regnode_if.m optional regulator +dev/extres/regulator/regulator.c optional regulator dev/extres/regulator/regulator_bus.c optional regulator fdt dev/extres/regulator/regulator_fixed.c optional regulator fdt dev/extres/syscon/syscon.c optional syscon diff --git a/sys/dev/extres/regulator/regulator.c b/sys/dev/extres/regu= lator/regulator.c index eab79e9dfbc3..f87dec3fafb5 100644 --- a/sys/dev/extres/regulator/regulator.c +++ b/sys/dev/extres/regulator/regulator.c @@ -49,7 +49,9 @@ __FBSDID("$FreeBSD$"); #endif #include +#ifdef FDT #include "regdev_if.h" +#endif SYSCTL_NODE(_hw, OID_AUTO, regulator, CTLFLAG_RD | CTLFLAG_MPSAFE, NUL= L, "Regulators"); diff --git a/sys/dev/extres/regulator/regulator.h b/sys/dev/extres/regu= lator/regulator.h index 03a8fbe1f534..587d788d3608 100644 --- a/sys/dev/extres/regulator/regulator.h +++ b/sys/dev/extres/regulator/regulator.h @@ -34,8 +34,8 @@ #include #ifdef FDT #include -#include "regnode_if.h" #endif +#include "regnode_if.h" SYSCTL_DECL(_hw_regulator);