From nobody Mon Oct 24 14:04:10 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MwxdW1GwBz4fVG6; Mon, 24 Oct 2022 14:04:15 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MwxdT6snhz3G9B; Mon, 24 Oct 2022 14:04:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id mrsFop8CuSp39my3ooSLMW; Mon, 24 Oct 2022 14:04:12 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id my3noNznXkTFZmy3no0KsL; Mon, 24 Oct 2022 14:04:12 +0000 X-Authority-Analysis: v=2.4 cv=D8dUl9dj c=1 sm=1 tr=0 ts=63569b5c a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=Qawa6l4ZSaYA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=UPHkXpFCvb6cXc6f4nwA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 8C79B1739; Mon, 24 Oct 2022 07:04:10 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 428CF353; Mon, 24 Oct 2022 07:04:10 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Takanori Watanabe cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a9880bfe1181 - main - acpi_ged: New driver to ACPI generic event device In-reply-to: <202210241002.29OA26Pk076760@gitrepo.freebsd.org> References: <202210241002.29OA26Pk076760@gitrepo.freebsd.org> Comments: In-reply-to Takanori Watanabe message dated "Mon, 24 Oct 2022 10:02:06 +0000." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 24 Oct 2022 07:04:10 -0700 Message-Id: <20221024140410.428CF353@slippy.cwsent.com> X-CMAE-Envelope: MS4xfOxdWZfYk81pBZa+xiYJtJktso2GjYUmq6bofsPV7HIlUAjxNLYWuOEbPWaaqi01mBf2pr5xqRnCtdp0trK3n0UiNwJc/F3ufO2fRoZR3ddxqxs5stGo D1xg/70RHViJnpoyjz7ya+HbLT2Rix4axj5CAX1LB9aSKsHOC85RpFcDl+mTJKDrwYBB7HFISBWQxoiV5P+6WpsXfs4w9vZNjQx8MiY/XnurAsfIT7Y4B2+k YuOzjev+bZsAArcsKrVrmaA94Vi7lwy/OsxWBI7fWxr8Sij0X248uf8W//NUANzRSFsyS3qlT+RKN8Ghwrse0YEDMlhap9OHFqeDmjnSznc= X-Rspamd-Queue-Id: 4MwxdT6snhz3G9B X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.33) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.58 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.977]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org,dev-commits-src-all@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.97.99.33:from]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N In message <202210241002.29OA26Pk076760@gitrepo.freebsd.org>, Takanori Watanabe writes: > The branch main has been updated by takawata: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a9880bfe1181b7a32d026339bae113f2 > 4300e5e1 > > commit a9880bfe1181b7a32d026339bae113f24300e5e1 > Author: Takanori Watanabe > AuthorDate: 2022-10-18 05:41:53 +0000 > Commit: Takanori Watanabe > CommitDate: 2022-10-24 09:57:36 +0000 > > acpi_ged: New driver to ACPI generic event device > > New driver to ACPI generic event device, defined in ACPI spec. > Some ACPI power button may not work without this. > > In qemu arm64 with "virt" machine, with ACPI firmware, > enable devd check devd message by > and invoke following command in qemu monitor > (qemu) system_powerdown > and make sure some power button input event appear. > (setting sysctl hw.acpi.power_button_state=S5 is not work, > because ACPI tree does not have \_S5 object.) > > Reviewed by: andrew, hrs > Differential Revision: https://reviews.freebsd.org/D37032 > --- > share/man/man4/acpi_ged.4 | 64 +++++++++ > sys/arm64/conf/std.virt | 1 + > sys/conf/files | 1 + > sys/dev/acpica/acpi_ged.c | 267 +++++++++++++++++++++++++++++++++++ > ++ > sys/modules/acpi/Makefile | 2 +- > sys/modules/acpi/acpi_ged/Makefile | 11 ++ > 6 files changed, 345 insertions(+), 1 deletion(-) Hi, This fails to build. src/sys/dev/acpica/acpi_ged.c:201:31: error: no member named 'evt' in 'struct acpi_ged_softc'; did you mean 'evts'? rawirq = rman_get_start(sc->evt[i].r); ^~~ evts -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0