From nobody Thu Oct 20 16:23:43 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MtXwc2tr8z4fypS; Thu, 20 Oct 2022 16:24:00 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MtXwb4nZcz49b1; Thu, 20 Oct 2022 16:23:59 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f176.google.com with SMTP id i17so26153111lja.3; Thu, 20 Oct 2022 09:23:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E/AzfjVagBUVr3iyg7sSo1y1em4PxUSMm4r4LIbxapI=; b=LdS9ccvOu/Ds45XZcJ27g6beDx3XMAZJR0nqdgGsPjNHkxeaAGtbdVUE7e2ztr7qR+ /xuJ2kythX+MXOqrTiN0RV/G0W6zg7TfReQtotSmTwdrEOV+OBMldHbYWB2NUYij3ZOP CFcUaZDOi5skbTPwWb0Ewuhu0NO5WwjmcD5DFyrr6canb01NiVonY9mMQZFSzfUJ51wU yEbe3w2tH3bbW2b52zGQdv+Br5cJyJPthKdRY27SG+91icgH+wOSRgXiClNI8NCEQ5q3 FV9H77h7K3IAuAlTAFVl4lL596OMbwO44FSfcFP8vVwHeUGHpo7K/zSZJJTU25e02bh7 +g9g== X-Gm-Message-State: ACrzQf2MuQ9pnkun90txIMUGM3ZjI1/GJddLru8SF2J5gFUxyBRPEHg+ DFRyJIZGEV7zHdAJUSag9JqCGdKmG/ZCjeYbPUJxyavLJDg= X-Google-Smtp-Source: AMsMyM76I3DzotvzhEIMMUF9EkiLn7UtxTkRRvqf91BdnZT4LbzopRxvRdK7Rm8zAZ3AhqqNST/jtP+m8POF5xn5kKY= X-Received: by 2002:a2e:8719:0:b0:26f:abac:4aac with SMTP id m25-20020a2e8719000000b0026fabac4aacmr4939315lji.62.1666283036484; Thu, 20 Oct 2022 09:23:56 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202210171652.29HGqtSf007611@gitrepo.freebsd.org> In-Reply-To: <202210171652.29HGqtSf007611@gitrepo.freebsd.org> From: Alan Somers Date: Thu, 20 Oct 2022 10:23:43 -0600 Message-ID: Subject: Re: git: 11778fca4a83 - main - Fix mpr(4) panic during a firmware update. To: "Kenneth D. Merry" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4MtXwb4nZcz49b1 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.176:from]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.176:from]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[asomers]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On Mon, Oct 17, 2022 at 10:53 AM Kenneth D. Merry wrote: > > The branch main has been updated by ken: > > URL: https://cgit.FreeBSD.org/src/commit/?id=11778fca4a83f5e3b597c75785aa5c0ee0dc518e > > commit 11778fca4a83f5e3b597c75785aa5c0ee0dc518e > Author: Kenneth D. Merry > AuthorDate: 2022-10-17 16:48:34 +0000 > Commit: Kenneth D. Merry > CommitDate: 2022-10-17 16:48:34 +0000 > > Fix mpr(4) panic during a firmware update. > > Issue Description: > The RequestCredits field of IOCFacts got changed between the Phase23 > firmware to Phase24 firmware. So as part of firmware update operation, > driver has to free the resources & pools which are created with the Phase23 > Firmware's IOCFacts data (i.e. during driver load time) and has to > reallocate the resources and pools using Phase24's IOCFacts data. Here > driver has freed the interrupts but missed to reallocate the interrupts and > hence config page read operation is getting timed out and controller is > going for recursive reinit (controller reset) operations and leading to > kernel panic. > > Fix: > Reallocate the interrupts if the interrupts are disabled as part of > firmware update/downgrade operation. > > Submitted by: Sreekanth Ready > Tested by: ken > MFC after: 3 days Would this commit fix the panic in bug 252575? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252575