From nobody Tue Oct 18 17:43:00 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MsLmj6shMz4gJH5 for ; Tue, 18 Oct 2022 17:43:01 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from mail.tarsnap.com (mail.tarsnap.com [54.86.246.204]) by mx1.freebsd.org (Postfix) with SMTP id 4MsLmj6KKWz3dbt for ; Tue, 18 Oct 2022 17:43:01 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: (qmail 92112 invoked from network); 18 Oct 2022 17:43:01 -0000 Received: from unknown (HELO dell7390.daemonology.net) (127.0.0.1) by mail.tarsnap.com with SMTP; 18 Oct 2022 17:43:01 -0000 Received: (qmail 83718 invoked from network); 18 Oct 2022 17:43:00 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 18 Oct 2022 17:43:00 -0000 Message-ID: <565bfff4-6c0b-5026-1f89-f89474620a73@freebsd.org> Date: Tue, 18 Oct 2022 10:43:00 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: git: 0e1f5ab7db2c - main - virtio_mmio: Support command-line parameters Content-Language: en-US To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202210180603.29I635Zd097281@gitrepo.freebsd.org> <38DAF585-07F8-4DCD-85D5-E8CFC2099AA5@freebsd.org> From: Colin Percival In-Reply-To: <38DAF585-07F8-4DCD-85D5-E8CFC2099AA5@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MsLmj6KKWz3dbt X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Hi Jessica, On 10/18/22 08:12, Jessica Clarke wrote: > On 18 Oct 2022, at 07:03, Colin Percival wrote: >> --- a/sys/conf/files >> +++ b/sys/conf/files >> @@ -3437,6 +3437,7 @@ dev/virtio/pci/virtio_pci_legacy.c optional virtio_pci >> dev/virtio/pci/virtio_pci_modern.c optional virtio_pci >> dev/virtio/mmio/virtio_mmio.c optional virtio_mmio >> dev/virtio/mmio/virtio_mmio_acpi.c optional virtio_mmio acpi >> +dev/virtio/mmio/virtio_mmio_cmdline.c optional virtio_mmio > > As I said in the review, this definitely doesn’t work for INTRNG due to > IRQ number virtualisation, among other things, yet this enables it for > all architectures, and I believe it should also get its own config > option as it’s rather dangerous to use (Linux separates it out from > virtio_mmio and has it off-by-default). Sorry, I didn't get around to following up with you about this. Would moving this into files.x86 satisfy your concerns? That way it shouldn't run into issues with other platforms (and would also be turned off by default, since virtio_mmio isn't in x86 GENERIC kernels). -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid