git: c4a4011c744a - main - PVH: support whitespace cmdline splitting
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 18 Oct 2022 06:03:16 UTC
The branch main has been updated by cperciva:
URL: https://cgit.FreeBSD.org/src/commit/?id=c4a4011c744a8e75892d126702a825e617d9e064
commit c4a4011c744a8e75892d126702a825e617d9e064
Author: Colin Percival <cperciva@FreeBSD.org>
AuthorDate: 2022-08-13 00:56:30 +0000
Commit: Colin Percival <cperciva@FreeBSD.org>
CommitDate: 2022-10-18 06:02:22 +0000
PVH: support whitespace cmdline splitting
For historical reasons, Xen kernel command lines have options
separated by commas. Every other FreeBSD platform uses whitespace;
this is also necessary in PVH in order to support the Firecracker
VMM. Allow options to be separated by any combination of commas
and whitespace.
Reviewed by: imp
Sponsored by: https://www.patreon.com/cperciva
Differential Revision: https://reviews.freebsd.org/D36190
---
sys/x86/xen/pv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/x86/xen/pv.c b/sys/x86/xen/pv.c
index b81423a1be88..162504f5120c 100644
--- a/sys/x86/xen/pv.c
+++ b/sys/x86/xen/pv.c
@@ -419,7 +419,7 @@ xen_pvh_parse_preload_data(uint64_t modulep)
if (start_info->cmdline_paddr != 0)
boot_parse_cmdline_delim(
(char *)(start_info->cmdline_paddr + KERNBASE),
- ",");
+ ", \t\n");
kmdp = NULL;
strlcpy(bootmethod, "XEN", sizeof(bootmethod));
}