From nobody Thu Oct 13 15:33:33 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MpD7d4wfqz4dyxN; Thu, 13 Oct 2022 15:33:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MpD7d4NN4z3RKJ; Thu, 13 Oct 2022 15:33:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665675213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kxc6wYc4lT5yqkZ0KkUt8IGSIh7Xrcs/Ky5h5pD9RJY=; b=Ons/IrVqq0Jqc1oHJIi5Q3P+DBrKSYwlpUbwMxqWyov+lvukMFj8DNkcib54JS+0WWgRgM tp9jVVkvYRDESFYbPwpci+EBYXttnCSLaPHSQJdzk9jmkyLVI9xnXu+9JxElbmS55dXduf vlDGDmbVjF8F7Fp/JTPV6PjcB++9GL9perpYVZFTCMJbGLaObeYKHV9aL5Q+oA7BjYQXsF JeE9GdeJApAdFPzFIFVoSO7GBZkuOSuhQEUq7CFWfSib4YgEUSOIx1jKotNAwJwBsMfirs B7k5GUoKcFd4NGgwzNqF9/iSPyd+//OciWTYHDZfvaaQiLZfafeiuNdjHbfrlw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MpD7d3Nz7zSQC; Thu, 13 Oct 2022 15:33:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 29DFXXRS009375; Thu, 13 Oct 2022 15:33:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 29DFXXkm009374; Thu, 13 Oct 2022 15:33:33 GMT (envelope-from git) Date: Thu, 13 Oct 2022 15:33:33 GMT Message-Id: <202210131533.29DFXXkm009374@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Cochard Subject: git: 07b1ea961af7 - main - renice: Force /bin/sh usage on su calls for the regression tests. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olivier X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 07b1ea961af77d728dfef4d0a11f98a8ab2fe226 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665675213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kxc6wYc4lT5yqkZ0KkUt8IGSIh7Xrcs/Ky5h5pD9RJY=; b=cEMaEiei/oouVrsz/jHysrH303M3EyZkn9X3z8FfaeOJd327d1DXrf4U0R1fWsQoAu3pAQ Sx6uCLg3Y8iqfJod2iPUvICKqtTvUCBA1tMHw61kOjPlcQDalEFySffQM4RlfSxOhfO/by 0GnrX14b0dFI5leMLLuKxGf1YdrKY3xS39kRNW9UHhE4TbqSMO7/Bj3i92Eneoixv6hzsX nE3D4qpG5sqFgNDmQ4BqyzX2enrXe1AXYRCZGXY/W3ZLOtzPJZWCybuEd9XUpr/qyOnTpe J2D5919zEhaYFr6jyWcp/Z62XSlYvQsd92I9bkhYtuLYQUO7jnAgz2o91scLUw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665675213; a=rsa-sha256; cv=none; b=k0PZsj9HaaykGA29AHvyq9WwG8wq3UnOXaS9hbCGWEFVHJ4Cj25CNBKSEgJdl3iNJi2RWa BIMA634yUylGp1mcXmZrXPZ2w/X8fooFfZJdslL9Zlu0jBcEdpXGlDreo4ZabgGTXjwFuD 416qVuWed4hwmStNifyrtsD3Dr83EQk1dymvTQHs6TZytQy1M7sw87JI/w5f+JrRb6NaKK ElNEICpA1OKofEJtUvIarY0wyz52fownld9aK4vVyNSxyFvSU7wTx299GBxLLcxK6ONkwv c6VS8IbWx1iiFGVLdVAX+8xjy+tGf4eCCAZdagBsyCVGXcEQkS19q6t9/FXokQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by olivier (ports committer): URL: https://cgit.FreeBSD.org/src/commit/?id=07b1ea961af77d728dfef4d0a11f98a8ab2fe226 commit 07b1ea961af77d728dfef4d0a11f98a8ab2fe226 Author: Olivier Cochard AuthorDate: 2022-10-13 15:23:54 +0000 Commit: Olivier Cochard CommitDate: 2022-10-13 15:32:47 +0000 renice: Force /bin/sh usage on su calls for the regression tests. If the root account is configured to use a different shell than sh, it fails to retreive the pid of the background process. Approved by: des Obtained from: chs Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D36930 --- usr.bin/renice/tests/renice_test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.bin/renice/tests/renice_test.sh b/usr.bin/renice/tests/renice_test.sh index 323fe44591c8..9321e0f327ae 100644 --- a/usr.bin/renice/tests/renice_test.sh +++ b/usr.bin/renice/tests/renice_test.sh @@ -97,7 +97,7 @@ renice_abs_user_head() { } renice_abs_user_body() { local user pid nice incr - pid=$(su -m $TEST_USER -c "sleep 60 >/dev/null & echo \$!") + pid=$(su -m $TEST_USER -c "/bin/sh -c 'sleep 60 >/dev/null & echo \$!'") nice="$(ps -o nice= -p $pid)" incr=3 _renice $((nice+incr)) -u $TEST_USER @@ -112,7 +112,7 @@ renice_rel_user_head() { } renice_rel_user_body() { local user pid nice incr - pid=$(su -m $TEST_USER -c "sleep 60 >/dev/null & echo \$!") + pid=$(su -m $TEST_USER -c "/bin/sh -c 'sleep 60 >/dev/null & echo \$!'") nice="$(ps -o nice= -p $pid)" incr=3 _renice -u -n $incr $TEST_USER