git: 273d0715f6b1 - main - amd64: remove useless addr2 variables in page range invalidation handlers
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 10 Oct 2022 21:34:01 UTC
The branch main has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=273d0715f6b168ab7be6e79a768d97fbdea81c8d
commit 273d0715f6b168ab7be6e79a768d97fbdea81c8d
Author: Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2022-10-08 08:33:11 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2022-10-10 21:33:12 +0000
amd64: remove useless addr2 variables in page range invalidation handlers
Reviewed by: alc, markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D36919
---
sys/amd64/amd64/mp_machdep.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/sys/amd64/amd64/mp_machdep.c b/sys/amd64/amd64/mp_machdep.c
index 3356726b24de..2ed3a57866a2 100644
--- a/sys/amd64/amd64/mp_machdep.c
+++ b/sys/amd64/amd64/mp_machdep.c
@@ -903,7 +903,7 @@ invlpg_pcid_handler(pmap_t smp_tlb_pmap, vm_offset_t smp_tlb_addr1)
static void
invlrng_handler(vm_offset_t smp_tlb_addr1, vm_offset_t smp_tlb_addr2)
{
- vm_offset_t addr, addr2;
+ vm_offset_t addr;
#ifdef COUNT_XINVLTLB_HITS
xhits_rng[PCPU_GET(cpuid)]++;
@@ -913,11 +913,10 @@ invlrng_handler(vm_offset_t smp_tlb_addr1, vm_offset_t smp_tlb_addr2)
#endif /* COUNT_IPIS */
addr = smp_tlb_addr1;
- addr2 = smp_tlb_addr2;
do {
invlpg(addr);
addr += PAGE_SIZE;
- } while (addr < addr2);
+ } while (addr < smp_tlb_addr2);
}
static void
@@ -925,7 +924,7 @@ invlrng_invpcid_handler(pmap_t smp_tlb_pmap, vm_offset_t smp_tlb_addr1,
vm_offset_t smp_tlb_addr2)
{
struct invpcid_descr d;
- vm_offset_t addr, addr2;
+ vm_offset_t addr;
#ifdef COUNT_XINVLTLB_HITS
xhits_rng[PCPU_GET(cpuid)]++;
@@ -935,11 +934,10 @@ invlrng_invpcid_handler(pmap_t smp_tlb_pmap, vm_offset_t smp_tlb_addr1,
#endif /* COUNT_IPIS */
addr = smp_tlb_addr1;
- addr2 = smp_tlb_addr2;
do {
invlpg(addr);
addr += PAGE_SIZE;
- } while (addr < addr2);
+ } while (addr < smp_tlb_addr2);
if (smp_tlb_pmap == PCPU_GET(curpmap) &&
smp_tlb_pmap->pm_ucr3 != PMAP_NO_CR3 &&
PCPU_GET(ucr3_load_mask) == PMAP_UCR3_NOMASK) {
@@ -950,7 +948,7 @@ invlrng_invpcid_handler(pmap_t smp_tlb_pmap, vm_offset_t smp_tlb_addr1,
do {
invpcid(&d, INVPCID_ADDR);
d.addr += PAGE_SIZE;
- } while (d.addr < addr2);
+ } while (d.addr < smp_tlb_addr2);
}
}
@@ -958,7 +956,7 @@ static void
invlrng_pcid_handler(pmap_t smp_tlb_pmap, vm_offset_t smp_tlb_addr1,
vm_offset_t smp_tlb_addr2)
{
- vm_offset_t addr, addr2;
+ vm_offset_t addr;
uint64_t kcr3, ucr3;
uint32_t pcid;
@@ -970,18 +968,17 @@ invlrng_pcid_handler(pmap_t smp_tlb_pmap, vm_offset_t smp_tlb_addr1,
#endif /* COUNT_IPIS */
addr = smp_tlb_addr1;
- addr2 = smp_tlb_addr2;
do {
invlpg(addr);
addr += PAGE_SIZE;
- } while (addr < addr2);
+ } while (addr < smp_tlb_addr2);
if (smp_tlb_pmap == PCPU_GET(curpmap) &&
(ucr3 = smp_tlb_pmap->pm_ucr3) != PMAP_NO_CR3 &&
PCPU_GET(ucr3_load_mask) == PMAP_UCR3_NOMASK) {
pcid = smp_tlb_pmap->pm_pcids[PCPU_GET(cpuid)].pm_pcid;
kcr3 = smp_tlb_pmap->pm_cr3 | pcid | CR3_PCID_SAVE;
ucr3 |= pcid | PMAP_PCID_USER_PT | CR3_PCID_SAVE;
- pmap_pti_pcid_invlrng(ucr3, kcr3, smp_tlb_addr1, addr2);
+ pmap_pti_pcid_invlrng(ucr3, kcr3, smp_tlb_addr1, smp_tlb_addr2);
}
}