From nobody Sat Oct 08 10:27:43 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ml1b42369z4f4Y0; Sat, 8 Oct 2022 10:27:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ml1b41N02z3SQt; Sat, 8 Oct 2022 10:27:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665224864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u0JvaMma2oUSgQuT3Di0Y7lYG9vxRAMvxqygD3I3U+M=; b=UXdvWaHjpqaOQBnexqmXC2TeFGgD6B5rF78DkQoa36yefLVOZgA4uLFIAWOKpGBv1u+Wsa vTTh5q85iuClsk1VwXf+wlTw7G3Uc1I79JR7Uz+U3+pySwJ5RCghrOUyzDJ69asl8UkRhp PC7HWLGtNrxXOTB8wgg+GzMb+eqeEZXsJQGKfifsR2oWS1ZEZzQV69XMMMN+yvjVjyFD0S JqEmoCzi70IGOYkWn+CTGJHduJOcIRrPVADTpSMDPIIvSzJTFU5NSAg4jTKXIkhvtxveFs zAPu5te0o+TAgWpB94L08ngQmYpXNK1GoJcB9X56Bn9HxIKYuT7saNxyUveJig== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ml1b409Bgzv9p; Sat, 8 Oct 2022 10:27:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 298ARhVa064990; Sat, 8 Oct 2022 10:27:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 298ARhr8064989; Sat, 8 Oct 2022 10:27:43 GMT (envelope-from git) Date: Sat, 8 Oct 2022 10:27:43 GMT Message-Id: <202210081027.298ARhr8064989@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Benedict Reuschling Subject: git: 44b0b943b8f3 - main - Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bcr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 44b0b943b8f30c8df926c413323c1fd5594ad7a7 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665224864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u0JvaMma2oUSgQuT3Di0Y7lYG9vxRAMvxqygD3I3U+M=; b=yndGWrqEabSPUUbu03ebLaeruYpAR7Bpl00S3Uipe3rKXMIskZSPrpOBYWGcfZv1tHnV8Y NKGuZezCHELkCjJtv66oC6u2V3OPijP0qDhlzmq2qgnmVHsfXPhJs+NBq+RhCSAu4t0u3I PtWl5MqW+6hiwga79u1a8bvMJdqwWnzIOS3eRa+ImK/GHdOxD6QTFQ9NV2tlupC7GYmH2U 6GvL+KfjrJcuKLNGxLo0SJrtIOBcooxkQthj7wJIe5HmiRIHq0TpiJUWn/crDTFv0Zgsic ffpA/PVhBEFHw1E9xsFbVRXlz6Y+83lot4YYej8Ra8F+TvuzQ/kZYWrefzmjNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665224864; a=rsa-sha256; cv=none; b=E36ivqrTv9YFhXYH2HOYKE0jDEZyDEsYWkCBfICfKoHijZiwoiGGSU2POsbeIMltO+rfyd m8n8pQ63RttO86O2cooIwLncPVaJ5y8ZV91aekZAZ2kK7jpe5iS5bzB6XRc5Zqni8Lpywp uVRZTtKr/6w9fXybanH0kMi9jslG+mthAeQ4VLY6fDsfcS3i0+P2bZG0T0UuS1YU9Ff5PM cQU4WqH9uk+aUJKlOvkOEg6iKDcRGwHMMFeunjwzizJ/TY+ze8prIbIR4ypY2Zd7GnU6qg 8gGidkcKld5N/9CSLz5lhV2Ix63Oe/kN0vjzlhTJ0ci8C34hoF27t2Qu2Q01Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by bcr (doc committer): URL: https://cgit.FreeBSD.org/src/commit/?id=44b0b943b8f30c8df926c413323c1fd5594ad7a7 commit 44b0b943b8f30c8df926c413323c1fd5594ad7a7 Author: Benedict Reuschling AuthorDate: 2022-10-08 10:23:51 +0000 Commit: Benedict Reuschling CommitDate: 2022-10-08 10:23:51 +0000 Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)" This reverts commit 1c2be25f6080ee63baeae55e45761e1310d1b756. kib@ pointed out that it is perfectly fine to write at arbitrary regular file offsets. For example, in a 4K block size character device, geom doesn't support writing / reading 515 byte blocks. The description is perhaps not applicable to all EINVALs returned. --- lib/libc/sys/read.2 | 4 +--- lib/libc/sys/write.2 | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/libc/sys/read.2 b/lib/libc/sys/read.2 index 28d085562af3..8b58debd3fbb 100644 --- a/lib/libc/sys/read.2 +++ b/lib/libc/sys/read.2 @@ -28,7 +28,7 @@ .\" @(#)read.2 8.4 (Berkeley) 2/26/94 .\" $FreeBSD$ .\" -.Dd October 7, 2022 +.Dd June 4, 2020 .Dt READ 2 .Os .Sh NAME @@ -250,8 +250,6 @@ The sum of the values in the .Fa iov array overflowed a 32-bit integer. -.It Bq Er EINVAL -The current file offset is not a multiple of the block size. .It Bq Er EFAULT Part of the .Fa iov diff --git a/lib/libc/sys/write.2 b/lib/libc/sys/write.2 index 048338ed4dee..937e95b53a14 100644 --- a/lib/libc/sys/write.2 +++ b/lib/libc/sys/write.2 @@ -28,7 +28,7 @@ .\" @(#)write.2 8.5 (Berkeley) 4/2/94 .\" $FreeBSD$ .\" -.Dd October 7, 2022 +.Dd February 11, 2021 .Dt WRITE 2 .Os .Sh NAME @@ -205,8 +205,6 @@ is greater than if the sysctl .Va debug.iosize_max_clamp is non-zero). -.It Bq Er EINVAL -The current file offset is not a multiple of the block size. .It Bq Er EINTEGRITY The backing store for .Fa fd