git: 661faa1f77c0 - main - cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask.

The branch main has been updated by np:

URL: https://cgit.FreeBSD.org/src/commit/?id=661faa1f77c0fa9d28d60d71087820aaaaee8b1b

commit 661faa1f77c0fa9d28d60d71087820aaaaee8b1b
Author:     Navdeep Parhar <np@FreeBSD.org>
AuthorDate: 2022-10-05 18:05:12 +0000
Commit:     Navdeep Parhar <np@FreeBSD.org>
CommitDate: 2022-10-06 17:12:00 +0000

    cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask.
    
    This was added in 7cba15b16eb2 in 2016 and firmwares at that time were
    already setting up the iSCSI tag mask properly.  Since then it has also
    become possible to split the iSCSI region between multiple PCIE PFs but
    the driver's calculation takes only its own PF's allocation into account
    and that means this code is incorrect and not just a harmless no-op.
    
    MFC after:      1 week
    Sponsored by:   Chelsio Communications
---
 sys/dev/cxgbe/cxgbei/cxgbei.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/sys/dev/cxgbe/cxgbei/cxgbei.c b/sys/dev/cxgbe/cxgbei/cxgbei.c
index ad66247775e1..b6dc5d5c3577 100644
--- a/sys/dev/cxgbe/cxgbei/cxgbei.c
+++ b/sys/dev/cxgbe/cxgbei/cxgbei.c
@@ -167,21 +167,6 @@ cxgbei_init(struct adapter *sc, struct cxgbei_data *ci)
 		return (rc);
 	}
 
-	r = t4_read_reg(sc, A_ULP_RX_ISCSI_TAGMASK);
-	r &= V_ISCSITAGMASK(M_ISCSITAGMASK);
-	if (r != pr->pr_tag_mask) {
-		/*
-		 * Recent firmwares are supposed to set up the iSCSI tagmask
-		 * but we'll do it ourselves it the computed value doesn't match
-		 * what's in the register.
-		 */
-		device_printf(sc->dev,
-		    "tagmask 0x%08x does not match computed mask 0x%08x.\n", r,
-		    pr->pr_tag_mask);
-		t4_set_reg_field(sc, A_ULP_RX_ISCSI_TAGMASK,
-		    V_ISCSITAGMASK(M_ISCSITAGMASK), pr->pr_tag_mask);
-	}
-
 	read_pdu_limits(sc, &ci->max_tx_data_len, &ci->max_rx_data_len, pr);
 
 	sysctl_ctx_init(&ci->ctx);