From nobody Wed Oct 05 09:02:01 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mj7qm2rSsz4dlqb; Wed, 5 Oct 2022 09:02:12 +0000 (UTC) (envelope-from andrew@FreeBSD.org) Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16]) by mx1.freebsd.org (Postfix) with ESMTP id 4Mj7qm1jdPz46R3; Wed, 5 Oct 2022 09:02:12 +0000 (UTC) (envelope-from andrew@FreeBSD.org) Received: from smtpclient.apple (cpc91214-cmbg18-2-0-cust234.5-4.cable.virginm.net [81.102.75.235]) by fry.fubar.geek.nz (Postfix) with ESMTPSA id 978524E67F; Wed, 5 Oct 2022 09:02:03 +0000 (UTC) From: Andrew Turner Message-Id: <3428A0F4-1ED5-4C3F-B05D-7EBD9567ECCF@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_88BF194D-9719-4887-93C3-BC88D9AA6C32" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 89a9a13c1a91 - main - Remove unneeded FDT checks from phydev and regdev Date: Wed, 5 Oct 2022 10:02:01 +0100 In-Reply-To: <20221005084515.ad2186594090170256a67bff@bidouilliste.com> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: Emmanuel Vadot References: <202210041639.294GdjkP062001@gitrepo.freebsd.org> <20221005084515.ad2186594090170256a67bff@bidouilliste.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4Mj7qm1jdPz46R3 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_88BF194D-9719-4887-93C3-BC88D9AA6C32 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 5 Oct 2022, at 07:45, Emmanuel Vadot wrote: >=20 > On Tue, 4 Oct 2022 16:39:45 GMT > Andrew Turner > wrote: >=20 >> The branch main has been updated by andrew: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D89a9a13c1a917715c047ef9b0d7bd3f6= 416bb13b >>=20 >> commit 89a9a13c1a917715c047ef9b0d7bd3f6416bb13b >> Author: Andrew Turner >> AuthorDate: 2022-10-04 16:27:59 +0000 >> Commit: Andrew Turner >> CommitDate: 2022-10-04 16:37:37 +0000 >>=20 >> Remove unneeded FDT checks from phydev and regdev >>=20 >> They are only ever built when FDT is enabled so there is no need = to >> check for it in the files. >>=20 >> Sponsored by: The FreeBSD Foundation >> --- >> sys/dev/extres/phy/phydev_if.m | 5 ----- >> sys/dev/extres/regulator/regdev_if.m | 6 ------ >> 2 files changed, 11 deletions(-) >=20 > Pretty sure that mmel@'s goal was to make this available for every > platform at one point. > But if someone will do the work re-adding those isn't hard (and I > don't see it happening anytime soon anyway ...). Both of these files only defined one method that takes FDT/OFW specific = types. We can re-add them later if needed, however currently any line = starting with a # is a comment, other than a special case for #include = so they do nothing. I have a local patch to support them so notice when = these failed to build due to opt_platform.h not being included. Andrew --Apple-Mail=_88BF194D-9719-4887-93C3-BC88D9AA6C32 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 5 Oct 2022, at 07:45, Emmanuel Vadot <manu@bidouilliste.com> wrote:

On Tue, 4 Oct 2022 16:39:45 GMT
Andrew Turner <andrew@FreeBSD.org> wrote:

The branch main has been updated by = andrew:

URL: https://cgit.FreeBSD.org/src/commit/?id=3D89a9a13c1a917715c047e= f9b0d7bd3f6416bb13b

commit = 89a9a13c1a917715c047ef9b0d7bd3f6416bb13b
Author: =     Andrew Turner <andrew@FreeBSD.org>
AuthorDate: = 2022-10-04 16:27:59 +0000
Commit: =     Andrew Turner <andrew@FreeBSD.org>
CommitDate: = 2022-10-04 16:37:37 +0000

   Remove unneeded FDT checks from phydev and = regdev

   They are only ever = built when FDT is enabled so there is no need to
   check for it in the files.

   Sponsored by:   The FreeBSD = Foundation
---
sys/dev/extres/phy/phydev_if.m =       | 5 -----
sys/dev/extres/regulator/regdev_if.m | 6 ------
2= files changed, 11 deletions(-)

Pretty sure that mmel@'s goal = was to make this available for every
platform at one point.
But if someone will do the work re-adding those isn't hard = (and I
don't see it = happening anytime soon anyway ...).

Both of these files only defined one method that takes = FDT/OFW specific types. We can re-add them later if needed, however = currently any line starting with a # is a comment, other than a special = case for #include so they do nothing. I have a local patch to support = them so notice when these failed to build due to opt_platform.h not = being included.

Andrew

= --Apple-Mail=_88BF194D-9719-4887-93C3-BC88D9AA6C32--