From nobody Tue Oct 04 23:32:39 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MhvBh56qyz4dylk; Tue, 4 Oct 2022 23:32:44 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MhvBg0TF0z3S7x; Tue, 4 Oct 2022 23:32:43 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-qt1-x82f.google.com with SMTP id a25so138434qtw.10; Tue, 04 Oct 2022 16:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=j/vm5O8V7phmeN2E32lHsvydo9I8ENwAKgry9gQFX90=; b=Fi8lEi5qT8/e0Qw4o+aSdz762jDmnxCXRs4GqlsKuoYhYi1uWlqBOEQgp4pG2kP1aI spiYEIoAV6CJtDM9KHa4IfmPck1aJXZOQg8mN3BeuQ4gAGW33xRPzv8BxMphgSWN1PQX sa/wdhOTWE5Jqq6dwklhZfUl3G11Bww6mQtlHpmMGYa9yi/VkxL8DOSgkCKmhGj0BkwM 21ZFS8UuVwjrZjre+GJvbjRGX7xpzrZYXxOMGTWodQbmgEJDVKerTBpYzTurcarN20C5 qpFAabe7+S6m76Bha+jJdmqbKSQl3tf0vuhtB+wHhWz+HXQSsHmXNtVFaXXYJ0zROpXq ze2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=j/vm5O8V7phmeN2E32lHsvydo9I8ENwAKgry9gQFX90=; b=bm//apwJAF7IJcxi0sNB7UHnNkdYWicBAW8d3l1/uUse7hLKHi7enehzEIEnNpeRB2 RTr/SuQDsLSZcy2aXPZMbdVQyKF1vpMZMpmRMTkgDlypwZE3LBKpUqThc4yfQIANHlsN 4sUMgxtloRUj8Xp8LoGF7OGG9kt5DsZRDw3ui565UAFqEKeI9+K51T8RHiemGqS/qzmA W8G/OnjDIkwBuL4+Pg5oK/owq35Amk1IAqTyCiVe8qdTK8ebApZUxGd4884qAiL5TkLl Gv8jrBn5rrgw6+054sdmSOGgrWlgc/T4XJq68HePq0MqBG9v5rPqZlgS82eV8O+tBht+ QOaQ== X-Gm-Message-State: ACrzQf0qkEtFTYjCM+Y5HH9OQsWvmnwbL+8HSwTePZgqK+P3LzlPgUtW 2Q5XJuDLl1aTOYBZ4MHQxx3q5B0N28g= X-Google-Smtp-Source: AMsMyM5NKgeVT6RiNn28cUgS0Y4AOVn5JGahgKZafr3KCT+I+QK3uv1Rs4PiJHyTN3XY6F28k50jAQ== X-Received: by 2002:a05:622a:196:b0:35d:442b:ab45 with SMTP id s22-20020a05622a019600b0035d442bab45mr21635248qtw.565.1664926361742; Tue, 04 Oct 2022 16:32:41 -0700 (PDT) Received: from [192.168.1.66] (104-55-12-234.lightspeed.knvltn.sbcglobal.net. [104.55.12.234]) by smtp.gmail.com with ESMTPSA id bl14-20020a05622a244e00b0034456277e3asm12429598qtb.89.2022.10.04.16.32.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 16:32:41 -0700 (PDT) Message-ID: <4cbdafad-1cb9-edae-7281-275cb3ce66c9@FreeBSD.org> Date: Tue, 4 Oct 2022 19:32:39 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: git: a58536b91ae3 - main - pci: Disable Electromechanical Interlock. Content-Language: en-US To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202210041444.294EiFlt021813@gitrepo.freebsd.org> <6031d19e-9dd0-ba07-b30c-3a10db4c7d8b@FreeBSD.org> From: Alexander Motin In-Reply-To: <6031d19e-9dd0-ba07-b30c-3a10db4c7d8b@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4MhvBg0TF0z3S7x X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=Fi8lEi5q; dmarc=none; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::82f as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-3.20 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BLOCKLISTDE_FAIL(0.00)[104.55.12.234:server fail,2607:f8b0:4864:20::82f:server fail]; ARC_NA(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82f:from]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org] X-ThisMailContainsUnwantedMimeParts: N On 04.10.2022 12:47, John Baldwin wrote: > On 10/4/22 7:44 AM, Alexander Motin wrote: >> The branch main has been updated by mav: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=a58536b91ae3931d222c3e4f1a949ff4a4927fb2 >> >> commit a58536b91ae3931d222c3e4f1a949ff4a4927fb2 >> Author:     Alexander Motin >> AuthorDate: 2022-10-04 14:34:15 +0000 >> Commit:     Alexander Motin >> CommitDate: 2022-10-04 14:34:15 +0000 >> >>      pci: Disable Electromechanical Interlock. >>      Add sysctl/tunable to control Electromechanical Interlock support. >>      Disable it by default since Linux does not do it either and it seems >>      the number of systems having it broken is higher than having >> working. >>      This fixes NVMe backplane operation on ASUS RS500A-E11-RS12U server >>      with AMD EPYC 7402 CPU, where attempts to control reported interlock >>      for some reason end up in PCIe link loss, while interlock status >> does >>      not change (it is not really there). >>      MFC after:      2 weeks > > See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256264, though > that is more for the case where slots aren't really hotplug at all. > > The root issue seems to be that there are generic HotPlug-capable > bridges but that manufacturers fail to correctly wire up the various > input pins such that the bridges can actually determine that there is no > MRL or EI, etc.  The above PR (which I still can't get the reporter to > test the patch for, but perhaps should just merge?) disables PCI-e hotplug > if the link is up, but the other status bits claim that the device is > partially inserted when attaching the bridge. In my case the slots are really expected to be hot-pluggable, just ASUS can't do things right. In the case of the PR your patch seems to have sense. I'd be more worried about already present check for broken MRL -- if we see MRL open, but device is still powered, we may wish to quickly shut the device. But I agree that probability of false negative here is much higher than of positive. I still haven't had my hands on on any hardware implementing all those cool bells and whistles. -- Alexander Motin