From nobody Tue Oct 04 16:47:04 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MhkBd5qSQz4fDjT; Tue, 4 Oct 2022 16:47:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MhkBd5Nf7z49ST; Tue, 4 Oct 2022 16:47:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664902025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VdOjH4pNJVzqtMsJk3QH2PBL9wHbxg0V9gulte4W3Ws=; b=I8Lmbs5bIk1wzkIeud1mIBG0WuHEQri8Y/sGvHu2hS0W8WCcxjwXjYuBqaXDPbtJCb/uKX ae7jZ7/tPakq256Md8gJTCwb+5IvhxZX1RWnNVR1fehxttMX49QOYhHGycphgjcGO5f541 uns0ItzVOPR3BwGe+jTgyuebBp56mvY5IDsaME+uO40DDe/TYJ+KdwE0go2sdt6+yQYrEZ nVEDd41STuE0il1rJrz7ml6foAtpIRJy7rWEGk1aWiFDGtQDA/gPtfr8VEfTpisvvP1B35 J5ddVwvR/we5Kfl/HaBq5Na8J9b7Lgo4TKyMgP2PVQLE+hhOeRQzmCsjlv8pQg== Received: from [IPV6:2601:648:8684:ad0:c138:fd94:ebf2:bb32] (unknown [IPv6:2601:648:8684:ad0:c138:fd94:ebf2:bb32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MhkBd1LYSz1NGr; Tue, 4 Oct 2022 16:47:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <6031d19e-9dd0-ba07-b30c-3a10db4c7d8b@FreeBSD.org> Date: Tue, 4 Oct 2022 09:47:04 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: git: a58536b91ae3 - main - pci: Disable Electromechanical Interlock. Content-Language: en-US To: Alexander Motin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202210041444.294EiFlt021813@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202210041444.294EiFlt021813@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664902025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VdOjH4pNJVzqtMsJk3QH2PBL9wHbxg0V9gulte4W3Ws=; b=L8EmEhULu5N2CEnyP6NhjI3/AsdRkideAdk7nknwDlX/Y0lpfD7OxMHDpVr+BqOkqKBHm6 rrETNcXfxG9SPfcPob0PWfBtQsxjsvonkFXpiItlFSbRkx4BkqCklKCV6iDoDfY6aneQoB HydBINib37Dt8os6ng0FknaXZ33b/FczOMI3e2KlTT2VM5Tdz/lD6zFGvxuDfye1iV9g0n kV3hfC/R1ItmSwenMoTUYz0LybyIcUW2Jiblsrd2mXZAasgbBL42eyn5/w8xc5dqbtn+bI yOk2gG7+I+/eeM71ET/z2pIMUDrTTdQRB+Zap1UJ1kLq4SHF4KceCwaC0X4wTw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664902025; a=rsa-sha256; cv=none; b=XQy/CS+xra+IdQNRiEsHm0zwfXgsYmUT0HdIpoJUUMftGaH8YIi2DVaodJYyBSWphW4etW gqQX3MQpBmDWj3Qqi9Z9mxMwo/WZDCT1S01qnhbcyxL8t5ql+psZEvFbhuV1xtHkgVkx4f KtG1nAvw3tCM8m4jjXiOdvvU9CJZx8L0fLzh/B/2ZUQh1/Qx8N5oTaZz6RBu8M6VTtcekw 9rKMYtanIRVZvZ1XvCDvIRm5DTMJyHeTLiUp904hSWgIaQzzxe3x1axnBHNsKiAFWJlXU4 UBUpV9oBnYuN7ypxXmYrPzoYwaR6k/voElMay6sATnHSk+MozQA455JgmiabkA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 10/4/22 7:44 AM, Alexander Motin wrote: > The branch main has been updated by mav: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a58536b91ae3931d222c3e4f1a949ff4a4927fb2 > > commit a58536b91ae3931d222c3e4f1a949ff4a4927fb2 > Author: Alexander Motin > AuthorDate: 2022-10-04 14:34:15 +0000 > Commit: Alexander Motin > CommitDate: 2022-10-04 14:34:15 +0000 > > pci: Disable Electromechanical Interlock. > > Add sysctl/tunable to control Electromechanical Interlock support. > Disable it by default since Linux does not do it either and it seems > the number of systems having it broken is higher than having working. > > This fixes NVMe backplane operation on ASUS RS500A-E11-RS12U server > with AMD EPYC 7402 CPU, where attempts to control reported interlock > for some reason end up in PCIe link loss, while interlock status does > not change (it is not really there). > > MFC after: 2 weeks See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256264, though that is more for the case where slots aren't really hotplug at all. The root issue seems to be that there are generic HotPlug-capable bridges but that manufacturers fail to correctly wire up the various input pins such that the bridges can actually determine that there is no MRL or EI, etc. The above PR (which I still can't get the reporter to test the patch for, but perhaps should just merge?) disables PCI-e hotplug if the link is up, but the other status bits claim that the device is partially inserted when attaching the bridge. -- John Baldwin