From nobody Tue Oct 04 03:03:36 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MhMwb3jK7z4ddtq; Tue, 4 Oct 2022 03:03:43 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MhMwb3Bhfz3p4j; Tue, 4 Oct 2022 03:03:43 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664852623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F5DsqlITBeZdZuDcBhtPDrqdGQ1x3dOWBgnm1jw71Jo=; b=coiczSrqiugaQaxs1DpcAVmDUVFaSvondPyolDBeotyBYH0k0CFy4Fapady93DIEL6JLl+ lkewSCO1QO4goLY0s3FFqHWbGs2rLeCsdEga+P/AS03V//I8AIQdAY+wT9xCNAjhEPNR4O rPIaUPHNllEUsPmD+dipryKQw6J48K9oJHANAQzFHTy8W7PBU576X0oaxKqfO0egINAfEa ujg03jIialvxNYKghE6pMNs3XruNteC0u+axcLfi4nEZlRooedH4jJiiBRMoQTjEVtIV8F QHu2cmk7yBeAD64PrINhXk9BGcZUKHKFTMMtuc4/rxe0f7GjjolVqDl12VBucg== Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MhMwZ5Vy3z1Kcf; Tue, 4 Oct 2022 03:03:42 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.65.22091101 Date: Mon, 03 Oct 2022 20:03:36 -0700 Subject: Re: 5e4854cbf8d8 - main - rescue: Link libzutil after libzfs. From: Ravi Pokala To: John Baldwin , , , Message-ID: <1BB1F50E-C679-4570-8C7C-582B8C83CAD6@panasas.com> Thread-Topic: 5e4854cbf8d8 - main - rescue: Link libzutil after libzfs. References: <202210032311.293NBKEd065568@gitrepo.freebsd.org> In-Reply-To: <202210032311.293NBKEd065568@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664852623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F5DsqlITBeZdZuDcBhtPDrqdGQ1x3dOWBgnm1jw71Jo=; b=yUaNL4ctodaqPyFo7w1TChyHJMEKNNFuwFmRNOji94nH6WO+vPqcyodtBUltf+GfQxIh0x pyy7Kocb9J+2pGNS2WBBcp9o308+h7/P6MYpkaswYOikBDh17diiAAMHs/RPzCYCkWGG90 /5fPDRMxA7DI/epyo1guSI6ai3SftQtEDyAm9nHeHXJ8gsyV5H+/bb+9pzBEnDMkdBsOkP QpXNwVLBHgcBBRNOjYABi1kpMC8C1gVBsCgE3SjpQIu+m0za+f+HRJeaVEKkYF2PL4fF7L SWlbwQitD9WEhIes3gmNTxhdPWPzJCEHKeBlVb8IT6SkyAoCSe5ybyqsrDrwbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664852623; a=rsa-sha256; cv=none; b=PCXvt4M4SM0nS99TfwsGU0Hl9odv1K5nRN9M/u4kfJfe7G+EBRGGjn9DgYLqUaF3pnjjI1 lkKIPEmSyZjee+S7VR3YlJALrKs33suqMUg9EiZPP+KAjEK9/UmB+r9FBPOu4sFQN5Krmp zEwi8SSfbq76g+eZMvTx0ApZ4qAYsQjde2JYYFKBZQmmMIBYqBBCTGhbOi56Fm0EFv5bAg zPOcvwxNuZhn1XbQs4QC42HReoWzU181uGfEXIT5QNZhLO24xR3JGTrE/Ji7SpPyFuzgXS 7F2zqyN6k5bhj7NkU57HrI+Gqw6F+/Psv5NGU0U5UbsVCQZ6IjamZmitzWHfXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N -----Original Message----- From: on behalf of John Baldwin Date: 2022-10-03, Monday at 16:11 To: , , Subject: git: 5e4854cbf8d8 - main - rescue: Link libzutil after libzfs. The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=5e4854cbf8d8a9b056472967d15e1021d36fcae1 commit 5e4854cbf8d8a9b056472967d15e1021d36fcae1 Author: John Baldwin AuthorDate: 2022-10-03 23:10:42 +0000 Commit: John Baldwin CommitDate: 2022-10-03 23:10:42 +0000 rescue: Link libzutil after libzfs. libzfs depends on symbols defined in libzutil. For static linking ld.bfd is less forgiving than lld, so rescue was failing to link when using ld.bfd due to unresolved symbols from libzutil used by libzfs. You're solving an issue of unresolved symbols by putting the library where they're defined *after* the library where they're used? -Ravi (rpokala@) Reviewed by: imp, kib, emaste Differential Revision: https://reviews.freebsd.org/D36811 --- rescue/rescue/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rescue/rescue/Makefile b/rescue/rescue/Makefile index 3c758a41f294..cc4c13c0a624 100644 --- a/rescue/rescue/Makefile +++ b/rescue/rescue/Makefile @@ -140,8 +140,8 @@ CRUNCH_LIBS+= -l80211 -lalias -lcam -lncursesw -ldevstat -lipsec -llzma CRUNCH_LIBS+= -lavl -lpthread -luutil -lumem -ltpool -lspl CRUNCH_LIBS_zfs+= ${LIBBE} \ ${LIBZPOOL} \ - ${LIBZUTIL} \ ${LIBZFS} \ + ${LIBZUTIL} \ ${LIBZFS_CORE} \ ${LIBZFSBOOTENV} \ ${LIBICP_RESCUE} \