git: 611cf392672c - main - libfetch: Use memcpy in place of an odd strncpy.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 03 Oct 2022 23:11:31 UTC
The branch main has been updated by jhb:
URL: https://cgit.FreeBSD.org/src/commit/?id=611cf392672cf7aa52a593412fb2537546a7d6a4
commit 611cf392672cf7aa52a593412fb2537546a7d6a4
Author: John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-10-03 23:10:43 +0000
Commit: John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-10-03 23:10:43 +0000
libfetch: Use memcpy in place of an odd strncpy.
The length passed to strncpy is the length of the source string, not
the destination buffer. This triggers a non-fatal warning in GCC 12.
Hoewver, the code is also odd. It is really just a memcpy of the
string without its nul terminator. For that use case, memcpy is
clearer.
Reviewed by: imp, emaste
Differential Revision: https://reviews.freebsd.org/D36824
---
lib/libfetch/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/libfetch/common.c b/lib/libfetch/common.c
index 628ab69612f7..47545e5178c3 100644
--- a/lib/libfetch/common.c
+++ b/lib/libfetch/common.c
@@ -456,7 +456,7 @@ fetch_socks5_init(conn_t *conn, const char *host, int port, int verbose)
goto fail;
}
*ptr++ = strlen(host);
- strncpy(ptr, host, strlen(host));
+ memcpy(ptr, host, strlen(host));
ptr = ptr + strlen(host);
port = htons(port);