From nobody Sat Oct 01 10:07:34 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MfjT25jg0z4dl7Y; Sat, 1 Oct 2022 10:07:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MfjT25DWcz3Xjp; Sat, 1 Oct 2022 10:07:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664618854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fsRA5U5sj/SWa7op67JXujVKkzWs6bl8dR+bT0R1uyk=; b=UCmI8DOrsdtp2+FOeMJAM58pYZ0G/9jQ0OWjWy2UXBq0S7wObkqeiW8YXbIHCQSU3ieSfn p+kNUBIbZFZV2vOc8yTeoud8Ym+j214pVD1ioCizig61Qb8fc86g38zJhLL+6k4q3dGgSY ZaIdZ8rNIgmJQEaO/5NYXVjtDUzgWj6Cn2Z/Oiku0m1WyNu1JrZ8c1kMSJ6mgPuJ4hbBmI 57LzsHOwsREA4YE4JCZQhdf1/IqeDS0LODG5QUA2KNalJzomoYsT+eHd97jSYVqKNeqgBN vg2lFhr4ZxISJQJPCBcfN5JOohvpKy5KLWCZPiB3e+ZaCgGdh+5ADQnxWRpY+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MfjT24Jg9zVgp; Sat, 1 Oct 2022 10:07:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 291A7Yop088657; Sat, 1 Oct 2022 10:07:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 291A7Y5c088656; Sat, 1 Oct 2022 10:07:34 GMT (envelope-from git) Date: Sat, 1 Oct 2022 10:07:34 GMT Message-Id: <202210011007.291A7Y5c088656@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mariusz Zaborski Subject: git: 94c4f663bab5 - main - seq: fix potential NULL ptr reference List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: oshogbo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 94c4f663bab58ec07584786dd76866011d5b2506 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664618854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fsRA5U5sj/SWa7op67JXujVKkzWs6bl8dR+bT0R1uyk=; b=Py4wA+R5ngiC52C67bfiBl3UtTZJWZCVGE18HS1A8CIkKAfzo5PrzzYYG5tHqnWO9/kRR1 ft0SZzeckaGveF6Hmx+07mB3vqFWlb38B9aeWiyssfSj638sL70GL2f3Ac8hdZfRt3xElS 9PCa5QQq2RJFa1twPjmiZ1+I16EeGimzU4/XWhft5X2gvHlpFB0wkTGoB2ZnHC/ynvvQLg /1CdnQG4N+ss6LYysIgxlwFDzrAt6IkCrkE7WkxxTrjpafHjKhE0Lj6AvM6LuFEeEPBP4o E+zphNIO7PwhxujAvVzCcFRvPhlccBAwOfUNUO3HwpLtdySU6XUsE9r7vkfi/g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664618854; a=rsa-sha256; cv=none; b=woPcNZCmyFLaYJwqqRJYu9wVVDkzIK73xZdKV2yYXQ6FBS0zeAnVPlb4BkOtIhIIkASk6g FMB8ya+u2V6ZhpYfOCbFYsm4O0y8rVcSwP9GjbGGKESkJDaiCQGKxXvwBZpZ07C8FPMU+N AdqnM1fA6qPw1Tz/iyEejSL0arClJuDDqtatML0E5ma7UPDtMzJFcatPivUAB4yDIv2QsB U3dSGUekNG/WQp+cqtsoztCRF7rCAzSpvLvxmB/OfUxBQyMNSSvepqs0JoR+asd7kljr68 gdoSJKTHlUJHZDEyqFKgsFmBjAhEBRwJcZ6KgrzX7c412n7WKxKAe521g63H+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by oshogbo: URL: https://cgit.FreeBSD.org/src/commit/?id=94c4f663bab58ec07584786dd76866011d5b2506 commit 94c4f663bab58ec07584786dd76866011d5b2506 Author: Mariusz Zaborski AuthorDate: 2022-09-30 17:36:04 +0000 Commit: Mariusz Zaborski CommitDate: 2022-10-01 10:05:03 +0000 seq: fix potential NULL ptr reference asprintf(3) allocates memory, and there isn't any guarantee of success. MFC after: 2 weeks Obtained from: OpenBSD --- usr.bin/seq/seq.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/usr.bin/seq/seq.c b/usr.bin/seq/seq.c index 7559dbd9ce20..47ba0b7ce3af 100644 --- a/usr.bin/seq/seq.c +++ b/usr.bin/seq/seq.c @@ -199,8 +199,12 @@ main(int argc, char *argv[]) * loop held true due to a rounding error and we still need to print * 'last'. */ - asprintf(&cur_print, fmt, cur); - asprintf(&last_print, fmt, last); + if (asprintf(&cur_print, fmt, cur) < 0) { + err(1, "asprintf"); + } + if (asprintf(&last_print, fmt, last) < 0) { + err(1, "asprintf"); + } if (strcmp(cur_print, last_print) == 0 && cur != last_shown_value) { fputs(last_print, stdout); fputs(sep, stdout);