Re: 1e9c9ab59577 - main - pkgbase: do not record dependency on non-existent liby package

From: Ravi Pokala <rpokala_at_freebsd.org>
Date: Fri, 18 Nov 2022 19:35:39 UTC
-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Ed Maste <emaste@FreeBSD.org>
Date: 2022-11-18, Friday at 10:19
To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
Subject: git: 1e9c9ab59577 - main - pkgbase: do not record dependency on non-existent liby package

    The branch main has been updated by emaste:

    URL: https://cgit.FreeBSD.org/src/commit/?id=1e9c9ab5957795acc0d436ce21ad07373081d990

    commit 1e9c9ab5957795acc0d436ce21ad07373081d990
    Author:     Ed Maste <emaste@FreeBSD.org>
    AuthorDate: 2022-11-17 19:22:33 +0000
    Commit:     Ed Maste <emaste@FreeBSD.org>
    CommitDate: 2022-11-18 18:08:46 +0000

        pkgbase: do not record dependency on non-existent liby package

        liby-dev provides (only) liby.a.  liby has no headers or man pages, and
        there is no liby package.  Add a special case to record no dependency on
        the package that does not exist.

Hi Ed,

What is "liby", and how is it useful without headers?

Thanks,

Ravi (rpokala@)

        PR:             266923
        Reviewed by:    bapt
        Sponsored by:   The FreeBSD Foundation
        Differential Revision:  https://reviews.freebsd.org/D37429
    ---
     release/packages/generate-ucl.sh | 12 ++++++++++++
     1 file changed, 12 insertions(+)

    diff --git a/release/packages/generate-ucl.sh b/release/packages/generate-ucl.sh
    index 2988b48b10a9..de1a21391950 100755
    --- a/release/packages/generate-ucl.sh
    +++ b/release/packages/generate-ucl.sh
    @@ -45,6 +45,18 @@ main() {
     		caroot)
     			pkgdeps="openssl"
     			;;
    +
    +		# -dev packages that have no corresponding non-dev package
    +		# as a dependency.
    +		liby-dev)
    +			outname=${outname%%-dev}
    +			_descr="Development Files"
    +			;;
    +		liby-lib32_dev)
    +			outname=${outname%%-lib32_dev}
    +			_descr="32-bit Libraries, Development Files"
    +			;;
    +
     		utilities)
     			uclfile="${uclfile}"
     			;;