From nobody Tue Nov 15 11:14:04 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NBNq05ZSsz4hgBc; Tue, 15 Nov 2022 11:14:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NBNq053wJz4FKS; Tue, 15 Nov 2022 11:14:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668510844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UvL7PkhOB2jQfEdwpuNFI4hRZdnKqswJOuN9meOz4tQ=; b=lqvsRHqAzYfetISPb2YGZpyTPEUvHtwVUCCGo8TZO2VVPUpO2LvqYNB9tBhai8WhTMmtua hD69TOkaA5BXjCkMPNfwjVkauiZwZh+xb0YPsScwz2lYeTk9YaZmVjeY1io5tzPSx8QpIh BqoP5/4LE59m+0wV/r/kAH8Kp4DfZGPydN+1+0ImBk/oyi4VdNTLoZJmmb+vIcEvh+Q0YM RICBT59duI526mswFRn+Gypi4WHqm/DsQ7cmKzRAWUOEDral2b7NiOKShlNFvSWeGVZ3LK AmQ8Ksy9LJYK83j6jkSdMBDdAfvx4EyQNZvrcOqU9u2GD3jHsb9MsPVFa2lU6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668510844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UvL7PkhOB2jQfEdwpuNFI4hRZdnKqswJOuN9meOz4tQ=; b=ogTTsiaXD0cFuw37lLFXq8yGJjsV9gO87kTosWO4jiJe0fbomJaCYYe11FigJ4zNVxen42 4ZCxevTrVfXpEVpLryNhXb1AqMkyUdE0iL+5cNpal8tKyXp542vWsieLSBF33YCFrOZRvl R76e75OuyFt6ETvbvQwvyNM1EHpF0ky925kgg9j6hebizUjAFYtFdmUijTeVUTssxiffQb g7kT5AAORb5511NRZyX1q+AyCcvzpVPis1Fun7OXNBOPZQTW5Z+SDog6X2GYhJMw4cRZZ3 QZsbQtUE2GHRh1eTsCtJD7I7f4HZD9gpY2rutG6iuqdVaKYnEGXVvWgs1XMizg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668510844; a=rsa-sha256; cv=none; b=gbBPKJEbaHh/lcy0fGL7I9Z/zomwNO1041m3N0tY/8w1AyzNW4xrt82m068Od6VFIyv1jn QKicNY8sb4AEq49M9M5vpWcY3XPEOuPZN/iaJyfT5GdMU0qYC83uPpBob41SaUIQT92JDE LrTazr+92XJlVjkZEtL1FCCXQ+tkoos+dTivMPy1MKF85R1dAfqvuN756DWK5wdW1gAqh6 KRs0M8EjEq1VDOTDnQsuL+lFYV6/FHTA5o0OCpiRNItNcSATbHoz5dhs/ZRmwtFlwz8YjZ PDFsDZTrhjCsET/CB9H5HBJi9bgi4WjBESmcKD+KUBaENuFI5Y21ZjAT+zrabA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NBNq046QlzL5k; Tue, 15 Nov 2022 11:14:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2AFBE4Sx073646; Tue, 15 Nov 2022 11:14:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2AFBE4LF073645; Tue, 15 Nov 2022 11:14:04 GMT (envelope-from git) Date: Tue, 15 Nov 2022 11:14:04 GMT Message-Id: <202211151114.2AFBE4LF073645@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 48767d8734ea - main - pfsync: fix memory leak List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 48767d8734ea21182eec04273127818e3878c2e5 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=48767d8734ea21182eec04273127818e3878c2e5 commit 48767d8734ea21182eec04273127818e3878c2e5 Author: Kristof Provost AuthorDate: 2022-11-15 11:11:32 +0000 Commit: Kristof Provost CommitDate: 2022-11-15 11:13:11 +0000 pfsync: fix memory leak The recent refactoring to prepare for pfsync over IPv6 introduced a memory leak. If we don't have a sync peer configured we return early (without sending out a packet), but failed to free the newly allocated packet. Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/if_pfsync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index f8cca8a4460b..a2baf477873e 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -1589,6 +1589,7 @@ pfsync_sendout(int schedswi, int c) } #endif default: + m_freem(m); return; }