git: 8526120ad41c - main - ixgbe: workaround errata about UDP frames with zero checksum

From: Andrey V. Elsukov <ae_at_FreeBSD.org>
Date: Thu, 10 Nov 2022 09:47:09 UTC
The branch main has been updated by ae:

URL: https://cgit.FreeBSD.org/src/commit/?id=8526120ad41ca47367b43f8f4459e0fa61285571

commit 8526120ad41ca47367b43f8f4459e0fa61285571
Author:     Andrey V. Elsukov <ae@FreeBSD.org>
AuthorDate: 2022-11-10 09:34:40 +0000
Commit:     Andrey V. Elsukov <ae@FreeBSD.org>
CommitDate: 2022-11-10 09:34:40 +0000

    ixgbe: workaround errata about UDP frames with zero checksum
    
    Intel 82599 has errata related to IPv4 UDP frames with zero checksum.
    It reports such datagrams with L4 integrity errors in IXGBE_XEC
    register. And after afb1aa4e6df2 commit such errors are reported
    via IFCOUNTER_IERRORS. This confuses users, since actually all frames
    are handled correctly by the system.
    To workaround the problem, let's ignore the XEC register value for
    82599 cards for now.
    
    PR:             266048
    Discussed with: erj
    MFC after:      1 week
    Sponsored by:   Yandex LLC
---
 sys/dev/ixgbe/if_ix.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
index 54008a24074b..1d472d7df628 100644
--- a/sys/dev/ixgbe/if_ix.c
+++ b/sys/dev/ixgbe/if_ix.c
@@ -1584,8 +1584,12 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc)
 	 * - fragmented packets count,
 	 * - oversized packets count,
 	 * - jabber count.
+	 *
+	 * Ignore XEC errors for 82599 to workaround errata about
+	 * UDP frames with zero checksum.
 	 */
-	IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + stats->xec +
+	IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc +
+	    (hw->mac.type != ixgbe_mac_82599EB ? stats->xec : 0) +
 	    stats->mpc[0] + stats->rlec + stats->ruc + stats->rfc + stats->roc +
 	    stats->rjc);
 } /* ixgbe_update_stats_counters */