git: ada90cb978e1 - main - tcp: remove INP_DROPPED check from notify functions
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 08 Nov 2022 18:24:55 UTC
The branch main has been updated by glebius:
URL: https://cgit.FreeBSD.org/src/commit/?id=ada90cb978e14fdb539fb7c3557f1e9e4f9acdcb
commit ada90cb978e14fdb539fb7c3557f1e9e4f9acdcb
Author: Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2022-11-08 18:24:39 +0000
Commit: Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2022-11-08 18:24:39 +0000
tcp: remove INP_DROPPED check from notify functions
These functions tcp_notify(), tcp_drop_syn_sent() and tcp_mtudisc()
are called from tcp*_ctlinput*() right after successfull
in_pcblookup*(). They shall never get a pcb that is dropped.
---
sys/netinet/tcp_subr.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c
index 2363cdf75e1e..999f52c9a339 100644
--- a/sys/netinet/tcp_subr.c
+++ b/sys/netinet/tcp_subr.c
@@ -2596,9 +2596,6 @@ tcp_notify(struct inpcb *inp, int error)
INP_WLOCK_ASSERT(inp);
- if (inp->inp_flags & INP_DROPPED)
- return (inp);
-
tp = intotcpcb(inp);
KASSERT(tp != NULL, ("tcp_notify: tp == NULL"));
@@ -3319,9 +3316,6 @@ tcp_drop_syn_sent(struct inpcb *inp, int errno)
NET_EPOCH_ASSERT();
INP_WLOCK_ASSERT(inp);
- if (inp->inp_flags & INP_DROPPED)
- return (inp);
-
tp = intotcpcb(inp);
if (tp->t_state != TCPS_SYN_SENT)
return (inp);
@@ -3356,8 +3350,6 @@ tcp_mtudisc(struct inpcb *inp, int mtuoffer)
struct socket *so;
INP_WLOCK_ASSERT(inp);
- if (inp->inp_flags & INP_DROPPED)
- return (inp);
tp = intotcpcb(inp);
KASSERT(tp != NULL, ("tcp_mtudisc: tp == NULL"));