From nobody Tue Nov 08 03:04:22 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N5tHY0FQNz4h8cB for ; Tue, 8 Nov 2022 03:04:41 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic309-22.consmr.mail.gq1.yahoo.com (sonic309-22.consmr.mail.gq1.yahoo.com [98.137.65.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4N5tHW4Kn0z3hH2 for ; Tue, 8 Nov 2022 03:04:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=jmljHYop; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.65.148 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667876677; bh=93FG5TG6/0O7rEaKIDjThuL1px5DGHZKg6A/+8Um0Y0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=jmljHYopJKr9mivE6OhMCbFvQpDwwaCsntrPqB/uFvj0OAXL/MU1mqpX8KvNc3xATwaLYkYCHZTmkD0J5jhdKRaQDnlSGEE8s28ml/i2kx1XYsLVWM52S86QwnjI6TLbGAYOzaKXMKa4Xw0zPVUV/aHjSFf0vP2p+P66Dk/c1Yg0YV/pY6AMl4MkoNjgaPWAQr3tgAshCr+PdvJfrFf9hSn9k+FTLlo3bJ4lpOBKwCnPh7OY+T8ZcPvusauRle6k0nPbijpUU086V8bYnfAJ9aDSAlqGDMTKzrIPqGXrbPOkhrKLuftWoCKEIFv7bYgkQDhQbLkoi2lMgEAvU2c2sQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667876677; bh=h3gRAN7ktN6eOOwz+W929LnkHQ4KURurhIr/CeLg3I6=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=sVBIvkkIXeJDXVpkJP7enz94Qt72GFZ2rcM01sLcqIPxAyKc7oKdJ/FEkhq4PHQH3ISturE8ir0uz5arjMg8kbLY/8avpiFCPdG65KwCk3fIFINN5jylDJ0oWKw8HdPzM27yXitqqHpuve+0/fuhMIchUrP9W5cJKp9PwYe5lLBWael0pmLN+VNtHrlGdBLqBqi2KEGfb5uMCs5v1qgJakKIoy8S6ESGJhu7Q6X6brIT7G6a924+AxjIlwdAoTuYt76dIdRiR+e0SsLagAY2zY7ZjvuhR6v/x15QjtecBkenZDYH4o+3V4ouWyJLE/sDcic5i27RM82TH+zmRbYa2w== X-YMail-OSG: LMCOdokVM1n7BJRQHxT_wAJFQLD.uJREQN4VMTbZKxBtUlK.oC5dNXad1pUsJma mUp5d23oSsnaEIHYGHlFyW3brc5HeYZBMWPPR7j4ioVDCMcBqiPE0HULKon5_2o8GF273RM9WhD4 F1Qrfv8uapsihAB5ffJdppb3Q.dBYWvBv3BtQJ_Ly_iQJuq_Y6HuYz3Om39s3TPmzVpIUE1BUsVM rql1zoLxJI2XGmdGXiiARd3F8iI6LDbF_gxjxi0vs6NWahbzPzIFrCQ8O2UyHRVy.07ND51GLpO7 SoOQJWq7ZSnWsmuTtfw_EmC4idnTcciTYP6koyCCJS76yUxkNzEzKKIdoOQJs_VyZ.rIDaN7qo9C VSNaoCQbktHDAXd4V8gI7BQHaKJmK6j58gqvKJbrWvhiyUGR0_72W_NGWkNG_bcjnmWga__uRp8N 50l81yhVSux6jLpuAkAC9pRResraU02x4CNHG_6H__3LXIfJowp2kgncKFmOJcgvk_G.YfvbTO0Q _j4YD_ngyr_jdSOTmM1BQMkdYMmOK5otX0K8M3Bw7y6tvd4Etv8Bdb3iB.h7z7VlrjJK6110hbPG NxjahnR7u.DLfqHMOx_BftVodIN88FCZRdSV7LGMbtUbbH5Myz7WL8RH3bkPyQT2vYw0p8di5KO0 CElNiMAE40pdUuyOWlq58JzKEEefQTfl_yf4.y3zhtyY06sNdh22r.l5N7r.dxXw1KOyJTjuGFua 8Q4BmkTx9eOeNew0UMtFg388O2seeop044oJ2ONbk8U5WA7VMWjheCR9pTpjd7BOAW_N7Cuj1Uv5 LYqtxxnFrZt..Mt6RLMCKXCijj83xwj4mv.fBoqCHmH9bGqpT.RY_rUB4_QfADCalBra4DXTGjDD dXPxMhMmk6_QdHt7dTrx5yAbePnajctR1HLQRP79BQx9CeQz110QLjCzA6z9VX1LImhX9szuL1_T E0B7aKtNRMjexXb9FszcoqmvPpl0PwlRPhthf4UncysS4EB2Vxhh1WtruajhODpTG_zN3sabYIY0 1nXd5IrAgAi.zi7YdBljIbwyEgzmojCTA8AB.7KhyZK857ykx1x3c6veYxTwWPyfDQMXJFof437d JusOpFOulQOAr_svoTovnJHYE0lFN2LdIbE9QtYTH7bXMbvMB2ey5Z_C7q_JpQ9e7fYMKsoA3o5g Qo.ZMn5PHmMNyaw8Y5jvmwj4y2NbUazuWySUPFgC.Ck5VqKnlgCfsY8qMEIFsqZEXh5H1YHQ1yOZ gmGu5XsrV06mqKJvmS0TQqjrIk2XGOGuAt5WNPFod86LvOV3ij_XDCXy6FjLSAI837bai9hUqK8b r4wGOTKvgmC4fhDgGBZfWPBM_r9FFTa.ISuo1GPQzkh9QETwlcno7HS7h3Q7ERuQBqg0cPdTDMCO 6n_q9RiRE7pi2gBis0AqlMFUajjwSfJf..ieZnIHJd.nOzcy9MkMHgM7sxlojKBqQKYT.HOGWYZQ nRyHWcGYJChbrrXsBLLVQM1IFg.fPZu5R2IwnUltQHIuOEomih9CQ2f24fMPkxeZQyPOKgrC1sTs Dsl6yZ1165TNwFaDkWyt3Yu3t.kXOLrxOkiSYvuXpmxoANr2ODFGSXFxD3BvyDZ9za6DSlaQfqlk 3N_kVMubC6qSMzMcKdyW7GhB4dI2.s9TpIrpk1qHwNAgECUQUbIB5uKLtCMcg.6vfVAHM91jGTDl rEz01y3IzVSZ9BUnH3j3BZZLYWxoF55KeAEuBMyRvGwRD94BCA2_tinUriLYvwHtfkTmzq0s4kcc n2_8.ACQo_iknw9yRnOSmgNNwDjgx9iVTOTLI0axhdaTfIN6bRF.7rnN4r7zJFFKxLuGEuvHUCNq Xlqx.oeWjvNohwKV0dMsiJSp1QwpySM411wN2ReQ7n0MHcHeOpSi0.YTRlE2F82K7i83k8gT5KzD 5l5AOOLkfvLLTIDsC2HwX43m.GDaQeHMaIko8z8dwpVIK5jyTQiZyLu4dSmSw7CQG1A.f4ngYsc7 7PneqcOF5VfHjq3ITpf4k.1kaxn8vd4PayGCA7d6bQR_fdQGmgWfW.K7144o36b9DN5YCoy54ZxU Eik7L7qsrscZBsIHV.Ikm4FoFH_VsSRiZVanC9Xc52Bp36k6J6SzGvjwqqYJjvDAvEGkzlnusfww E1wKchPsoXKtj7_tnqdiOIivJYk0zEdBf._vAzLlRbRh1fNCaVRYw6tGGwbfqHuvtV2eYUIKObC8 nnqwY9WG3VWqJRBXyxyUFRqmPjvvr0LHy_EM_7ukMK0cd_fO_ZxpJTLKFynt_7m5q_FbuBjpzTgO XEPln4A-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Tue, 8 Nov 2022 03:04:37 +0000 Received: by hermes--production-gq1-579bc4bddd-kbwws (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d81503d1448fab94416c24e4438ba240; Tue, 08 Nov 2022 03:04:33 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Subject: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script From: Mark Millard In-Reply-To: Date: Mon, 7 Nov 2022 19:04:22 -0800 Cc: Alexander@leidinger.net, Li-Wen Hsu Content-Transfer-Encoding: quoted-printable Message-Id: <8DB9C862-3765-482E-A141-4B570ADEDA48@yahoo.com> References: To: Warner Losh , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3731.200.110.1.12) X-Rspamd-Queue-Id: 4N5tHW4Kn0z3hH2 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.49 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.993]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.148:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.148:from] X-ThisMailContainsUnwantedMimeParts: N On Nov 7, 2022, at 16:34, Mark Millard wrote: > Warner Losh wrote on > Date: Mon, 07 Nov 2022 21:23:11 UTC : >=20 >> On Mon, Nov 7, 2022 at 4:15 AM Alexander Leidinger = >> wrote: >>=20 >>>=20 >> . . . >>>=20 >>> And this brings me to a second topic, we don't have an explicit list >>> of features which are supported by the bootloader (I had a look at = the >>> zfs and the boot related man pages, if I overlooked a place, then = the >>> other places should reference this important part with some text). >>>=20 >>=20 >> There is a fixed list of features we support in the boot loader: >>=20 >> /* >> * List of ZFS features supported for read >> */ >> static const char *features_for_read[] =3D { >> "org.illumos:lz4_compress", >> "com.delphix:hole_birth", >> "com.delphix:extensible_dataset", >> "com.delphix:embedded_data", >> "org.open-zfs:large_blocks", >> "org.illumos:sha512", >> "org.illumos:skein", >> "org.zfsonlinux:large_dnode", >> "com.joyent:multi_vdev_crash_dump", >> "com.delphix:spacemap_histogram", >> "com.delphix:zpool_checkpoint", >> "com.delphix:spacemap_v2", >> "com.datto:encryption", >> "com.datto:bookmark_v2", >> "org.zfsonlinux:allocation_classes", >> "com.datto:resilver_defer", >> "com.delphix:device_removal", >> "com.delphix:obsolete_counts", >> "com.intel:allocation_classes", >> "org.freebsd:zstd_compress", >> "com.delphix:bookmark_written", >> "com.delphix:head_errlog", >=20 > As an example of a more general question > (referencing a zpool feature, if I understand > right): >=20 > com.delphix:head_errlog in the loaders from > 13.1-RELEASE? 13.1-RELEASE-p3? 12.3-RELEASE*? > (The future 12.4-RELEASE?) >=20 > head_errlog is an interesting example because of > "man zpool-features" reporting the below --and it > being fairly new: >=20 > "READ-ONLY COMPATIBLE no" > and: > "This feature becomes active as soon as it is enabled and will > never return to being enabled." >=20 > I guess the loader avoids types of read activity that cause the > more general "READ-ONLY COMPATIBLE no" status. >=20 > (I use the example just because I've indirectly > run into it before, but in a more limited context. > It may not be the best of examples for the general > question.) >=20 > Does each RELEASE and release-update get its own, > documented zpool feature list for its loaders? > (There might be a question for a zfs vs. zpool > feature distinction as well?) >=20 >> "org.openzfs:blake3", >> NULL >> }; >=20 > The overall list definitely goes beyond what is > listed in: >=20 > /usr/share/zfs/compatibility.d/openzfs-2.1-freebsd >=20 >> Any feature not on this list will cause the boot loader to reject the = pool. >>=20 >> Whether or not it should do that by default, always, or never is an = open >> question. I've thought there should be a 'shoot footing' override = that isn't >> there today. >=20 >=20 As I am not familiar with all the zpool features, I did some exploration. An FYI from it follows. (I originally built a list with things interlaced but the reordering made it more readable. The history explains some of the notation.) In openzfs-2.1-freebsd list but not in Warner's list: async_destroy : not in Warner's list bookmarks : not in Warner's list device_rebuild : not in Warner's list draid : not in Warner's list empty_bpobj : not in Warner's list enabled_txg : not in Warner's list filesystem_limits : not in Warner's list livelist : not in Warner's list log_spacemap : not in Warner's list project_quota : not in Warner's list redacted_datasets : not in Warner's list redaction_bookmarks : not in Warner's list userobj_accounting : not in Warner's list Not in openzfs-2.1-freebsd list but in Warner's list: not in openzfs-2.1-freebsd : com.delphix:head_errlog not in openzfs-2.1-freebsd : org.openzfs:blake3 =20 Not in openzfs-2.1-freebsd list nor in Warner's list: (These are listed in "man zpool-features", as are the rest of the various names listed.) edonr zilsaxattr In both openzfs-2.1-freebsd list and in Warner's list: allocation_classes : org.zfsonlinux:allocation_classes bookmark_v2 : com.datto:bookmark_v2 bookmark_written : com.delphix:bookmark_written device_removal : com.delphix:device_removal embedded_data : com.delphix:embedded_data encryption : com.datto:encryption extensible_dataset : com.delphix:extensible_dataset hole_birth : com.delphix:hole_birth large_blocks : org.open-zfs:large_blocks large_dnode : org.zfsonlinux:large_dnode lz4_compress : org.illumos:lz4_compress multi_vdev_crash_dump : com.joyent:multi_vdev_crash_dump obsolete_counts : com.delphix:obsolete_counts resilver_defer : com.datto:resilver_defer sha512 : org.illumos:sha512 skein : org.illumos:skein spacemap_histogram : com.delphix:spacemap_histogram spacemap_v2 : com.delphix:spacemap_v2 zpool_checkpoint : com.delphix:zpool_checkpoint =3D=3D=3D Mark Millard marklmi at yahoo.com