git: 72e9dbb58cad - main - if_bnxt: Remove sysctl node vlan_only which is not being used

The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=72e9dbb58cad5262190cf2eae47f764021072128

commit 72e9dbb58cad5262190cf2eae47f764021072128
Author:     Sumit Saxena <sumit.saxena@broadcom.com>
AuthorDate: 2022-11-04 22:26:03 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-11-04 22:26:03 +0000

    if_bnxt: Remove sysctl node vlan_only which is not being used
    
    Removed sysctl node vlan_only which is not being used after migrating
    from l2_set_rx_mask to l2_filter_alloc.
    
    Reviewed by: imp
    Differential Revsion: https://reviews.freebsd.org/D36444
---
 sys/dev/bnxt/bnxt.h        |  1 -
 sys/dev/bnxt/bnxt_sysctl.c | 38 +-------------------------------------
 2 files changed, 1 insertion(+), 38 deletions(-)

diff --git a/sys/dev/bnxt/bnxt.h b/sys/dev/bnxt/bnxt.h
index 4cf93f1c7eeb..f8f3f4ccc2f5 100644
--- a/sys/dev/bnxt/bnxt.h
+++ b/sys/dev/bnxt/bnxt.h
@@ -408,7 +408,6 @@ struct bnxt_vnic_info {
 	uint16_t	mru;
 
 	uint32_t	rx_mask;
-	bool		vlan_only;
 	struct iflib_dma_info mc_list;
 	int		mc_list_count;
 #define BNXT_MAX_MC_ADDRS		16
diff --git a/sys/dev/bnxt/bnxt_sysctl.c b/sys/dev/bnxt/bnxt_sysctl.c
index 36afed71a726..677dc2c1c0c1 100644
--- a/sys/dev/bnxt/bnxt_sysctl.c
+++ b/sys/dev/bnxt/bnxt_sysctl.c
@@ -36,7 +36,6 @@ __FBSDID("$FreeBSD$");
 #include "bnxt_hwrm.h"
 #include "bnxt_sysctl.h"
 
-static int bnxt_vlan_only_sysctl(SYSCTL_HANDLER_ARGS);
 /*
  * We want to create:
  * dev.bnxt.0.hwstats.txq0
@@ -1388,45 +1387,10 @@ bnxt_create_hw_lro_sysctls(struct bnxt_softc *softc)
 
 	return 0;
 }
-static int
-bnxt_vlan_only_sysctl(SYSCTL_HANDLER_ARGS) {
-	struct bnxt_softc *softc = arg1;
-	int rc;
-	int val;
-
-	if (softc == NULL)
-		return EBUSY;
-
-	val = softc->vnic_info.vlan_only;
-	rc = sysctl_handle_int(oidp, &val, 0, req);
-	if (rc || !req->newptr)
-		return rc;
-
-	if (val)
-		val = 1;
-
-	if (val != softc->vnic_info.vlan_only) {
-		softc->vnic_info.vlan_only = val;
-		if (if_getdrvflags(iflib_get_ifp(softc->ctx)) & IFF_DRV_RUNNING)
-			rc = bnxt_hwrm_cfa_l2_set_rx_mask(softc,
-			    &softc->vnic_info);
-	}
-
-	return rc;
-}
 
 int
 bnxt_create_config_sysctls_post(struct bnxt_softc *softc)
 {
-	struct sysctl_ctx_list *ctx = device_get_sysctl_ctx(softc->dev);
-	struct sysctl_oid_list *children;
-
-	children = SYSCTL_CHILDREN(device_get_sysctl_tree(softc->dev));
-
-	SYSCTL_ADD_PROC(ctx, children, OID_AUTO, "vlan_only",
-	    CTLTYPE_INT | CTLFLAG_RWTUN | CTLFLAG_MPSAFE, softc, 0,
-	    bnxt_vlan_only_sysctl, "I",
-	    "require vlan tag on received packets when vlan is enabled");
-
+	/* Nothing for now, meant for future expansion */
 	return 0;
 }