From nobody Sun May 15 17:50:27 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CF1751AE4F90; Sun, 15 May 2022 17:50:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L1VKH41g0z3rgj; Sun, 15 May 2022 17:50:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652637027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lBOQtTP6aXJLRaCJ2wbzVqsQp900LWbynefl9GnlkU0=; b=JdAvp5984bwSRCMYS0uF+ZHAK/NnyD6QgCi7YJy6IpNDmVVPH/czgUrOvJ3y2uCwUgydEv 2Qpxqu9HdcXSn2fX+4Sv3/u4U21Mu7nyTMvtkQW192kJ/EaLatxVrLof1HWn4OSCo7C2+B Eh7Yw72fDDkXS/sqi9WJ8rBTxrCkhxCSAwcqelaiC6lOF25O+mkjUfx1/R6oa0mpVlC1Nw lkz7W0dsrLnIk4dJNZeewv/8mE0KUNSxXzYTqbwcnZ/qZ4jUgZwO+lfEh/2fD1o/wOtRD+ CUY0m6AxeiXnlNYaYytfa/YUTsvdK6ga/jJ8G71L7JSWxzSXRgT2h/KB+fjFhw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 65854106EC; Sun, 15 May 2022 17:50:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 24FHoRVL050375; Sun, 15 May 2022 17:50:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 24FHoRer050374; Sun, 15 May 2022 17:50:27 GMT (envelope-from git) Date: Sun, 15 May 2022 17:50:27 GMT Message-Id: <202205151750.24FHoRer050374@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dmitry Chagin Subject: git: 3bae1cd68a2a - main - linux(4): Implement futex_op for arm64. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3bae1cd68a2ac3e2c37d54cf550e01257dfb1a04 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652637027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lBOQtTP6aXJLRaCJ2wbzVqsQp900LWbynefl9GnlkU0=; b=LH7XseUhJ1xgAqDQOEiuw2VAFSMdOJzzF3x3B3muRDrinMwzDn/nqAVBsDIdSfhNu7W4Is 18iFmyH8hU0j9F/h1pihSx+c9cu0xQD5BLj9d0plhCzQDpC4koFT4XjLSxw0dZ3tKsvXwH 7+kXHv/ij7h1boBdMjSylhdb+1V1KIT8l+EMexlhQUXPl6bBlMasIje4gW6dXCrHGJuwK3 1T3PSiS/1bjqEl8QnnJzS/Vj9JhlJvukrCRG78P766Xb4er4T578XkoeyXTPUzvt+LQ32X XnZ2q5wAFbljmAXIflePcJvaja603NxH/7kEYNNI64eloMOJ7l3L56oXFjLt/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652637027; a=rsa-sha256; cv=none; b=B+QsXElg1meO5IxM2xdGfSLu8JaW/9WIfajjwm9kDABlC4gA6J/d2k2tGSxNAgKmBH/a+X KwuIMDs7O8rarzMYROYpqDMEnVjQaDIIqqiF9MP/rga2UK5Wcw7yDvOH7GiPTqrsdyRElx SSAuOQnr4sEo9mV4st6r9psGNovc6kyPzussMPXCuT59HK/RCO/sZN4pf68S1dWLB3iqKS L2Eu3o1Pi1nmtYEBJQELQROjTpXUg4MOLZRmHMB0ZlvEIdHnnhpTFFmP1g/8n5TrtewS8u jzYZRBNeYm9gYkDVyMJUQa0QRtJRde/g7BT6QfqErGAh6dODjoWNOoiNCEmb6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=3bae1cd68a2ac3e2c37d54cf550e01257dfb1a04 commit 3bae1cd68a2ac3e2c37d54cf550e01257dfb1a04 Author: Dmitry Chagin AuthorDate: 2022-05-15 17:49:42 +0000 Commit: Dmitry Chagin CommitDate: 2022-05-15 17:49:42 +0000 linux(4): Implement futex_op for arm64. It's mostly modeled like the Linux does. Differential revision: https://reviews.freebsd.org/D35154 MFC after: 2 weeks --- sys/arm64/linux/linux_support.s | 130 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 123 insertions(+), 7 deletions(-) diff --git a/sys/arm64/linux/linux_support.s b/sys/arm64/linux/linux_support.s index 1048e9579627..933930b5096f 100644 --- a/sys/arm64/linux/linux_support.s +++ b/sys/arm64/linux/linux_support.s @@ -2,6 +2,7 @@ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD * * Copyright (C) 2018 Turing Robotic Industries Inc. + * Copyright (C) 2022 Dmitry Chagin * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -27,36 +28,151 @@ * $FreeBSD$ */ -#include "linux_assym.h" #include +__FBSDID("$FreeBSD$"); + +#include +#include + +#include #include "assym.inc" +.macro check_user_access user_arg, limit, bad_addr_func + ldr x7, =(\limit) + cmp x\user_arg, x7 + b.cs \bad_addr_func +.endm + +futex_fault: + SET_FAULT_HANDLER(xzr, x1) + EXIT_USER_ACCESS_CHECK(w0, x1) +futex_fault_nopcb: + mov x0, #EFAULT + ret + +#define LINUX_FUTEX_MAX_LOOPS 128 + /* - * LINUXTODO: implement futex_* + * int oparg, uint32_t *uaddr, int *oldval + * + * Return 0 on success, errno on failure, + * EAGAIN is returned if LL/SC operation fails. + * + * XXX. VM_MAXUSER_ADDRESS is not applicable here, should be replaced + * by something like LINUX_SHAREDPAGE. */ +/* (int *)uaddr2 = oparg */ ENTRY(futex_xchgl) - brk #0 + check_user_access 1, (VM_MAXUSER_ADDRESS-3), futex_fault_nopcb + adr x9, futex_fault /* Load the fault handler */ + SET_FAULT_HANDLER(x9, x4) /* And set it */ + ENTER_USER_ACCESS(w9, x4) + mov w5, #LINUX_FUTEX_MAX_LOOPS + prfm pstl1strm, [x1] + mov w6, w0 /* Save oparg */ +1: ldxr w4, [x1] /* Load oldval from uaddr */ + stlxr w0, w6, [x1] /* Store oparg to uaddr */ + cbz w0, 3f /* Exit on success */ + sub w5, w5, w0 /* Dec loop counter, w0 is 1 */ + cbnz w5, 1b /* Loop */ + mov x0, #EAGAIN /* Store of newval failed */ +3: dmb ish + EXIT_USER_ACCESS(w9) + SET_FAULT_HANDLER(xzr, x9) /* Reset the fault handler */ + str w4, [x2] /* Store oldval */ ret END(futex_xchgl) +/* (int *)uaddr2 += oparg */ ENTRY(futex_addl) - brk #0 + check_user_access 1, (VM_MAXUSER_ADDRESS-3), futex_fault_nopcb + adr x9, futex_fault + SET_FAULT_HANDLER(x9, x4) + ENTER_USER_ACCESS(w9, x4) + mov w5, #LINUX_FUTEX_MAX_LOOPS + prfm pstl1strm, [x1] + mov w6, w0 +1: ldxr w4, [x1] + add w3, w4, w6 /* oldval + oparg */ + stlxr w0, w3, [x1] + cbz w0, 3f + sub w5, w5, w0 + cbnz w5, 1b + mov x0, #EAGAIN +3: dmb ish + EXIT_USER_ACCESS(w9) + SET_FAULT_HANDLER(xzr, x9) + str w4, [x2] ret END(futex_addl) +/* (int *)uaddr2 |= oparg */ ENTRY(futex_orl) - brk #0 + check_user_access 1, (VM_MAXUSER_ADDRESS-3), futex_fault_nopcb + adr x9, futex_fault + SET_FAULT_HANDLER(x9, x4) + ENTER_USER_ACCESS(w9, x4) + mov w5, #LINUX_FUTEX_MAX_LOOPS + prfm pstl1strm, [x1] + mov w6, w0 +1: ldxr w4, [x1] + orr w3, w4, w6 /* oldavl |= oparg */ + stlxr w0, w3, [x1] + cbz w0, 3f + sub w5, w5, w0 + cbnz w5, 1b + mov x0, #EAGAIN +3: dmb ish + EXIT_USER_ACCESS(w9) + SET_FAULT_HANDLER(xzr, x9) + str w4, [x2] ret END(futex_orl) +/* (int *)uaddr2 &= oparg */ ENTRY(futex_andl) - brk #0 + check_user_access 1, (VM_MAXUSER_ADDRESS-3), futex_fault_nopcb + adr x9, futex_fault + SET_FAULT_HANDLER(x9, x4) + ENTER_USER_ACCESS(w9, x4) + mov w5, #LINUX_FUTEX_MAX_LOOPS + prfm pstl1strm, [x1] + mov w6, w0 +1: ldxr w4, [x1] + and w3, w4, w6 /* oldval &= oparg */ + stlxr w0, w3, [x1] + cbz w0, 3f + sub w5, w5, w0 + cbnz w5, 1b + mov x0, #EAGAIN +3: dmb ish + EXIT_USER_ACCESS(w9) + SET_FAULT_HANDLER(xzr, x9) + str w4, [x2] ret END(futex_andl) +/* (int *)uaddr2 ^= oparg */ ENTRY(futex_xorl) - brk #0 + check_user_access 1, (VM_MAXUSER_ADDRESS-3), futex_fault_nopcb + adr x9, futex_fault + SET_FAULT_HANDLER(x9, x4) + ENTER_USER_ACCESS(w9, x4) + mov w5, #LINUX_FUTEX_MAX_LOOPS + prfm pstl1strm, [x1] + mov w6, w0 +1: ldxr w4, [x1] + eor w3, w4, w6 /* oldval ^= oparg */ + stlxr w0, w3, [x1] + cbz w0, 3f + sub w5, w5, w0 + cbnz w5, 1b + mov x0, #EAGAIN +3: dmb ish + EXIT_USER_ACCESS(w9) + SET_FAULT_HANDLER(xzr, x9) + str w4, [x2] ret END(futex_xorl)