git: 2e4e5ee23ffb - main - sockets: delete stale comment from sofree()
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 12 May 2022 18:03:06 UTC
The branch main has been updated by glebius:
URL: https://cgit.FreeBSD.org/src/commit/?id=2e4e5ee23ffb6d159140d740499f17530e696865
commit 2e4e5ee23ffb6d159140d740499f17530e696865
Author: Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2022-05-12 18:02:50 +0000
Commit: Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2022-05-12 18:02:50 +0000
sockets: delete stale comment from sofree()
First paragraph refers to old past "we used to" and is no longer
important today. Second paragraph has just a wrong statement that
socket buffer is destroyed before pru_detach.
---
sys/kern/uipc_socket.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/sys/kern/uipc_socket.c b/sys/kern/uipc_socket.c
index 2989d53c223e..628730171715 100644
--- a/sys/kern/uipc_socket.c
+++ b/sys/kern/uipc_socket.c
@@ -1206,15 +1206,6 @@ sofree(struct socket *so)
* From this point on, we assume that no other references to this
* socket exist anywhere else in the stack. Therefore, no locks need
* to be acquired or held.
- *
- * We used to do a lot of socket buffer and socket locking here, as
- * well as invoke sorflush() and perform wakeups. The direct call to
- * dom_dispose() and sbdestroy() are an inlining of what was
- * necessary from sorflush().
- *
- * Notice that the socket buffer and kqueue state are torn down
- * before calling pru_detach. This means that protocols shold not
- * assume they can perform socket wakeups, etc, in their detach code.
*/
if (!SOLISTENING(so)) {
sbdestroy(&so->so_snd, so);