From nobody Tue May 03 06:40:09 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C399C1AC26CF; Tue, 3 May 2022 06:40:13 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ksr1S478Rz3LcY; Tue, 3 May 2022 06:40:12 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from [10.36.2.165] (unknown [176.74.213.87]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id D2F2A2604FB; Tue, 3 May 2022 08:40:10 +0200 (CEST) Message-ID: Date: Tue, 3 May 2022 08:40:09 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: git: cda31e734925 - main - xhci(4): Ensure the so-called data toggle gets properly reset. Content-Language: en-US To: Nathan Whitehorn , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202204211502.23LF2g2L010181@gitrepo.freebsd.org> <7af2c933-c907-6da0-1ea2-5e9afba50f78@freebsd.org> From: Hans Petter Selasky In-Reply-To: <7af2c933-c907-6da0-1ea2-5e9afba50f78@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Ksr1S478Rz3LcY X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 88.99.82.50 is neither permitted nor denied by domain of hselasky@freebsd.org) smtp.mailfrom=hselasky@freebsd.org X-Spamd-Result: default: False [-2.20 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[hselasky]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; NEURAL_HAM_MEDIUM(-0.11)[-0.109]; NEURAL_HAM_SHORT(-0.99)[-0.995]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 5/3/22 00:25, Nathan Whitehorn wrote: > After this change, I cannot use devices attached to the USB 3 hub in my > Dell monitor anymore. The hub appears properly, but any device plugged > into it just leaves this in dmesg: > ugen0.3: at usbus0 (disconnected) > > Note that there is no corresponding connected message or anything else. > > This is with an AMD XHCI controller: > xhci0@pci0:2:0:0:       class=0x0c0330 rev=0x02 hdr=0x00 vendor=0x1022 > device=0x43bb subvendor=0x1b21 subdevice=0x1142 >     vendor     = 'Advanced Micro Devices, Inc. [AMD]' >     device     = '300 Series Chipset USB 3.1 xHCI Controller' > Hi Nathan, There is an ongoing discussion at (where you may upload USB debug logs from the XHCI controller). https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262882 Can you try to "usbreset -d ugenX.Y" where ugenX.Y corresponds to the address of the parent USB HUB for these devices. Do the devices come back? I'm currently mostly testing on Intel chipsets, and don't see any such issues! I believe the patch is correct, but maybe needs to be adapted to AMD's XHCI controllers. --HPS