From nobody Thu Mar 31 19:26:12 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0C50E1A492B3; Thu, 31 Mar 2022 19:26:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KTtZX6SpKz3lfx; Thu, 31 Mar 2022 19:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648754772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3ztNlGjn7mJbnhwUyq0TjpOZAWmbHzw55GCTo5F9U2c=; b=BM4tIVDcx+fbAUxeukrNHEtIDEvNQotXRemV9qklNF0jsSItJVCJ5LyrdPLpEv0dkB9oJI 7PSGKMPCDP3cMXlABUPMF1SQZOIdanStkeWaqZlrlWRmU+DhqxlIyWJDfSUuKSQedNgWbw PAWaz+AGrBhbuy9WIV0dNc09NrPlLJGKi0aZSIqgIZMUUZG8cpqrpJ85k8CjB1wUh/IJkf SU7QLoakdxeA+goLMP2Ml7gbrJ+wdNyJlW+rAo/uTkykADQY/x9qmvGMPktIp3xQUzYa7R TyrOMTXmqqvEfYalNyzVx5Eh9lxqpnHusHAyt+gJ7MUCz96p5RumFv9g6wc91g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BE2A62D9D2; Thu, 31 Mar 2022 19:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22VJQCxf066643; Thu, 31 Mar 2022 19:26:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22VJQCXx066642; Thu, 31 Mar 2022 19:26:12 GMT (envelope-from git) Date: Thu, 31 Mar 2022 19:26:12 GMT Message-Id: <202203311926.22VJQCXx066642@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 31190aa02eef - main - libbe: pull props for the correct dataset in be_mounted_at() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 31190aa02eef05b1b58ba89212dc8c8738770e37 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648754772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3ztNlGjn7mJbnhwUyq0TjpOZAWmbHzw55GCTo5F9U2c=; b=Ch+7lx2/DHc+S2cWUKzcU2fXxoEBx+g5CLkYD+PyghQvG1/bF+AY5vyEjYv4bmdqfK5r8P mtXAfe78+bNwcNdv6X77TAG3dyuJpg668SHzczgH4flKj57cvp4Jbx7zUMwZWVsgxzSmOM MWuHDw/ndZO38ZgdJ+ihbrW1/uMSXQbuylKsSzpIqyihOF5Mlr9HgfdmvM22ybOLqcpo15 35wVVxJunaOmQO3iCHnuB8t6ZZfe0zBjca2I/WH4mSkL0QsFZEv6npQQWsHJuMyIA9cigP a3PXcpxc+HICUtAZoIjii5HoVbSMqDD8ETr1Z+//tcanVM/F4W+I16lMJp67ng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648754772; a=rsa-sha256; cv=none; b=R93cAK3+Lq4xAUGTEnOjhIQWvOoA57aODZQ75fDdBW/Fv3mUtvjLq80ka+uBmis21zFPhT vjVnn9dSLTHq7qTajoriEaiZCSaJ4jJ0QFoKMcNrsUjLDsunX6hJdBzOnvMApZXoOod295 jl1vi3iiOF3Wq4qzMVOiOr8tGQIADvRpkApuZggrKhIS8kOWf4q3pG5001/9PTCMaxQRlR iEjnzWZaaeLN3HMdHYAVWoauA1fnZ3JR7lyY6DmfQ3czv+PMxGw9QoqqshTnlqSwaOj2mV wnYssDcFDrRSrXJp+qDT9i1QPxkEBJIDOFNgbs/fcqdcMYqIFe5jCd4VKVcK7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=31190aa02eef05b1b58ba89212dc8c8738770e37 commit 31190aa02eef05b1b58ba89212dc8c8738770e37 Author: Kyle Evans AuthorDate: 2022-03-31 19:19:52 +0000 Commit: Kyle Evans CommitDate: 2022-03-31 19:23:57 +0000 libbe: pull props for the correct dataset in be_mounted_at() The props feature to this API was added as a "just in case", with no planned consumer. It turns out that it was implemented incorrectly, tapping out props for the BE root (BE's parent) rather than the BE itself in all cases. Fetch properties for the dataset that's actually mounted at the queried path. Reported by: Christian McDonald MFC after: 3 days --- lib/libbe/be_access.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libbe/be_access.c b/lib/libbe/be_access.c index a591a4f61d02..ec966bc85fb7 100644 --- a/lib/libbe/be_access.c +++ b/lib/libbe/be_access.c @@ -210,7 +210,7 @@ be_mounted_at(libbe_handle_t *lbh, const char *path, nvlist_t *details) if (info.name != NULL) { if (details != NULL) { - if ((root_hdl = zfs_open(lbh->lzh, lbh->root, + if ((root_hdl = zfs_open(lbh->lzh, info.name, ZFS_TYPE_FILESYSTEM)) == NULL) { free(info.name); return (BE_ERR_ZFSOPEN);