From nobody Thu Mar 31 19:26:11 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D2F801A49132; Thu, 31 Mar 2022 19:26:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KTtZW5ZFYz3lLj; Thu, 31 Mar 2022 19:26:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648754771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5fcajR5ug+/PzZn2xMuW1cwMKMrUSem0oO1jf2/H4ps=; b=lbZgWTfuqozuqlf31b+pqYMhP/0vRWs/7bU1+KSRpLD5nPxu5Xhvx+bFh7AaRkNcbGG4Qb t/I2ds34qyyKG4sF0yIphUVsT9uUVH9dqOO2+DS9NEqW/Jh7TpfOblJ8Avs25IPeQlX/lz XimviuddyW/XAvEAnYiSzoQkCh2OnxBBdaGl7U642I6FrLUZzFilgClKDJc6a7/YuZJlYj zv+ccUEeEnzLb4t2wxMHMz561wkFRPBjdWrA0Bt3kSf1pPkOfkekijOzIX+qhVuYvr0/bL UsNj/eYJWxLxrFAUa0Rph60bfFme17WjF1XCpmRZqmfkDJprv06u+mh9JTSsvQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9EAC02D7AF; Thu, 31 Mar 2022 19:26:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22VJQBOd066616; Thu, 31 Mar 2022 19:26:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22VJQBrF066614; Thu, 31 Mar 2022 19:26:11 GMT (envelope-from git) Date: Thu, 31 Mar 2022 19:26:11 GMT Message-Id: <202203311926.22VJQBrF066614@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: d155d8e13856 - main - libbe: fix be_mounted_at() with props after bootonce List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d155d8e138563c0b39c658684e6a4fe6e2e36f8a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648754771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5fcajR5ug+/PzZn2xMuW1cwMKMrUSem0oO1jf2/H4ps=; b=QXe9mqBgqTj1HpacYF+LN75ZXii3f0Kdacbgjy5d3ZxMQRnLWyd8xkwL5lWEd4o5ZU67QE DLI16SxVKVP6pgHx5i1EzHpQEg3nyiz5UJQ4Iur4kacGpCP6rAiL8rIFM3NO0rf7zYeK7I ORJ07nifZgAL2gHxexuyaIBubC9vEmuYpWwNxkIrYXFEO0P1H7uYCOMIQuWkFGtasUP7IR qTYGwpvH2Ah2rk+jl0vQ5itQ8fOvTHfNlvFFoCmEWK9on6Lh9jAqervhW/UjQX5iWcn3VG llH+QLTrPXNL5BkYLCvLnrKt5llcCsUqBuQ43eGRflNsEobNT+cmNsx/yqc01w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648754771; a=rsa-sha256; cv=none; b=EInK+v1tEdhnIxXyMt35IIuT0VYMTqGzx4GQjLqbru63JKhupQx2vgUeyobOQedfiBYz8X wRhmdooiU3qIl5sqXnLGJrBuwwCQAgDGzXiFUjL1NWC8cbaEuqXqZ5XVAaTyySdC+TUq1O /EeHtdmtlYO0+dJZM9+Jg1Dv3n1Rpub8i8UBmTADx6Llmt8InQWno8g/a3xCmLn+VXq3NU dTKXajxITN52bU1QbBw/XNGv5bSobyU+xecrv2nS6E/OO4vZgLX2mXAqqbX6cdZJPMWfxA uQV4TYRhNhl+9Edf/8Jr6C2T/2k3nzsRRz0PIiAJ/afVPXiLQXM62E//xVWGtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=d155d8e138563c0b39c658684e6a4fe6e2e36f8a commit d155d8e138563c0b39c658684e6a4fe6e2e36f8a Author: Kyle Evans AuthorDate: 2022-03-31 19:18:14 +0000 Commit: Kyle Evans CommitDate: 2022-03-31 19:23:57 +0000 libbe: fix be_mounted_at() with props after bootonce propinfo.bootonce was filled with garbage, leading to a segfault later during prop building. Initialize it to NULL. MFC after: 3 days --- lib/libbe/be_access.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/libbe/be_access.c b/lib/libbe/be_access.c index 74059a0a5693..a591a4f61d02 100644 --- a/lib/libbe/be_access.c +++ b/lib/libbe/be_access.c @@ -219,6 +219,7 @@ be_mounted_at(libbe_handle_t *lbh, const char *path, nvlist_t *details) propinfo.lbh = lbh; propinfo.list = details; propinfo.single_object = false; + propinfo.bootonce = NULL; prop_list_builder_cb(root_hdl, &propinfo); zfs_close(root_hdl); }