From nobody Mon Mar 28 15:24:13 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0704F1A303EC; Mon, 28 Mar 2022 15:24:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KRxLj6S0Pz3Ngw; Mon, 28 Mar 2022 15:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648481053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FUil3k5b2Jqihx+EZvuoT3Cu+VXS7X/L8KvTpjhnMEw=; b=ppiyHZMPvYQtWf36Tobxdyb1F9hanIvELJLeWNd6e/ltuvgGDH5MJAWAxkNq9Z7+2xwxGI pEkvaeVyHbVH34oQfazU9XLY25IcEPTLBNu5blDr6z1vaUf5k5Afng9h1SZchG+1KoNLUv ZiSXPIq7MsPiKrm7Zy32KRx/X5mkhE8p/4dHQJXG+MTTUIX6YLvU7WTbS5sP7FdwBPO4G5 J2KchPpz3BylGZG5S5+N0RAa6SDfYwXdNDS3Ukz3XkV3o7wiyIIIbg0tBiBiAlnwwVjxkb OZZmSR3Ech8ABStWI11LPjh5uhb2f94dwTS77ZLWqmM42W2SwYy2Uov66Rx3Pw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BDBCC3BB6; Mon, 28 Mar 2022 15:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22SFODk8086474; Mon, 28 Mar 2022 15:24:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22SFOD4J086473; Mon, 28 Mar 2022 15:24:13 GMT (envelope-from git) Date: Mon, 28 Mar 2022 15:24:13 GMT Message-Id: <202203281524.22SFOD4J086473@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: ecd764b0ea7a - main - audit: Initialize vattr fields before calling VOP_GETATTR List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ecd764b0ea7a1b7fb5f1e6632f8d8db9233f06ea Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648481053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FUil3k5b2Jqihx+EZvuoT3Cu+VXS7X/L8KvTpjhnMEw=; b=j0g8LcYMewRbUdw/eJdeKvOXa1TcogdPqcHJy4UUOEXjxCsGAqG3DQlvIsZenGnYYnSl0G deDFOvV1/5x1pepH/uesCoqsxHsyfUfKbvHM1JJNIY6jozea2k1xbQT2LmrzjAgdJptCj+ mslLP7Dg8T5ah6U/01CThzFqPl2o8+2porDA821xmgpHiN+DyRRRt2oa7i6UMxIu3yZ5Qr GmWkRtpTeHBhL3USTX6EYyCcLNWCS/eg+GCGri3uUw/nAgA4J8+Xa8/lYfNYwQx3pMJj0K ct1luxd5NsGZBBDIeljboP70jtyLeHhQhB46FmOiCjwgTMKPpwSHxX8EezA5pA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648481053; a=rsa-sha256; cv=none; b=BNp+i86NFIjh601sLRICQATNChhcZj8Iu2xnhdsbhwSTrnFuWo/qtIGMgJPxyrftJ29gZi TBowbJgH4VqjDahKTk08hqs5xFOdWgqAKZ88EehZW80Ey3R6nB4opwEeskAeftb9RRQG5x Q6sqeLpnKGnwJTBiOjP3wiI2bmIMYLJPHb4xN5kmy15Zo78/Jn4cxU44AdkQJyvRWuIBU9 Jee7HH3/C09Ji0qe7OMTaTYYbUoQTTNjCOq4k+krs39VFgE3OtvXLX6sKLQyvcxu4KBBJL 2PsShVtsa77M5pJBAfx5pRIOeAGMxWsrSKMW9Xs8dxc3P+8M/PQLDMOKksd/nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=ecd764b0ea7a1b7fb5f1e6632f8d8db9233f06ea commit ecd764b0ea7a1b7fb5f1e6632f8d8db9233f06ea Author: Mark Johnston AuthorDate: 2022-03-20 01:59:13 +0000 Commit: Mark Johnston CommitDate: 2022-03-28 15:23:45 +0000 audit: Initialize vattr fields before calling VOP_GETATTR Some filesystems do not fill out certain optional vattr fields. To ensure that they do not get copied out to userspace uninitialized, use VATTR_NULL to provide default values. Reported by: KMSAN MFC after: 2 weeks Sponsored by: The FreeBSD Foundation --- sys/security/audit/audit_arg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/security/audit/audit_arg.c b/sys/security/audit/audit_arg.c index a917b5b6e297..7e0b0de2abff 100644 --- a/sys/security/audit/audit_arg.c +++ b/sys/security/audit/audit_arg.c @@ -873,6 +873,7 @@ audit_arg_vnode(struct vnode *vp, struct vnode_au_info *vnp) ASSERT_VOP_LOCKED(vp, "audit_arg_vnode"); + VATTR_NULL(&vattr); error = VOP_GETATTR(vp, &vattr, curthread->td_ucred); if (error) { /* XXX: How to handle this case? */