From nobody Fri Mar 25 17:00:44 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 428F61A282A1; Fri, 25 Mar 2022 17:00:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KQ7dT1Q01z3j0s; Fri, 25 Mar 2022 17:00:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648227645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cMDbwwMD4Ktr0qFfWu9M4VtdgECS8EQAkqDBmc0H4UQ=; b=SsdV7rpavgQIfAtQQQYCCdpFtfDK1hkKkQQ1rKBcS8+DohHKgGsPes8PB2dEzMAA4IdF+4 gw7P0HIUQqJMUdHl6gGM5SLah/rHA0ruEtEHSuOX3f0bu7Jaqnaw2tA5nAko+bwMAZIRkc CrkQfjGXewrcnzXhIpQG6AXyWTnjEaq9R6zNIL7ZWX3K8gHt2muec55mO3L/9UAwAclmv3 MC9MHxNX1/DgddLCi5Q9F6cJAxjQyn2+Eo0bRu9B6EOOnKdum18jddtRDolbAmwOdrZe1u 3fzDMoKNzovtfvk9kK46O9FpSl3Xs5jUIBAI1o96x92bnm2vUb5rwUSyE2PEJw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1125F10653; Fri, 25 Mar 2022 17:00:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22PH0iKi097662; Fri, 25 Mar 2022 17:00:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22PH0i2E097661; Fri, 25 Mar 2022 17:00:44 GMT (envelope-from git) Date: Fri, 25 Mar 2022 17:00:44 GMT Message-Id: <202203251700.22PH0i2E097661@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: b234b8d911cd - main - arm: Zero padding in mcontext_vfp_t in get_vfpcontext(). List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b234b8d911cdb4fe53032fde0cb8611ae9d0b81d Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648227645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cMDbwwMD4Ktr0qFfWu9M4VtdgECS8EQAkqDBmc0H4UQ=; b=eQpiSUeB5vrWI4UP3kUxFA2wZaIN8pGD/Qli7ryesmh8dFstcivX775pE6OX+e2j0mJHMk wfJqvJdLlrC0cJLFQXc8vG5EON+uB4PVBK4xYvOHuCa/2zHZIk44Muew8Qn58U0NZpT1LS pyQnORsvwzB38QDpb16iU2dOzbLIgXj4bkGfc/XMXSf4xqxakxO4yv0Kp7Mq7DrYS+5Kgz XuGsUaIQt2dYDJdfrdWkwcZixzuTsGtgpfIkaSdiP574CmsCDNmuJaFp8wlLWeCHpbry75 X1VLNUcw5LkHL2mSvHSxoOrQmOCE0Pxa57ORwLlUDHJ7S62UWpedyTrBO2N4LQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648227645; a=rsa-sha256; cv=none; b=tnHgS5PwP6hSeH4D57O6+86mwUvjC7eXV1SdhFsOuTulaS0yVwiOqyYYfnmYPuVY5jVvWY sCT5I9rskxcthpkAepqS2Tr4sdZY2b5qLu821V/zNqI8HxfA/U7NJV8ZyPIwtEIcHsmBGa V/3ppfGsag9bnhwsUvJSrcw8MxdHkf/vRBd91XTQFALMc1zg7DBPuH9ofCzxlPDMO7H15I oALpXkwadmY27lAN1qXzw12dtobsXqBoHvTiaifJBIlkxaFWbrUmUwBEU1s+ynNUNT7fcN XWH/NBf59ELTf0u4s4T5cjCMauV3A2bhbJP87H5OIIpEVJiwItw/PcSRCaJm+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=b234b8d911cdb4fe53032fde0cb8611ae9d0b81d commit b234b8d911cdb4fe53032fde0cb8611ae9d0b81d Author: John Baldwin AuthorDate: 2022-03-25 16:57:20 +0000 Commit: John Baldwin CommitDate: 2022-03-25 16:57:20 +0000 arm: Zero padding in mcontext_vfp_t in get_vfpcontext(). This can leak kernel stack data otherwise. Reviewed by: imp, markj Sponsored by: The University of Cambridge, Google, Inc. Differential Revision: https://reviews.freebsd.org/D34594 --- sys/arm/arm/exec_machdep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/arm/arm/exec_machdep.c b/sys/arm/arm/exec_machdep.c index fdd57d7859c5..16c43e3a14fe 100644 --- a/sys/arm/arm/exec_machdep.c +++ b/sys/arm/arm/exec_machdep.c @@ -107,6 +107,7 @@ get_vfpcontext(struct thread *td, mcontext_vfp_t *vfp) critical_exit(); } else MPASS(TD_IS_SUSPENDED(td)); + memset(vfp, 0, sizeof(*vfp)); memcpy(vfp->mcv_reg, pcb->pcb_vfpstate.reg, sizeof(vfp->mcv_reg)); vfp->mcv_fpscr = pcb->pcb_vfpstate.fpscr;