From nobody Fri Mar 25 16:49:47 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 66C0B1A252C2; Fri, 25 Mar 2022 16:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KQ7Nr26jsz3PrC; Fri, 25 Mar 2022 16:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648226988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W7z2rRvMgVOWZSeejWM9RIH4EKg7VMzTCOLFkK/v1FQ=; b=h0OgD1vaIbjY85xjk4NloGlytO/f+OfolL00hJTnscCxxI0YVCUr0NhwSZX/cNnPuGvrIH OJUcDAG2PitumYXUSeMc+yXOU8/aK7o+Gu5bcHynRy+ekM7H5pMHf27qrjWs6fyff7O1lv BQPKg50wH+ZngLSGzm0kP3vdglarfPriiQpgg/7OGFnaZPamVl/u4FlkC7FlVwClWx3rCm PRYMgbtku3DzWj3i6Xc8Bk0xC+1GEIInlNLq+lytTwLIFR7wdz2dE4vliodiK3wwBZ6+NU szNyZAdTD/yVhR4buHir9yyBkBLUKDM4EVY7iZ4ZpKQVcB6fepZnZ/i5TjXR5w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2293D7D55; Fri, 25 Mar 2022 16:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22PGnlBU075283; Fri, 25 Mar 2022 16:49:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22PGnlD9075282; Fri, 25 Mar 2022 16:49:47 GMT (envelope-from git) Date: Fri, 25 Mar 2022 16:49:47 GMT Message-Id: <202203251649.22PGnlD9075282@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: D Scott Phillips Subject: git: 7be7bd677585 - main - arm64: Add explicit barrier after address translation instruction List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: scottph X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7be7bd67758520ea2f9784a81ad244e99a7632f0 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648226988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W7z2rRvMgVOWZSeejWM9RIH4EKg7VMzTCOLFkK/v1FQ=; b=lgodDqD0521GzmB7Jnp0EfGPF0FNsJFUqfwhhMTKnTuZVUNoSip0QYDtxXY7CMRDI5mDQb N9fCEaGJc8wAkli25WgZjx5COwSh7oMbuf9ekAiluEpo91KpneeYYygQRHlnPWSFNj8Tso DyU35eIh7E0EXAsnD/xGYV5/4OaIuiwamvmd38dwFRdPfj6kidkuVbTLMcXoMGcK5hexY5 6H8/PN9TQpRoLF8IkLgYXzJgww5xoEY7sS12XB17XCaowI+QrdXYpW2Htf2B8NPWO07jPf KzQJQ3N1bwNUTGCLyUiKxRHj9WqzxtnG0iKcFXmFV9BHK8e+mR1461B24jnJZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648226988; a=rsa-sha256; cv=none; b=VDMnhlCuNvI231NThBR2X4fTvY3QaOmo/4UHhtW3ag7utOw+4VWcTknwOnqDuAC0pePls+ ZsII9sjSFtefayEoJ9pBo24lOp62TPt3w7eY3fcAGHGRHm0KA6x7CWMnlRxNqakGZzbYES 4KPl/X/EbRRcCeP6VFUsQtviaCbyNbyrCNVoxVbvb2BWfh++thkMaqVzcADXE+5W3gGweN s7cXbIUmUtej/pk+XB+cO0RDkNaQcwMleOpQLU6oGmUNpnxU7puSIqCCM4TqaN4cge8jpD fkldZjk+J6EgwQ0SOUBIrrWSt3rYKeo+KQ7bHq+52c+QTJWah3UmgmfgvfTtrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by scottph: URL: https://cgit.FreeBSD.org/src/commit/?id=7be7bd67758520ea2f9784a81ad244e99a7632f0 commit 7be7bd67758520ea2f9784a81ad244e99a7632f0 Author: D Scott Phillips AuthorDate: 2022-03-25 16:04:47 +0000 Commit: D Scott Phillips CommitDate: 2022-03-25 16:49:33 +0000 arm64: Add explicit barrier after address translation instruction Following ARMARM sec D5.2.11, which says: > Where an instruction results in an update to a System register, > as is the case with the AT * address translation instructions, > explicit synchronization must be performed before the result is > guaranteed to be visible to subsequent direct reads of the > PAR_EL1. Reviewed By: andrew MFC after: 3 weeks Sponsored by: Ampere Computing Differential Revision: https://reviews.freebsd.org/D34665 --- sys/arm64/include/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/arm64/include/cpu.h b/sys/arm64/include/cpu.h index d3b13470a9be..7659874e9bb4 100644 --- a/sys/arm64/include/cpu.h +++ b/sys/arm64/include/cpu.h @@ -222,7 +222,8 @@ arm64_address_translate_ ##stage (uint64_t addr) \ uint64_t ret; \ \ __asm __volatile( \ - "at " __STRING(stage) ", %1 \n" \ + "at " __STRING(stage) ", %1 \n" \ + "isb \n" \ "mrs %0, par_el1" : "=r"(ret) : "r"(addr)); \ \ return (ret); \