From nobody Wed Mar 23 20:33:20 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A1E901A29ED0; Wed, 23 Mar 2022 20:33:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KP0Rh4P5wz4g6d; Wed, 23 Mar 2022 20:33:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648067600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hK1N9xNNQs/jtfTSAuX6Bwta5hubad5jiv/h1ou8dCs=; b=L/gY9hRZCsDURR2x3kQCB2Wr2mE318KnPnY8VgC43bNsW4E3TbPVzDgTbkKjoMkx92I81q vDtu6Qm0zJrYvr7+Lzdu0Vdnw5p8uVtPSduV8ajIIg4AGSbTmHBPN/mDso5cORbFKZTg4m D0LPiuJ/szgF7AyUh12uaV2O8jYlmmNes6eEow+lM+iy+JoezfGWcyTbamnNU83FOyMUpf j4ULGFf6LP43BhC9WREvr9BjobZZ0qHZBHk9yIZO038uz1QCtf4CeG28J8auqC3esTa0+g fXAMUDL3w83Wky7UdRY7Td0/77f09QQlluF9AhzipEK2fjGoV7tuAlcuIEZ8pg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 70CB41E7C; Wed, 23 Mar 2022 20:33:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22NKXKGM075737; Wed, 23 Mar 2022 20:33:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22NKXKiG075736; Wed, 23 Mar 2022 20:33:20 GMT (envelope-from git) Date: Wed, 23 Mar 2022 20:33:20 GMT Message-Id: <202203232033.22NKXKiG075736@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: b2cb74c22c4f - main - arm,arm64: Add a NT_ARM_TLS read-only register set. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b2cb74c22c4f7087f342cf50b116b040de6bdc6c Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648067600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hK1N9xNNQs/jtfTSAuX6Bwta5hubad5jiv/h1ou8dCs=; b=DQfYEe9cC0ZI3+kzXsnXelpMmhR9BZlnBGjfMo8zv9s8rolrmpXDdTKq/vclJmWkmhlKpH ID3/EUomh4aMyl0NDgh76Y9VbRe48vH0splpkNxvDVIvowyqtfkRgwJfsSygkH6kYVnXk7 CwP7re2ELMAPS9kiE7aKJgE9W0ATNqPaKrBx2s9Gudi97VjLeh1BU7wZ91fEkrYub5HlQM ffOsmYkthgwwLR/ioVTwRaB0rNDrfR7NZp8zXbjjjmtWbW7ZP3UjI7863jpsO/Ay1ldtwV 8nQVoO22nFW2ssKNaHbFZo8iiWoQ1IzmHD41T84fx0jtkIRdne36GU/k9iJYAg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648067600; a=rsa-sha256; cv=none; b=iQw9UnzPgyBII7oxwwtegiRc7bgfDy+2lgkHzhCSmhYCeQaZJ/yh/0Qjtn6vmFaXBKeZ2q wloPigWvx1EsEixr+Ly4/bkbx6AUxmKzIM64y1QEzTXrXylnM9E8OeWKj71HFBodOOthh2 9WJbte4FQHYrRoBLjGbZoFwQDPqrcQ0og+HqoujcGQQqHSw3ip72hwKQbF70sX70KbRZYQ tOFtDY+cIQtX3gQ3cTD+khkmgXgPni/mtjZoZnmVpCvioii35WV0wfpG9rUcf+bSDEbK49 gGGHhoPiqWds7MJ3fF29UGNHBd3pwWS3TJVG1/YUQgD0Ut4+Q2B3nCWPZw7/LQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=b2cb74c22c4f7087f342cf50b116b040de6bdc6c commit b2cb74c22c4f7087f342cf50b116b040de6bdc6c Author: John Baldwin AuthorDate: 2022-03-23 20:33:06 +0000 Commit: John Baldwin CommitDate: 2022-03-23 20:33:06 +0000 arm,arm64: Add a NT_ARM_TLS read-only register set. This register set exposes the per-thread TLS register. It matches the layout used by Linux on arm64. Linux does not implement this note for 32-bit arm. Reviewed by: andrew, markj Sponsored by: University of Cambridge, Google, Inc. Differential Revision: https://reviews.freebsd.org/D34595 --- contrib/elftoolchain/readelf/readelf.c | 1 + sys/arm/arm/ptrace_machdep.c | 22 ++++++++++++++++ sys/arm64/arm64/ptrace_machdep.c | 48 ++++++++++++++++++++++++++++++++++ sys/sys/elf_common.h | 1 + usr.bin/gcore/elfcore.c | 3 +++ 5 files changed, 75 insertions(+) diff --git a/contrib/elftoolchain/readelf/readelf.c b/contrib/elftoolchain/readelf/readelf.c index fd8e75b66b56..fa3cdca3d682 100644 --- a/contrib/elftoolchain/readelf/readelf.c +++ b/contrib/elftoolchain/readelf/readelf.c @@ -1197,6 +1197,7 @@ note_type_freebsd_core(unsigned int nt) case 0x102: return "NT_PPC_VSX (ppc VSX registers)"; case 0x202: return "NT_X86_XSTATE (x86 XSAVE extended state)"; case 0x400: return "NT_ARM_VFP (arm VFP registers)"; + case 0x401: return "NT_ARM_TLS (arm TLS register)"; case 0x406: return "NT_ARM_ADDR_MASK (arm address mask)"; default: return (note_type_unknown(nt)); } diff --git a/sys/arm/arm/ptrace_machdep.c b/sys/arm/arm/ptrace_machdep.c index d8acc58d0fd0..3edadbd72ddf 100644 --- a/sys/arm/arm/ptrace_machdep.c +++ b/sys/arm/arm/ptrace_machdep.c @@ -67,6 +67,28 @@ static struct regset regset_arm_vfp = { ELF_REGSET(regset_arm_vfp); #endif +static bool +get_arm_tls(struct regset *rs, struct thread *td, void *buf, + size_t *sizep) +{ + if (buf != NULL) { + KASSERT(*sizep == sizeof(td->td_pcb->pcb_regs.sf_tpidrurw), + ("%s: invalid size", __func__)); + memcpy(buf, &td->td_pcb->pcb_regs.sf_tpidrurw, + sizeof(td->td_pcb->pcb_regs.sf_tpidrurw)); + } + *sizep = sizeof(td->td_pcb->pcb_regs.sf_tpidrurw); + + return (true); +} + +static struct regset regset_arm_tls = { + .note = NT_ARM_TLS, + .size = sizeof(uint32_t), + .get = get_arm_tls, +}; +ELF_REGSET(regset_arm_tls); + int cpu_ptrace(struct thread *td, int req, void *addr, int data) { diff --git a/sys/arm64/arm64/ptrace_machdep.c b/sys/arm64/arm64/ptrace_machdep.c index eac1ebe79ae9..79aff19571c9 100644 --- a/sys/arm64/arm64/ptrace_machdep.c +++ b/sys/arm64/arm64/ptrace_machdep.c @@ -81,6 +81,54 @@ static struct regset regset_arm_vfp = { ELF32_REGSET(regset_arm_vfp); #endif +static bool +get_arm64_tls(struct regset *rs, struct thread *td, void *buf, + size_t *sizep) +{ + if (buf != NULL) { + KASSERT(*sizep == sizeof(td->td_pcb->pcb_tpidr_el0), + ("%s: invalid size", __func__)); + memcpy(buf, &td->td_pcb->pcb_tpidr_el0, + sizeof(td->td_pcb->pcb_tpidr_el0)); + } + *sizep = sizeof(td->td_pcb->pcb_tpidr_el0); + + return (true); +} + +static struct regset regset_arm64_tls = { + .note = NT_ARM_TLS, + .size = sizeof(uint64_t), + .get = get_arm64_tls, +}; +ELF_REGSET(regset_arm64_tls); + +#ifdef COMPAT_FREEBSD32 +static bool +get_arm_tls(struct regset *rs, struct thread *td, void *buf, + size_t *sizep) +{ + if (buf != NULL) { + uint32_t tp; + + KASSERT(*sizep == sizeof(uint32_t), + ("%s: invalid size", __func__)); + tp = (uint32_t)td->td_pcb->pcb_tpidr_el0; + memcpy(buf, &tp, sizeof(tp)); + } + *sizep = sizeof(uint32_t); + + return (true); +} + +static struct regset regset_arm_tls = { + .note = NT_ARM_TLS, + .size = sizeof(uint32_t), + .get = get_arm_tls, +}; +ELF32_REGSET(regset_arm_tls); +#endif + int ptrace_set_pc(struct thread *td, u_long addr) { diff --git a/sys/sys/elf_common.h b/sys/sys/elf_common.h index 0bc93659adc5..022bbf450e6c 100644 --- a/sys/sys/elf_common.h +++ b/sys/sys/elf_common.h @@ -825,6 +825,7 @@ typedef struct { #define NT_PPC_VSX 0x102 /* PowerPC VSX registers */ #define NT_X86_XSTATE 0x202 /* x86 XSAVE extended state. */ #define NT_ARM_VFP 0x400 /* ARM VFP registers */ +#define NT_ARM_TLS 0x401 /* ARM TLS register */ #define NT_ARM_ADDR_MASK 0x406 /* arm64 address mask (e.g. for TBI) */ /* GNU note types. */ diff --git a/usr.bin/gcore/elfcore.c b/usr.bin/gcore/elfcore.c index 42d90aaaf155..c3ef36938ea9 100644 --- a/usr.bin/gcore/elfcore.c +++ b/usr.bin/gcore/elfcore.c @@ -372,6 +372,9 @@ elf_putnotes(pid_t pid, struct sbuf *sb, size_t *sizep) elf_putregnote(NT_FPREGSET, tids[i], sb); elf_putnote(NT_THRMISC, elf_note_thrmisc, tids + i, sb); elf_putnote(NT_PTLWPINFO, elf_note_ptlwpinfo, tids + i, sb); +#if defined(__aarch64__) || defined(__arm__) + elf_putregnote(NT_ARM_TLS, tids[i], sb); +#endif #if (defined(ELFCORE_COMPAT_32) && defined(__aarch64__)) || defined(__arm__) elf_putregnote(NT_ARM_VFP, tids[i], sb); #endif