Re: git: 0e5c72c3cc54 - main - bsdinstall time: Replace dialog with bsddialog

On Wed, 23 Mar 2022 16:01:04 +0000
Jessica Clarke <jrtc27@freebsd.org> wrote:

Thank you for the report,

> >    bsdinstall time: Replace dialog with bsddialog
> > 
> >    Replace (LGPL) dialog utility with (BSD-2-Clause) bsddialog utility,
> >    'dialog --calendar' is replaced by 'bsddialog --datebox' with same
> >    features but different User Interface.
> 
> Different in what way?..


dialog --calendar draws a calendar (similar to cal(1) output) while
bsddialog --datebox draws 3 forms "multi-selection" to choose yy/mm/dd,
options and output are the same (at least for the needs of bsdinstall).

To try with a recent CURRENT:
% dialog --calendar test 0 0
% bsddialog --datebox test 0 0

Do you or some BASE-component need a perfect --calendar UI implementation?
If yes, what is the priority?

> > # Set date
> > exec 3>&1
> > -DATE=$(dialog --backtitle 'FreeBSD Installer' \
> > -	--title 'Time & Date' \
> > +DATE=$(bsddialog --backtitle 'FreeBSD Installer' \
> > +	--title ' Date ' \
> 
> Why do these both have spaces around them?

I honestly forgot if it is a typo or a choice (I like it).
However, I checked you are right: all other titles have not spaces around
so I'll open a new review to fix.


Alfonso

-- 
Alfonso S. Siciliano <alf.siciliano@gmail.com>