From nobody Tue Mar 15 16:51:12 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 147C11A2E2CE; Tue, 15 Mar 2022 16:51:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KHzv471N0z4sdk; Tue, 15 Mar 2022 16:51:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647363073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AsjSwf2hAQt4ATOfVEvsFVFRM1BlIgB4rRBpW43SnVY=; b=hH5URXUzty4Nh1Q0E0YwhK6iz7JOs36bMbOd7dNoH0LbamDsav1+FV5VDZcNUmbjtQacSX 40I1nGPh8HLAuumK2wUueb010aTuWgfBnf+PtNsgKZ7+LF1RaqQfKRlL9KmNXB7jjonesI I65y6UjuxreKhFF1NBlIcnRXfOGnFu7KUXslDjSC75DJsAs62Ec1i50qwroahdNyW6qxmr 6mMpfomQhu37VaDKZzfPOFLWnNGKLM9BWEHE7uBIPDoPoE3ayotzr1JfLpZX41RZJ/1g/g PpvieESEufvY0P5aeDvhuNYyifDylI1dojIHTlPxldROHqSNgOJteWP2RL0CBw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D080925471; Tue, 15 Mar 2022 16:51:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22FGpCtt061229; Tue, 15 Mar 2022 16:51:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22FGpCP5061228; Tue, 15 Mar 2022 16:51:12 GMT (envelope-from git) Date: Tue, 15 Mar 2022 16:51:12 GMT Message-Id: <202203151651.22FGpCP5061228@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gordon Tetlow Subject: git: fdc418f15e92 - main - Fix a bug in BN_mod_sqrt() that can cause it to loop forever. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fdc418f15e92732a3551832bcb625ba9b47242df Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647363073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AsjSwf2hAQt4ATOfVEvsFVFRM1BlIgB4rRBpW43SnVY=; b=EIn4QMSZvtyOZTq/h+B87Ndg1CdUJNqewIRNNwYzxgq+WlEUpSyhU5YhIFSzg1GuS3KG4Y 8NvFUz2CLMZEhp3kUvt8AM7JcBC0Fn5MYLvgEqbpl/rUc19uxlFcSialM2zHM0DD2thsuW xB6XV34RFq230Ugl6+DxdnSeAXKYRODVLgiJgLonwLf7X0dY0SfIzHciWhtiZfkCrRj+iY rj5jb3C5pVmpnz2+3ruhzWTmam0oK2VAYrfH3TK9idcSxLFbADvWCF8KQUksqRLjQD+Mvl QkOxkTRpVftso3GcnatR0uWYnKifp4fBJE0HRqkQt4+VhZLOC14ZRZOqNEDDBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647363073; a=rsa-sha256; cv=none; b=idP1Nud0uuxHZhNBhy9XcQz+oXRFW3weQJDODzJK9mvawBViEc7Ac7EE+W5/7xNNl0jAKM tgjc0YE3D4KFK8enicajS5h7/KhVMerS8RShB37Y/gYh/k7wkG0ytvQ9k9cEuqndDIimeO LuINQDeEF9wmltifsSb0hbmiqPoQrIhQPAnCgTbFk0+DCsy0bBO/EUDb0Ca7LJ6VzDn+XX E0It6ODwpklpDQt+0iusSeYQKTc8lVaYy3j9URUurQmpcFNsVGFfG2yS4o9gM8q7WCp9wk OtwlW0eLiwTk00Dvizgoc2OujryqFxNrev/gaIpxqXojzDT1pEttled74l9AuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=fdc418f15e92732a3551832bcb625ba9b47242df commit fdc418f15e92732a3551832bcb625ba9b47242df Author: Gordon Tetlow AuthorDate: 2022-03-15 16:48:59 +0000 Commit: Gordon Tetlow CommitDate: 2022-03-15 16:48:59 +0000 Fix a bug in BN_mod_sqrt() that can cause it to loop forever. Obtained from: OpenSSL Project Security: CVE-2022-0778 --- crypto/openssl/crypto/bn/bn_sqrt.c | 30 ++++++++++++++++++------------ crypto/openssl/doc/man3/BN_add.pod | 15 +++++++++++++-- 2 files changed, 31 insertions(+), 14 deletions(-) diff --git a/crypto/openssl/crypto/bn/bn_sqrt.c b/crypto/openssl/crypto/bn/bn_sqrt.c index 1723d5ded5a8..53b0f559855c 100644 --- a/crypto/openssl/crypto/bn/bn_sqrt.c +++ b/crypto/openssl/crypto/bn/bn_sqrt.c @@ -14,7 +14,8 @@ BIGNUM *BN_mod_sqrt(BIGNUM *in, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx) /* * Returns 'ret' such that ret^2 == a (mod p), using the Tonelli/Shanks * algorithm (cf. Henri Cohen, "A Course in Algebraic Computational Number - * Theory", algorithm 1.5.1). 'p' must be prime! + * Theory", algorithm 1.5.1). 'p' must be prime, otherwise an error or + * an incorrect "result" will be returned. */ { BIGNUM *ret = in; @@ -301,18 +302,23 @@ BIGNUM *BN_mod_sqrt(BIGNUM *in, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx) goto vrfy; } - /* find smallest i such that b^(2^i) = 1 */ - i = 1; - if (!BN_mod_sqr(t, b, p, ctx)) - goto end; - while (!BN_is_one(t)) { - i++; - if (i == e) { - BNerr(BN_F_BN_MOD_SQRT, BN_R_NOT_A_SQUARE); - goto end; + /* Find the smallest i, 0 < i < e, such that b^(2^i) = 1. */ + for (i = 1; i < e; i++) { + if (i == 1) { + if (!BN_mod_sqr(t, b, p, ctx)) + goto end; + + } else { + if (!BN_mod_mul(t, t, t, p, ctx)) + goto end; } - if (!BN_mod_mul(t, t, t, p, ctx)) - goto end; + if (BN_is_one(t)) + break; + } + /* If not found, a is not a square or p is not prime. */ + if (i >= e) { + BNerr(BN_F_BN_MOD_SQRT, BN_R_NOT_A_SQUARE); + goto end; } /* t := y^2^(e - i - 1) */ diff --git a/crypto/openssl/doc/man3/BN_add.pod b/crypto/openssl/doc/man3/BN_add.pod index dccd4790ede7..1f5e37a4d183 100644 --- a/crypto/openssl/doc/man3/BN_add.pod +++ b/crypto/openssl/doc/man3/BN_add.pod @@ -3,7 +3,7 @@ =head1 NAME BN_add, BN_sub, BN_mul, BN_sqr, BN_div, BN_mod, BN_nnmod, BN_mod_add, -BN_mod_sub, BN_mod_mul, BN_mod_sqr, BN_exp, BN_mod_exp, BN_gcd - +BN_mod_sub, BN_mod_mul, BN_mod_sqr, BN_mod_sqrt, BN_exp, BN_mod_exp, BN_gcd - arithmetic operations on BIGNUMs =head1 SYNOPSIS @@ -36,6 +36,8 @@ arithmetic operations on BIGNUMs int BN_mod_sqr(BIGNUM *r, BIGNUM *a, const BIGNUM *m, BN_CTX *ctx); + BIGNUM *BN_mod_sqrt(BIGNUM *in, BIGNUM *a, const BIGNUM *p, BN_CTX *ctx); + int BN_exp(BIGNUM *r, BIGNUM *a, BIGNUM *p, BN_CTX *ctx); int BN_mod_exp(BIGNUM *r, BIGNUM *a, const BIGNUM *p, @@ -87,6 +89,12 @@ L. BN_mod_sqr() takes the square of I modulo B and places the result in I. +BN_mod_sqrt() returns the modular square root of I such that +C. The modulus I

must be a +prime, otherwise an error or an incorrect "result" will be returned. +The result is stored into I which can be NULL. The result will be +newly allocated in that case. + BN_exp() raises I to the I

-th power and places the result in I (C). This function is faster than repeated applications of BN_mul(). @@ -108,7 +116,10 @@ the arguments. =head1 RETURN VALUES -For all functions, 1 is returned for success, 0 on error. The return +The BN_mod_sqrt() returns the result (possibly incorrect if I

is +not a prime), or NULL. + +For all remaining functions, 1 is returned for success, 0 on error. The return value should always be checked (e.g., C). The error codes can be obtained by L.