From nobody Sun Mar 13 12:07:39 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1D6361A1FCDE; Sun, 13 Mar 2022 12:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KGdhr0FkYz4fNh; Sun, 13 Mar 2022 12:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647173260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d1DUVkzc14HZfOrK4XAj4YPbDMnhe+qBI2KN1CnaZUQ=; b=qLCcQHgQHLzR5e7Y7RhLn1G+wkvp/A/zR+RXk0ZWIKlweT5ZPn7wpicV0V3r2nXAP2CcBX NC077meQv3U5Dztxadc2kHtNAAtwSCzRzlGWz3r5sKGuWfLZRsRv9z7kssGerSlBAWGVBL 0k3wKzYb/h/XgenqRE7K72R/lPr6LHOx2N6f+PXlrPJKSSg7MAGBST8e70qtrLwvoj48Oz Fm9A/BBXkaPNOqAc+UJj4nKDse0lSTiPgeyu/dlFsGq5XuTacmh3SFgGKYmTWvnUxO5JXy 7Lbehn1uLoAu9B7GWLK1OxFfYvsef08ZvoflPHGNcK9ZV1TLPm84I0klbhjq1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DD1E718D65; Sun, 13 Mar 2022 12:07:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22DC7dMa000317; Sun, 13 Mar 2022 12:07:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22DC7dTY000316; Sun, 13 Mar 2022 12:07:39 GMT (envelope-from git) Date: Sun, 13 Mar 2022 12:07:39 GMT Message-Id: <202203131207.22DC7dTY000316@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Piotr Kubaj Subject: git: 3781e77995e9 - main - riscv: actually enable sanitizers List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pkubaj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3781e77995e9b81afcbf7b3dc84b33b864c48794 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647173260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d1DUVkzc14HZfOrK4XAj4YPbDMnhe+qBI2KN1CnaZUQ=; b=C2be8XijLtJvA7KvgLnNvWao1ouBqeCggaw8J5i6VYjMUMg7tr9mHf5nf40ELuSpxmuKwh DldxVx5TA3qiTqS7TNx/IlhQnSYd6WaXSdgBnoRhNf6SoU6F8fh+S7tyJR7wXZbsRLt6tc xlKqD3jAIODZ7Jkvn8roDwyFeolPUTyHaR4R/S5LDOieNkPzK3vNCID28xilISke6aboKJ tV5sOu9/CDO0az9jFXhEKHXBLmHpnpvtdTWuSSE1IG9QWuFZjnmJbQ3rV9LFyuCPjC1cH/ qB9bXNw/TGj4AcBpDrwpYd3LgO5PSF85BQNF/RsTyei0ZTIOaVEk711dKbwAhg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647173260; a=rsa-sha256; cv=none; b=BquRbAUZpnjd3qbSn+CVrm1gIcUf9p3zdn49drhrsUTehxoT8e85t1Cz1bMGjnqPUI4YOy WHcuRl7O3PtZ48XhRLREXP6gmV8Ft468pLlom2b0QRPR1+FZLODX7X3vclvO26P8aj07vz KK9i2AtLlW8+Wm8OthzZOfY0HaeaCW6KnG54MDpc67dUvT3996FMzcLcvSXS8AnSK6J+Ys vKtI4j6Go3C+uFuGUvar82/YHcLNW6naiO8Gdrxe1szlmORkOUsV+PsBBZSdPSrKIwCNLV UK3Qtk9qvPQrg+113MS0mmtocLwtWQ+No79KAD6S+AienIxHeWZQtmF5jUJSaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by pkubaj (ports committer): URL: https://cgit.FreeBSD.org/src/commit/?id=3781e77995e9b81afcbf7b3dc84b33b864c48794 commit 3781e77995e9b81afcbf7b3dc84b33b864c48794 Author: Piotr Kubaj AuthorDate: 2022-03-13 03:31:35 +0000 Commit: Piotr Kubaj CommitDate: 2022-03-13 12:06:57 +0000 riscv: actually enable sanitizers 1. Backport https://github.com/llvm/llvm-project/commit/b475ce39e8b1de3a70ea242473f136a567be46e3. 2. Enable libclang_rt for riscv. Previous commit missed it. MFC after: 3 days Reviewed by: dim Differential Revision: https://reviews.freebsd.org/D34543 --- .../lib/sanitizer_common/sanitizer_linux.cpp | 22 +++++++++++++++++----- lib/Makefile | 2 +- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/contrib/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/contrib/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp index daa07c15490e..769e8029dfcb 100644 --- a/contrib/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp +++ b/contrib/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp @@ -416,7 +416,7 @@ uptr internal_unlink(const char *path) { } uptr internal_rename(const char *oldpath, const char *newpath) { -#if defined(__riscv) +#if defined(__riscv) && defined(__linux__) return internal_syscall(SYSCALL(renameat2), AT_FDCWD, (uptr)oldpath, AT_FDCWD, (uptr)newpath, 0); #elif SANITIZER_USES_CANONICAL_LINUX_SYSCALLS @@ -1218,7 +1218,8 @@ void ForEachMappedRegion(link_map *map, void (*cb)(const void *, uptr)) { } #endif -#if defined(__x86_64__) && SANITIZER_LINUX +#if SANITIZER_LINUX +#if defined(__x86_64__) // We cannot use glibc's clone wrapper, because it messes with the child // task's TLS. It writes the PID and TID of the child task to its thread // descriptor, but in our case the child task shares the thread descriptor with @@ -1557,7 +1558,7 @@ uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg, : "cr0", "cr1", "memory", "ctr", "r0", "r27", "r28", "r29"); return res; } -#elif defined(__i386__) && SANITIZER_LINUX +#elif defined(__i386__) uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg, int *parent_tidptr, void *newtls, int *child_tidptr) { int res; @@ -1622,7 +1623,7 @@ uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg, : "memory"); return res; } -#elif defined(__arm__) && SANITIZER_LINUX +#elif defined(__arm__) uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg, int *parent_tidptr, void *newtls, int *child_tidptr) { unsigned int res; @@ -1688,7 +1689,8 @@ uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg, : "memory"); return res; } -#endif // defined(__x86_64__) && SANITIZER_LINUX +#endif +#endif // SANITIZER_LINUX #if SANITIZER_LINUX int internal_uname(struct utsname *buf) { @@ -1918,7 +1920,11 @@ SignalContext::WriteFlag SignalContext::GetWriteFlag() const { u32 instr = *(u32 *)pc; return (instr >> 21) & 1 ? WRITE: READ; #elif defined(__riscv) +#if SANITIZER_FREEBSD + unsigned long pc = ucontext->uc_mcontext.mc_gpregs.gp_sepc; +#else unsigned long pc = ucontext->uc_mcontext.__gregs[REG_PC]; +#endif unsigned faulty_instruction = *(uint16_t *)pc; #if defined(__riscv_compressed) @@ -2137,9 +2143,15 @@ static void GetPcSpBp(void *context, uptr *pc, uptr *sp, uptr *bp) { *sp = ucontext->uc_mcontext.gregs[15]; #elif defined(__riscv) ucontext_t *ucontext = (ucontext_t*)context; +# if SANITIZER_FREEBSD + *pc = ucontext->uc_mcontext.mc_gpregs.gp_sepc; + *bp = ucontext->uc_mcontext.mc_gpregs.gp_s[0]; + *sp = ucontext->uc_mcontext.mc_gpregs.gp_sp; +# else *pc = ucontext->uc_mcontext.__gregs[REG_PC]; *bp = ucontext->uc_mcontext.__gregs[REG_S0]; *sp = ucontext->uc_mcontext.__gregs[REG_SP]; +# endif #else # error "Unsupported arch" #endif diff --git a/lib/Makefile b/lib/Makefile index d34f40616396..816374552f0a 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -184,7 +184,7 @@ SUBDIR.${MK_STATS}+= libstats .if ${COMPILER_TYPE} == "clang" && ${MK_CXX} != "no" && \ (${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_CPUARCH} == "amd64" || \ ${MACHINE_CPUARCH} == "arm" || ${MACHINE_CPUARCH} == "i386" || \ - ${MACHINE_CPUARCH} == "powerpc") + ${MACHINE_CPUARCH} == "powerpc" || ${MACHINE_CPUARCH} == "riscv") _libclang_rt= libclang_rt .elif (${MK_ASAN} != "no" || ${MK_UBSAN} != "no") && make(all) .error Requested build with sanitizers but cannot build runtime libraries!