From nobody Fri Mar 11 17:20:50 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0EF6019FC79E; Fri, 11 Mar 2022 17:20:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KFXl76p0wz4jTW; Fri, 11 Mar 2022 17:20:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647019252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bp8bnXTi9EgThj98bLbQxjx84/gISvZv1iSDJc8S7Oc=; b=qFLbPAndWWfbdi65ouZPn846huOPww/UBVz1j7s0zHG7qE93LZHRaa6ow+lexMyFUMLKEx XqrvWgTmCZMgv6S0KoQ+Rk+7yz1E9zBY6C2NmLF18Du1AkqIqH2DXLChHMe3j1xtjjI0No vf3j5nRPDmsIDCa2avTpxH81c69EO36jx7bNZFCBIfccT1ir3sc6sLqu+1AoSokCjciq55 ya5aG3S01lMhOSQbr+rN+awdNd4pJyQeDlAY5AXnQYE/EC7sNQhRBsvaJsLm5kWHsseQsp YgoCkwajAhAYFfXwtKp7ioWobMbFWoDxF93OvWlebvAp4pHg4kw3W+pRTMRcSA== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 3080C2E43C; Fri, 11 Mar 2022 17:20:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 11 Mar 2022 09:20:50 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: git: 832acea92fc8 - main - icl_soft: Use PHYS_TO_DMAP instead of pmap_map_io_transient. Content-Language: en-US To: Andrew Turner Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202203110221.22B2LmuN037273@gitrepo.freebsd.org> <87FDC36E-0A15-4E43-A1C7-A2F61D60526F@fubar.geek.nz> From: John Baldwin In-Reply-To: <87FDC36E-0A15-4E43-A1C7-A2F61D60526F@fubar.geek.nz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647019252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bp8bnXTi9EgThj98bLbQxjx84/gISvZv1iSDJc8S7Oc=; b=G52oPRNhrbUMYgD3x3+upJjL9QexjL7PkdJLgR0FuNVQsZd4SsamN8UCW9+xX3M6dh1mjB t2LKonCttudsR/pvy8NgN7d0tiIy/67rN655Xf4F1XnxL/5ZJ5PgWPshQwVeQBRZ2K9TOp XXtLMyAuyFPTu9lDRS/FimEBBS4pa0NBvnH6pufldVqYqzAYILSprqurecnBRz1NmRvQGv Yoy+p6vTB3IIWJNwc2oom5Q3R4Y0xmo5ZsoGObX2MMU8aY5SqSmIMAIcI+3RDd79tNN4qP ri2pWdRsf9OWkirjgrGwpX/SK/Cg1H5MjHQmH7YAxqJLujN8tZBJtewyOdwqzQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647019252; a=rsa-sha256; cv=none; b=I5dtUUe9T/11k5ogTmnXr0cKmXXxY6kFfc3uuq3E1uNctdb2rOoXm0IK2WHweF8u1v/TqS orGIMgPql8J/JGIu6LvuUUsRqudFirRVShZYuu6Ci7gKMl/ZdHVUbxlO/7MpTp+oY2exy+ B+3NUFGScndfuuZgeHBj4aeLockgmEQbFk7EUxT2Ckq77FHpmv6hjGo+ZiS+f6nhkWpPBm yksKNs8ThgYGTtinY5e/yQeRG5TyNwEmh4bZiNMDdYYhHEnP20hQfBDVrQZ+TVAvqjB76h YmbFn/hfV0j3yLEekWB9xfRo++X0JbfkfZ6G7mGSQAoROktKPtfl3qiNofwknQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 3/11/22 1:32 AM, Andrew Turner wrote: > > >> On 11 Mar 2022, at 02:21, John Baldwin wrote: >> >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=832acea92fc8cdb55859a6a4b1bc38bf766780f1 >> >> commit 832acea92fc8cdb55859a6a4b1bc38bf766780f1 >> Author: John Baldwin >> AuthorDate: 2022-03-11 02:20:28 +0000 >> Commit: John Baldwin >> CommitDate: 2022-03-11 02:20:28 +0000 >> >> icl_soft: Use PHYS_TO_DMAP instead of pmap_map_io_transient. > > The i386 and arm version of PHYS_TO_DMAP is: > #define PHYS_TO_DMAP(x) ({ panic("No direct map exists"); 0; }) > > On these architectures there is no DMAP region. > > On powerpc there may not be a DMAP region. It appears to depend on the CPU. > > You can use PMAP_HAS_DMAP to check if the DMAP region is supported, however you’ll need a fallback to create a temporary mapping. The earlier commit does use PMAP_HAS_DMAP to set ic->unmapped, so these functions are not used as CAM won't schedule CCB's with CAM_DATA_BIO. (The detail about honoring PMAP_HAS_DMAP is in the log of the previous commit to icl_soft.c.) This is similar to how GELI deals with supporting unmapped I/O requests (it only advertises support from the disk layer if PMAP_HAS_DMAP is true). -- John Baldwin